Hi,
right now the current cvs trunk orders by date in a very strange way. I suspect it has something to do with me using an ISO-ish date format string (Y-m-d H:S) to display dates in the date column. In any case the last couple of day entries end up between older (above) and really old (below) mails.
Sorting done after translating to user's timeformat instead of before?
Auke
Tis a problem in lib/imap.inc:
if ($field=="timestamp"){
$data = @strtotime($value->date);
if ($data != false)
$data = $timestamp;
}
Should be
if ($field=="timestamp"){
$timestamp= @strtotime($val->date);
if ($timestamp!= false)
$data = $timestamp;
}
(use of $value when should be $val and $data when should be $timestamp)
Not being fully au fait with CVS, please can someone do the honours?
Thanks, Richard
On Sat, 25 Mar 2006 6:24:59 +0000, sofar sofar@foo-projects.org wrote:
Hi,
right now the current cvs trunk orders by date in a very strange way. I suspect it has something to do with me using an ISO-ish date format string (Y-m-d H:S) to display dates in the date column. In any case the last couple of day entries end up between older (above) and really old (below) mails.
Sorting done after translating to user's timeformat instead of before?
Auke
Confirmed, this fixes the problem I was having. Thanks!
On Sat, 25 Mar 2006 10:25:32 +0000, Richard Green richard@burninghorizons.net wrote:
Tis a problem in lib/imap.inc:
if ($field=="timestamp"){ $data = @strtotime($value->date); if ($data != false) $data = $timestamp; }Should be
if ($field=="timestamp"){ $timestamp= @strtotime($val->date); if ($timestamp!= false) $data = $timestamp; }
yup that fixes it. Still not spotted this in CVS tho!
diff -u -r1.16 imap.inc --- program/lib/imap.inc 23 Mar 2006 22:32:33 -0000 1.16 +++ program/lib/imap.inc 25 Mar 2006 17:22:27 -0000 @@ -1413,8 +1413,8 @@ while (list($key, $val)=each($a)){
if ($field=="timestamp"){
$data = @strtotime($value->date);if ($data != false)
$timestamp = @strtotime($val->date);if ($timestamp != false) $data = $timestamp; } else {
On Sat, 25 Mar 2006 10:25:32 +0000, Richard Green richard@burninghorizons.net wrote:
Tis a problem in lib/imap.inc:
if ($field=="timestamp"){ $data = @strtotime($value->date); if ($data != false) $data = $timestamp; }Should be
if ($field=="timestamp"){ $timestamp= @strtotime($val->date); if ($timestamp!= false) $data = $timestamp; }(use of $value when should be $val and $data when should be $timestamp)
Not being fully au fait with CVS, please can someone do the honours?
Thanks, Richard
On Sat, 25 Mar 2006 6:24:59 +0000, sofar sofar@foo-projects.org wrote:
Hi,
right now the current cvs trunk orders by date in a very strange way. I suspect it has something to do with me using an ISO-ish date format
string
(Y-m-d H:S) to display dates in the date column. In any case the last couple of day entries end up between older (above) and really old
(below)
mails.
Sorting done after translating to user's timeformat instead of before?
Auke
What do you mean when you say you haven't spotted this in CVS?
You have version 1.16, which is the latest (as far as I know).
On Sat, 25 Mar 2006, sofar wrote:
yup that fixes it. Still not spotted this in CVS tho!
diff -u -r1.16 imap.inc --- program/lib/imap.inc 23 Mar 2006 22:32:33 -0000 1.16 +++ program/lib/imap.inc 25 Mar 2006 17:22:27 -0000 @@ -1413,8 +1413,8 @@ while (list($key, $val)=each($a)){
if ($field=="timestamp"){
$data = @strtotime($value->date);if ($data != false)
$timestamp = @strtotime($val->date);if ($timestamp != false) $data = $timestamp; } else {
Version 1.16 is the bugged one :-) we're waiting for the below fix to be applied! I'd do it myself, but I'm a cvs newb and I presume I need an account or something.
Jon Daley wrote:
What do you mean when you say you haven't spotted this in CVS? Youhave version 1.16, which is the latest (as far as I know).
On Sat, 25 Mar 2006, sofar wrote:
yup that fixes it. Still not spotted this in CVS tho!
diff -u -r1.16 imap.inc --- program/lib/imap.inc 23 Mar 2006 22:32:33 -0000 1.16 +++ program/lib/imap.inc 25 Mar 2006 17:22:27 -0000 @@ -1413,8 +1413,8 @@ while (list($key, $val)=each($a)){
if ($field=="timestamp"){
$data = @strtotime($value->date);if ($data != false)
$timestamp = @strtotime($val->date);if ($timestamp != false) $data = $timestamp; } else {
On Sat, 25 Mar 2006 12:31:10 -0500 (EST), Jon Daley roundcube@jon.limedaley.com wrote:
What do you mean when you say you haven't spotted this in CVS? You have version 1.16, which is the latest (as far as I know).
that means that even though a fix was proposed, confirmed and ready that noone has committed it yet to CVS.
Auke
On Sat, 25 Mar 2006, sofar wrote:
yup that fixes it. Still not spotted this in CVS tho!
diff -u -r1.16 imap.inc --- program/lib/imap.inc 23 Mar 2006 22:32:33 -0000 1.16 +++ program/lib/imap.inc 25 Mar 2006 17:22:27 -0000 @@ -1413,8 +1413,8 @@ while (list($key, $val)=each($a)){
if ($field=="timestamp"){
$data = @strtotime($value->date);if ($data != false)
$timestamp = @strtotime($val->date);if ($timestamp != false) $data = $timestamp; } else {
On Sat, 25 Mar 2006, sofar wrote:
What do you mean when you say you haven't spotted this in CVS? You have version 1.16, which is the latest (as far as I know).
that means that even though a fix was proposed, confirmed and ready that noone has committed it yet to CVS.
Yes, I see. You do have be a little patient - at least a couple
hours for a bug to be fixed... (:
Patch applied to imap.inc. But messages still do not get sorted correctly.
Steffen
On Sat, 25 Mar 2006 19:53:35 +0000, sofar sofar@foo-projects.org wrote:
On Sat, 25 Mar 2006 12:31:10 -0500 (EST), Jon Daley roundcube@jon.limedaley.com wrote:
What do you mean when you say you haven't spotted this in CVS? You have version 1.16, which is the latest (as far as I know).
that means that even though a fix was proposed, confirmed and ready that noone has committed it yet to CVS.
Auke
On Sat, 25 Mar 2006, sofar wrote:
yup that fixes it. Still not spotted this in CVS tho!
diff -u -r1.16 imap.inc --- program/lib/imap.inc 23 Mar 2006 22:32:33 -0000 1.16 +++ program/lib/imap.inc 25 Mar 2006 17:22:27 -0000 @@ -1413,8 +1413,8 @@ while (list($key, $val)=each($a)){
if ($field=="timestamp"){
$data = @strtotime($value->date);if ($data != false)
$timestamp = @strtotime($val->date);if ($timestamp != false) $data = $timestamp; } else {
On Sat, 25 Mar 2006 10:25:32 +0000, Richard Green richard@burninghorizons.net wrote:
Tis a problem in lib/imap.inc:
if ($field=="timestamp"){ $data = @strtotime($value->date); if ($data != false) $data = $timestamp; }Should be
if ($field=="timestamp"){ $timestamp= @strtotime($val->date); if ($timestamp!= false) $data = $timestamp; }
A problem I found with this new sort ordering that's in CVS is that order by date orders by the date of the mail, and not by the incoming date. Is there a way to get an incoming order sort, because I get mails from clients with buggy clocks disorderd.
The corrections are now committed to the CVS. Please don't expect patches to be committed within 12 hours. We are very thankful for them but no one of the project members can afford to work on the project the whole day.
Regards, Thomas
Martin Marques wrote:
On Sat, 25 Mar 2006 10:25:32 +0000, Richard Green richard@burninghorizons.net wrote:
Tis a problem in lib/imap.inc:
if ($field=="timestamp"){ $data = @strtotime($value->date); if ($data != false) $data = $timestamp; }Should be
if ($field=="timestamp"){ $timestamp= @strtotime($val->date); if ($timestamp!= false) $data = $timestamp; }A problem I found with this new sort ordering that's in CVS is that order by date orders by the date of the mail, and not by the incoming date. Is there a way to get an incoming order sort, because I get mails from clients with buggy clocks disorderd.
On Mon, 27 Mar 2006 21:05:52 +0200, Thomas Bruederli roundcube@gmail.com wrote:
The corrections are now committed to the CVS. Please don't expect patches to be committed within 12 hours. We are very thankful for them but no one of the project members can afford to work on the project the whole day.
A problem I found with this new sort ordering that's in CVS is that
order by date orders by the date of the mail, and not by the incoming date. Is there a way to get an incoming order sort, because I get mails from clients with buggy clocks disorderd.
Does it mean that now messages are sorted with arrival time (I guess that's "no sort at all") instead of sorting by the "date" header?
-
Jon Daley -
Martin Marques -
Richard Green -
sofar -
Steffen -
Thomas Bruederli