Alec tipped me to look at the rcube_template::button method, which
handles the use of labels. Unfortunately with those icons that are
created as a "link" type, no label is possible. When I specify no type
(like in the #taskbar div), there's no change. Perhaps some
inheritance or overriding is done elsewhere that changes this
behaviour for the #mailboxcontrols div. I haven't really found the
time to look into this. Perhaps some CSS tweaking in a plugin could do
the trick, in combination with javascript DOM manipulation. I'd love
to use a plugin which changes the default behaviour. Plugins like that
make upgrades very easy.
Perhaps I'll spend some time on a plugin that uses javascript to
change some of those elements in the DOM. I like the icons, they add
something to the user experience, instead of only text labels. But
only icons, that's not really an improvement for user experience. And
user experience is one of the main features that sets RC apart from
all the other webmail clients.
Br.
Dennis
Op 22 apr 2010, om 18:17 heeft Emerson Pinter het volgende geschreven:
I use labels in all buttons, all screens. I have one div after "<roundcube:container name="toolbar" id="messagetoolbar" />" and a roundcube:container (exclusive for the labels) inside this div. In this div there's one <span> (with the
label) for each button. If I need to add a new button from a plugin (example, archive plugin), I have to modify the plugin to add the label inside
my label container (is positioned after all existent labels). The label positions are controlled using clear and float attributes.-- Emerson Pinter
On Thu, 22 Apr 2010 09:44:43 +0200, Dennis Ortsen dortsen@gmail.com wrote:
Hi everyone,
I guess it's been discussed before, but I can't find any recent (last 6 months) discussions about it: text labels around (besides, below) images/icons in the default skin. We're using 0.3.1-stable BTW.
The only icons that have text labels besides them are in the #taskbar div at the top right of the default skin. Judging from the template for the taskbar, I would guess its pretty easy to add text labels on other icons. For instance around those in the #mailboxcontrols div. Instead of the default:
<roundcube:button command="expunge" type="link" title="compact" class="buttonPas expunge" classAct="button expunge" classSel="button expungesel" content=" " />
I added label="expunge":
<roundcube:button command="expunge" label="expunge" type="link" title="compact" class="buttonPas expunge" classAct="button expunge" classSel="button expungesel" content=" " />
Adding a label tag doesn't have any result, though the same syntax is used in the #tasbar:
<roundcube:button command="mail" label="mail" class="button-mail" />
What am I missing here?
thanks in advance,
Br.
Dennis _______________________________________________ List info: http://lists.roundcube.net/dev/
Esta mensagem pode conter informações confidenciais, privilegiadas
ou privadas. Caso não seja o destinatário, favor apagá-la e notificar o remetente. Saiba que o uso impróprio das informações existentes é estritamente proibido, sendo tratado conforme as normas da empresa e a legislação
em vigor.
List info: http://lists.roundcube.net/dev/
I tried to use the rcube_template::button, no way ... I told to Thomas about it, but he said me if the button label feature happen on roundcube, will not be so soon...
I prefer plugins too, but for skin changes, I don't use plugins. For the labels, I don't need to write any new plugins or modify the roundcube code, just few lines of templates, css and mod 2 plugins to add labels too ... (forwardatt and archive)
> handles the use of labels. Unfortunately with those icons that are
> created as a "link" type, no label is possible. When I specify no type
> (like in the #taskbar div), there's no change. Perhaps some
> inheritance or overriding is done elsewhere that changes this
> behaviour for the #mailboxcontrols div. I haven't really found the
> time to look into this. Perhaps some CSS tweaking in a plugin could do
> the trick, in combination with javascript DOM manipulation. I'd love
> to use a plugin which changes the default behaviour. Plugins like that
> make upgrades very easy. > > Perhaps I'll spend some time on a plugin that uses javascript to
> change some of those elements in the DOM. I like the icons, they add
> something to the user experience, instead of only text labels. But
> only icons, that's not really an improvement for user experience. And
> user experience is one of the main features that sets RC apart from
> all the other webmail clients. > > Br. > > Dennis > > Op 22 apr 2010, om 18:17 heeft Emerson Pinter het volgende geschreven: > >> I use labels in all buttons, all screens. >> I have one div after "<roundcube:container name="toolbar" >> id="messagetoolbar" />" and a roundcube:container (exclusive for the >> labels) inside this div. In this div there's one <span> (with the
>> label) >> for each button. If I need to add a new button from a plugin (example, >> archive plugin), I have to modify the plugin to add the label inside
>> my >> label container (is positioned after all existent labels). The label >> positions are controlled using clear and float attributes. >> >> >> -- >> Emerson Pinter >> >> On Thu, 22 Apr 2010 09:44:43 +0200, Dennis Ortsen dortsen@gmail.com >> wrote: >>> Hi everyone, >>> >>> I guess it's been discussed before, but I can't find any recent (last >>> 6 months) discussions about it: text labels around (besides, below) >>> images/icons in the default skin. We're using 0.3.1-stable BTW. >>> >>> The only icons that have text labels besides them are in the #taskbar >>> div at the top right of the default skin. Judging from the template >>> for the taskbar, I would guess its pretty easy to add text labels on >>> other icons. For instance around those in the #mailboxcontrols div. >>> Instead of the default: >>> >>> <roundcube:button command="expunge" type="link" title="compact" >>> class="buttonPas expunge" classAct="button expunge" classSel="button >>> expungesel" content=" " /> >>> >>> I added label="expunge": >>> >>> <roundcube:button command="expunge" label="expunge" type="link" >>> title="compact" class="buttonPas expunge" classAct="button expunge" >>> classSel="button expungesel" content=" " /> >>> >>> Adding a label tag doesn't have any result, though the same syntax is >>> used in the #tasbar: >>> >>> <roundcube:button command="mail" label="mail" class="button-mail" /> >>> >>> What am I missing here? >>> >>> thanks in advance, >>> >>> Br. >>> >>> Dennis >>> _______________________________________________ >>> List info: http://lists.roundcube.net/dev/ >> Esta mensagem pode conter informações confidenciais, privilegiadas
>> ou privadas. >> Caso não seja o destinatário, favor apagá-la e notificar o remetente. >> Saiba que o uso impróprio das informações existentes é estritamente >> proibido, sendo tratado conforme as normas da empresa e a legislação
>> em vigor. --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/CU/C7hGohBF/disclaimer.txt Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/
Hi there, If what you want is to just modify it by using javascript and CSS, then you can execute/include it with a plugin: $("a.button, a.buttonPas", $("#messagetoolbar")).each(function(){ var t = $(this);
/* This is the tip/label. The text is the Link Title or whatever you think it should be. Maybe configurable? */ var tip = $("<span>" + t.attr('title') + "</span>");
/* This appends the tip to the button. You may wish to add it after the button, wich would be using after() instead */ t.append(tip); });
And add necessary CSS rules with the plugin (CSS rules with afetr() are more difficult/less accessible because they need the + CSS selector): #messagetoolbar a.button span, #messagetoolbar a.buttonPas span { ...whatever... }
I wish it's useful :) emi
2010/4/23 Emerson Pinter epinter@picturecorp.com.br:
I tried to use the rcube_template::button, no way ... I told to Thomas about it, but he said me if the button label feature happen on roundcube, will not be so soon...
I prefer plugins too, but for skin changes, I don't use plugins. For the labels, I don't need to write any new plugins or modify the roundcube code, just few lines of templates, css and mod 2 plugins to add labels too ... (forwardatt and archive)
-- Emerson Pinter
On Fri, 23 Apr 2010 09:54:50 +0200, Dennis Ortsen dortsen@gmail.com wrote:
Alec tipped me to look at the rcube_template::button method, which handles the use of labels. Unfortunately with those icons that are created as a "link" type, no label is possible. When I specify no type (like in the #taskbar div), there's no change. Perhaps some inheritance or overriding is done elsewhere that changes this behaviour for the #mailboxcontrols div. I haven't really found the time to look into this. Perhaps some CSS tweaking in a plugin could do the trick, in combination with javascript DOM manipulation. I'd love to use a plugin which changes the default behaviour. Plugins like that make upgrades very easy.
Perhaps I'll spend some time on a plugin that uses javascript to change some of those elements in the DOM. I like the icons, they add something to the user experience, instead of only text labels. But only icons, that's not really an improvement for user experience. And user experience is one of the main features that sets RC apart from all the other webmail clients.
Br.
Dennis
Op 22 apr 2010, om 18:17 heeft Emerson Pinter het volgende geschreven:
I use labels in all buttons, all screens. I have one div after "<roundcube:container name="toolbar" id="messagetoolbar" />" and a roundcube:container (exclusive for the labels) inside this div. In this div there's one <span> (with the label) for each button. If I need to add a new button from a plugin (example, archive plugin), I have to modify the plugin to add the label inside my label container (is positioned after all existent labels). The label positions are controlled using clear and float attributes.
-- Emerson Pinter
On Thu, 22 Apr 2010 09:44:43 +0200, Dennis Ortsen dortsen@gmail.com wrote:
Hi everyone,
I guess it's been discussed before, but I can't find any recent (last 6 months) discussions about it: text labels around (besides, below) images/icons in the default skin. We're using 0.3.1-stable BTW.
The only icons that have text labels besides them are in the #taskbar div at the top right of the default skin. Judging from the template for the taskbar, I would guess its pretty easy to add text labels on other icons. For instance around those in the #mailboxcontrols div. Instead of the default:
<roundcube:button command="expunge" type="link" title="compact" class="buttonPas expunge" classAct="button expunge" classSel="button expungesel" content=" " />
I added label="expunge":
<roundcube:button command="expunge" label="expunge" type="link" title="compact" class="buttonPas expunge" classAct="button expunge" classSel="button expungesel" content=" " />
Adding a label tag doesn't have any result, though the same syntax is used in the #tasbar:
<roundcube:button command="mail" label="mail" class="button-mail" />
What am I missing here?
thanks in advance,
Br.
Dennis _______________________________________________ List info: http://lists.roundcube.net/dev/
Esta mensagem pode conter informações confidenciais, privilegiadas ou privadas. Caso não seja o destinatário, favor apagá-la e notificar o remetente. Saiba que o uso impróprio das informações existentes é estritamente proibido, sendo tratado conforme as normas da empresa e a legislação em vigor.
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/CU/C7hGohBF/disclaimer.txt Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
-
Dennis Ortsen -
Emerson Pinter -
emi