Hi! In r3106, I've commited my current work on threading implementation. It's just a beginning. It still needs a lot of work to do, but you can check this out, comment the changes or help with development. Here's a description about current status:
http://trac.roundcube.net/browser/branches/devel-threads/THREADS
cool!, I'll check it out.
On Fri, 13 Nov 2009 15:37:11 +0100, "A.L.E.C" alec@alec.pl wrote:
Hi! In r3106, I've commited my current work on threading implementation.
It's just a beginning. It still needs a lot of work to do, but you can check this out, comment the changes or help with development. Here's a description about current status:
http://trac.roundcube.net/browser/branches/devel-threads/THREADS
-- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
I wanted to test it, but I have a weird bug, don't know if it's a roundcube issue though...
I've setted up r3106 on a fresh mysql database, modified main.inc.php and db.inc.php and imported mysql.initial.sql
Now, when I log in, I see my folders with the count of unread emails on each of them, but I have no emails and the message "no messages found in mailbox".
And in parallel, 3.1 works just fine with the same config parameters, and of course same cyrus-imap server.
Did I miss something or what?
On Fri, 13 Nov 2009 11:20:29 -0500, S c o t t K r a m e r scott_list@clevelanddata.com wrote:
cool!, I'll check it out.
On Fri, 13 Nov 2009 15:37:11 +0100, "A.L.E.C" alec@alec.pl wrote:
Hi! In r3106, I've commited my current work on threading
implementation.
It's just a beginning. It still needs a lot of work to do, but you can check this out, comment the changes or help with development. Here's a description about current status:
http://trac.roundcube.net/browser/branches/devel-threads/THREADS
-- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
Julien Vehent wrote:
I've setted up r3106 on a fresh mysql database, modified main.inc.php and db.inc.php and imported mysql.initial.sql
Just to be sure, do you use devel-thread branch?
Now, when I log in, I see my folders with the count of unread emails on each of them, but I have no emails and the message "no messages found in mailbox".
And in parallel, 3.1 works just fine with the same config parameters, and of course same cyrus-imap server.
Did I miss something or what?
Enalbe imap_debug and compare logs/imap content.
A.L.E.C wrote:
Hi! In r3106, I've commited my current work on threading implementation. It's just a beginning. It still needs a lot of work to do, but you can check this out, comment the changes or help with development. Here's a description about current status:
http://trac.roundcube.net/browser/branches/devel-threads/THREADS
I didn't look at code yet, and wont be able to look at it for a week or may be even more, but would like to comment that document a bit.
yep, agree, missed that
this is really cool, that code was a pain for me
Would you please describe it a bit more?
Hmmm... This seems to make a sense. Although I'd better use two icons instead of one 'universal' - seen/unseen state and all-other replied-forwarded states. OK, thunderbird is a quite good MUA, but not everything from it should be blindly moved to RC I think. Particularly, thunderbirds IMAP threading support is far from being perfect (lack of REFERENCES support, unusability with long discussions, etc.) so I'd think again about re-implementing their approach, although only its visual part.
Would you please describe how you see it all in place? From what I understand, you wanted to remove all expando icons except the first one. Does it still in place? Or you simply want to add 'prefix' icons with a tree-like structure?
Best, Vladislav _______________________________________________ List info: http://lists.roundcube.net/dev/
Vladislav Bogdanov wrote:
- thread expand state is not stored anywhere
Would you please describe it a bit more?
I don't like a reloading the whole list after delete. When we implement partial reloads (on thread level) we'll not need to store expand state of each thread.
- unread_children icon is not shown after changing message status to Seen, when root is e.g. "replied", also when thread contains many unread children. For me, we should use underlined subject instead of unread_children icon
Hmmm... This seems to make a sense. Although I'd better use two icons instead of one 'universal' - seen/unseen state and all-other replied-forwarded states. OK,
maybe we could use some background image for root's status icon, but underlined subject looks good for me.
- thread tree icons
Would you please describe how you see it all in place?
From what I understand, you wanted to remove all expando icons except the first one.
It is done now. We have one expando for each thread.
Does it still in place? Or you simply want to add 'prefix' icons with a tree-like structure?
Yes, here I was writing about tree structure markers (Thunderbird like).
On 11/13/2009 06:29 PM, A.L.E.C wrote:
Julien Vehent wrote:
I've setted up r3106 on a fresh mysql database, modified main.inc.php and db.inc.php and imported mysql.initial.sql
Just to be sure, do you use devel-thread branch?
Well... no... :) I thought you had committed this to trunk
I did checkout devel-threads now, and I can access my mailbox just fine but... no threading.
Config is as follow
$ grep thread main.inc.php|grep rcmail
$rcmail_config['imap_thread_algorithm'] = 'REFERENCES'; $rcmail_config['autoexpand_threads'] = 1;
and following imap capabilities
NO_ATOMIC_RENAME UNSELECT CHILDREN MULTIAPPEND BINARY SORT THREAD=ORDEREDSUBJECT THREAD=REFERENCES ANNOTATEMORE IDLE LOGINDISABLED
Am I missing something again ? :/
Now, when I log in, I see my folders with the count of unread emails on each of them, but I have no emails and the message "no messages found in mailbox".
And in parallel, 3.1 works just fine with the same config parameters, and of course same cyrus-imap server.
Did I miss something or what?
Enalbe imap_debug and compare logs/imap content.
Sorry for the noise, as I suspected, that was just me being stupid with the configuration
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/K6/ezriQSWw/smime.p7s Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Julien Vehent wrote:
$ grep thread main.inc.php|grep rcmail
$rcmail_config['imap_thread_algorithm'] = 'REFERENCES';
There's no such option now.
$rcmail_config['autoexpand_threads'] = 1;
and following imap capabilities
- CAPABILITY IMAP4 IMAP4rev1 ACL QUOTA LITERAL+ NAMESPACE UIDPLUS ID
NO_ATOMIC_RENAME UNSELECT CHILDREN MULTIAPPEND BINARY SORT THREAD=ORDEREDSUBJECT THREAD=REFERENCES ANNOTATEMORE IDLE LOGINDISABLED
Am I missing something again ? :/
Settings -> Folders, there you should have a checkboxes to enable threads for selected folders.
Woa! And we've got threads in trunk! Not complete, but we're working on.
On Wed, Mar 17, 2010 at 1:42 PM, A.L.E.C alec@alec.pl wrote:
Woa! And we've got threads in trunk! Not complete, but we're working on.
Nice! Whatever happened to Gmail-style conversations view? Is it part of this?
Hi,
On 2010-03-17 12:42 UTC A.L.E.C wrote:
Woa! And we've got threads in trunk! Not complete, but we're working on.
I'm using roundcubemail-trunk-r3437-20100329 for a few days now, and I'm very pleased with the Threads implementation. Thanks to everyone who contributed to this! :)
Patrick.
On Fri, 9 Apr 2010 15:39:11 +0800, Patrick Nagel mail@patrick-nagel.net wrote:
Hi,
On 2010-03-17 12:42 UTC A.L.E.C wrote:
Woa! And we've got threads in trunk! Not complete, but we're working
on.
I'm using roundcubemail-trunk-r3437-20100329 for a few days now, and I'm very pleased with the Threads implementation. Thanks to everyone who contributed to this! :)
Patrick.
I must say i'm very pleased with it too. Very nice realization ! It still need to be tested by real humans (ie. not geeks) to see if the interface is user-friendly enough, but I'm not too worried about that.
Out of curiosity: is there any plan to add conversation mode too (gmail style) ?
Best, Julien _______________________________________________ List info: http://lists.roundcube.net/dev/