Hi,
There's an bug in the steps/mail/get.inc that causes downloads of txt
attachments to fail.
Instead of just sending the $part into rcmail_parse_message, the
MESSAGE['structure'] is sent instead, which is an object causing the
explode() to fail in rcmail_parse_message.
Anyway, here's a patch to make viewing and downloading txt
attachments to work.
--- roundcubemail/program/steps/mail/get.inc 2005-11-18
16:32:20.000000000 +0100
+++ /Users/anderska/roundcubemail-cvs-20060205-modified/program/steps/
mail/get.inc 2006-02-14 11:52:15.000000000 +0100
@@ -73,7 +73,7 @@
if ($ctype_primary=='text')
{
list($MESSAGE['parts']) = rcmail_parse_message($MESSAGE
['structure'],
list($MESSAGE['parts']) = rcmail_parse_message($part, array('safe'
=> (bool)$_GET['_safe'],
'prefer_html' => TRUE,
'get_url' => $GET_URL.'&_part=%s'));
Cheers
-- TDC Song anders.x.karlsson@tdcsong.se CDTT (Certified Duct Tape Technician)
"Light travels faster than sound, thats why some people appear bright
before they speak"
Programming today is a race between software engineers striving to build
bigger and better idiot-proof programs, and the Universe trying to
produce
bigger and better idiots. So far, the Universe is winning. - Rich Cook
I also see this as an problem, i get from friend one file to translate as *.pot extension, and contents of file was his mail not the actualy file, i checked mail with squaremail and file is downloaded normaly as needed... Will try this patch for and report.
PS: How to applay dif files in windows :((( (manual i know :P )
Hello Anders, Tuesday, February 14, 2006, 1:48:49 PM, you wrote:
Hi, There's an bug in the steps/mail/get.inc that causes downloads of txt attachments to fail. Instead of just sending the $part into rcmail_parse_message, the
MESSAGE['structure'] is sent instead, which is an object causing the
explode() to fail in rcmail_parse_message. Anyway, here's a patch to make viewing and downloading txt
attachments to work.
--- roundcubemail/program/steps/mail/get.inc 2005-11-18
16:32:20.000000000 +0100 +++ /Users/anderska/roundcubemail-cvs-20060205-modified/program/steps/ mail/get.inc 2006-02-14 11:52:15.000000000 +0100 @@ -73,7 +73,7 @@
if ($ctype_primary=='text') {
list($MESSAGE['parts']) = rcmail_parse_message($MESSAGE['structure'],
list($MESSAGE['parts']) = rcmail_parse_message($part, array('safe'
=>> (bool)$_GET['_safe'],
'prefer_html' =>> TRUE,
'get_url' =>> $GET_URL.'&_part=%s'));
Checkout http://unxutils.sourceforge.net/ for unixutils under Windows; which includes patch.exe
crow wrote:
I also see this as an problem, i get from friend one file to translate as *.pot extension, and contents of file was his mail not the actualy file, i checked mail with squaremail and file is downloaded normaly as needed... Will try this patch for and report.
PS: How to applay dif files in windows :((( (manual i know :P )
Hello Anders, Tuesday, February 14, 2006, 1:48:49 PM, you wrote:
Hi, There's an bug in the steps/mail/get.inc that causes downloads of txt attachments to fail. Instead of just sending the $part into rcmail_parse_message, the
MESSAGE['structure'] is sent instead, which is an object causing the
explode() to fail in rcmail_parse_message. Anyway, here's a patch to make viewing and downloading txt
attachments to work.--- roundcubemail/program/steps/mail/get.inc 2005-11-18
16:32:20.000000000 +0100 +++ /Users/anderska/roundcubemail-cvs-20060205-modified/program/steps/ mail/get.inc 2006-02-14 11:52:15.000000000 +0100 @@ -73,7 +73,7 @@if ($ctype_primary=='text') {
list($MESSAGE['parts']) = rcmail_parse_message($MESSAGE['structure'],
list($MESSAGE['parts']) = rcmail_parse_message($part, array('safe'=>> (bool)$_GET['_safe'],
'prefer_html' =>> TRUE,
'get_url' =>> $GET_URL.'&_part=%s'));
-
Anders Karlsson (X:et) -
crow -
Sjon