Thomas,
Can we not add a download-option to the installer, for main.inc.php and db.inc.php?
Something like attached patch (except that it doesn't really work right now because of output already sent).
Robin
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/rW/sN59DQSJ/_11484984-20080415.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
On Tue, Apr 15, 2008 at 11:42 AM, Robin Elfrink elfrink@introweb.nl wrote:
Good idea, make it a separate file to call (download-files.php in installer) and make sure that you only let it download $_GET['file'] when it's escaped etc.. So people don't end up downloading the real configs etc.. ;-) "../inc/db.inc.php".
Till _______________________________________________ List info: http://lists.roundcube.net/dev/
Robin Elfrink wrote:
Actually a good idea. The config is built out of the POST vars from the installer form. We need to temporarily save this data in order to correctly build the config files when downloading them.
This needs some more code but your patch is good to start with.
~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/
Thomas Bruederli wrote:
How's this (attached)? Works for me.
Robin
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/EC/N3SrT7Yd/_1484984.20080417094.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Hi Robin
Sorry for not answering your mail. I think storing the config in the session is the easiest way. Go ahead and commit your path to the trunk.
~Thomas
On Thu, Apr 17, 2008 at 09:49, Robin Elfrink elfrink@introweb.nl wrote:
List info: http://lists.roundcube.net/dev/
Thomas Bruederli wrote:
Already did in r1511 :)
Robin _______________________________________________ List info: http://lists.roundcube.net/dev/
-
Robin Elfrink -
Thomas Bruederli -
till