People have been complaining about corrupt files here also-- running 0.5.2

On Tue, 03 May 2011 12:49:23 -0400, Julien Vehent wrote:

No change on the users list, maybe the Dev list can help me here ?

Or should I fill a ticket directly ?

Thanks, Julien

---

Original Message --------

Subject: [RCU] Corrupted attached PDF

files

Date: Mon, 02 May 2011 10:14:56 -0400 From: Julien Vehent

To: Users

Hi list,

I have a 0.5.2 running in a small company

and users have been

complaining that attached PDF files don't open

properly.

I tried to open one of those emails with thunderbird, the

PDFs display

properly. But with roundcube, I get a blank page.

I

saved both PDFs (from tbird and roundcube) and it appears that the

one from Roundcube is slightly bigger (by 118 bytes):

$ ls -al

-rw-r--r-- 1 jvehent jvehent 11392 May 2 2011 MicroGate chges avril

2011 -rcube.pdf

-rw------- 1 jvehent jvehent 11274 May 2 09:52

MicroGate chges avril

2011 -tbrid.pdf

$ md5sum *

bfb27d3a439fd4d38a2b6d9bcd827582 MicroGate chges avril 2011.pdf

2fd9859443dfa3696b6e86de9fc0b2d2 MicroGate chges avril 2011 -tbrid.pdf

I opened both documents in Vim, and noticed that the one coming from

Roundcube contains trailing "^M" that don't exist in the PDF coming

from

Thunderbird (see attached screenshot, the document from

roundcube is on

the right).

I observed this behavior in 0.5.1

and upgraded to 0.5.2 without any

change. I tried deactivated ALL the

plugins on my instalation, without

any change. So before feeling a

bug ticket, I'd like to confirm there is

not already a solution for

this.

Thanks, Julien

--- 8< --- detachments --- 8< --- The

following attachments have been detached and are available for

viewing.

http://detached.gigo.com/rc/Gq/QXVz95UJ/roundcube_pdf_bugs.png [3]

Only click these links if you trust the sender, as well as this

message.

--- 8< --- detachments --- 8< ---

List info:

http://lists.roundcube.net/dev/ [4]

BT/82b627a0

Links:

[1] mailto:julien@linuxwall.info [2] mailto:users@lists.roundcube.net [3] http://detached.gigo.com/rc/Gq/QXVz95UJ/roundcube_pdf_bugs.png [4] http://lists.roundcube.net/dev/

List info: http://lists.roundcube.net/dev/ BT/aba52c80

On Tue, 3 May 2011 22:29:11 +0200, Jernej Porenta wrote:

On May 3, 2011, at 9:58 PM, S c o t t K r a m e r wrote:

...

People have been complaining about corrupt files here also-- running 0.5.2

We had similar issues, when we were using plugins that had empty (last) lines in config files, so disable your plugins and try again. Some attachments were working properly because they are immune to empty lines at the end of the files, others dont...

regards, Jernej

I thought about that, and as I said:

I tried deactivated ALL the plugins on my instalation, without any change.

If you have idea on how to track this down, I'm up for it

Thanks, Julien _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

On 05/04/2011 08:22 AM, Mikkel Skovgaard Sørensen wrote:

Have you guy tried checking the index.php file - there is no closing php tag (?>)

In general this seems to be done in many of the php files - in my oppion these should be closed and there should be no newline etc. after the last char.

the closing tag is not required by php. omitting the closing tag exactly prevents issue with trailing characters and is therefore is current practice.

please see http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html

quote:

For files that contain only PHP code, the closing tag ("?>") is never permitted. It is not required by PHP, and omitting it´ prevents the accidental injection of trailing white space into the response.

cheers, raoul