Hi! I've made a patch which adds vertical splitter + some small fixes.
It needs some work for IE and probably for Safari, but it works fine with:
- Firefox3.0 (focus issue fixed via CSS: -moz-user-select: none),
- Opera9.5 (ad. fixed iframe drag issue: added drag_active flag),
- Konqueror3.5.
Splitter dots are better centered now and #mainscreen division is required, but it's not a problem, I think.
Some things may be done in better way, but it's working. Feel free to send corrections ;)
Hi,
A.L.E.C wrote:
Hi! I've made a patch which adds vertical splitter + some small fixes.
It needs some work for IE and probably for Safari, but it works fine with:
- Firefox3.0 (focus issue fixed via CSS: -moz-user-select: none),
- Opera9.5 (ad. fixed iframe drag issue: added drag_active flag),
- Konqueror3.5.
Splitter dots are better centered now and #mainscreen division is required, but it's not a problem, I think.
Some things may be done in better way, but it's working. Feel free to send corrections ;)
I'm just testing it (on Firefox 2.0.0.16), and so far it looks really good :) Thanks!
Patrick.
Patch improved. Now it works with IE6/IE7. Also included bonuses:
- debug console fixes for IE
- added show-all-headers-in-message-view feature (!)
Enjoy. Safari users, test (taste) it, please ;)
Regards
Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/BZ/uQtEzSco/vert_splitter_all_he.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
are there any screenshots to see what you're actually doing there? :)
cheers, raoul
A.L.E.C wrote:
Patch improved. Now it works with IE6/IE7. Also included bonuses:
- debug console fixes for IE
- added show-all-headers-in-message-view feature (!)
Enjoy. Safari users, test (taste) it, please ;)
Regards
List info: http://lists.roundcube.net/dev/
A.L.E.C wrote:
Enjoy. Safari users, test (taste) it, please ;)
Works fine on XP and OSX.
Robin _______________________________________________ List info: http://lists.roundcube.net/dev/
A.L.E.C wrote:
- added show-all-headers-in-message-view feature (!)
I like that one too, saves me a lot of extra clicking :)
Good work!
Robin _______________________________________________ List info: http://lists.roundcube.net/dev/
Raoul Bhatia [IPAX] wrote:
are there any screenshots to see what you're actually doing there? :)
http://alec.pl/roundcube/screen4.png http://alec.pl/roundcube/screen3.png
On Fri, Sep 12, 2008 at 11:45, A.L.E.C alec@alec.pl wrote:
Patch improved. Now it works with IE6/IE7. Also included bonuses:
- debug console fixes for IE
- added show-all-headers-in-message-view feature (!)
I didn't test it so far but the screen shots look nice! When updating the client code to work with jQuery we should have a look into http://methvin.com/jquery/splitter/
But for now you should commit your changes. Also the header display function is nice!
~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/
Thomas Bruederli wrote:
I didn't test it so far but the screen shots look nice! When updating the client code to work with jQuery we should have a look into http://methvin.com/jquery/splitter/
But for now you should commit your changes. Also the header display function is nice!
commited to trunk.
So RC is moving to jquery? Thats good news :)
Cor _______________________________________________ List info: http://lists.roundcube.net/dev/
Cor Bosman wrote:
So RC is moving to jquery? Thats good news :)
Yes, as stated in http://trac.roundcube.net/roadmap
~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/
It needs some work for IE and probably for Safari, but it works fine with:
- Firefox3.0 (focus issue fixed via CSS: -moz-user-select: none),
- Opera9.5 (ad. fixed iframe drag issue: added drag_active flag),
- Konqueror3.5.
Hi Alec, I tried the following:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.2) Gecko/2008090512 Firefox/3.0.2
Works ok.
Safari Version 3.1.2 (5525.20.1)
Works ok, i get a bit of flickering while moving the vertical bar. happens with the horizontal bar as well. But it doesnt disturb the actual moving.
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1 (Vista 64)
Works ok.
IE7 7.0.6001.18000 OK (Vista 64)
Works ok.
Chrome. Same as Safari, some flickering while moving. (Vista 64)
Works ok.
IE8 Beta 2 (XP)
Works ok.
IE6 6.0.2900.2180 (XP)
Works ok.
There is some inconsistency between the different browsers in how the index pane is shrinking. In FF3 on OSX for instance the Subject field (left most column) shrinks down to 0 before the rest becomes smaller. On Safari for instance the left most column stays the same size, and the rest becomes smaller.
It's probably not good to shrink the subject field all the way to 0 before shrinking the rest. Maybe some minimal size should be applied? Of course, this only happens on wwwiiddeee monitors :)
Cor _______________________________________________ List info: http://lists.roundcube.net/dev/
On Fri, 12 Sep 2008 14:29:26 +0200, "A.L.E.C" alec@alec.pl wrote:
Thomas Bruederli wrote:
I didn't test it so far but the screen shots look nice! When updating the client code to work with jQuery we should have a look into http://methvin.com/jquery/splitter/
But for now you should commit your changes. Also the header display function is nice!
commited to trunk.
Alec,
I have noticed that when bringing up a message display (i.e. after double-clicking on a message in the message list), the window is initially rendered (albeit momentarily) without the folder list. The folder list is then added, causing the message display frame to shrink towards the right. I believe this "flicker" is new as of the addition of the vertical splitter (or at least it's more distracting).
This doesn't seem to happen when switching back to the "message list" page.
Could there be something different between the vertical splitter definition on those two pages that's causing the "jumping?"
(This is with Firefox 3 on Fedora 8).
On Fri, Sep 12, 2008 at 1:18 PM, Thomas Bruederli roundcube@gmail.com wrote:
On Fri, Sep 12, 2008 at 11:45, A.L.E.C alec@alec.pl wrote:
Patch improved. Now it works with IE6/IE7. Also included bonuses:
- debug console fixes for IE
- added show-all-headers-in-message-view feature (!)
I didn't test it so far but the screen shots look nice! When updating the client code to work with jQuery we should have a look into http://methvin.com/jquery/splitter/
But for now you should commit your changes. Also the header display function is nice!
Looks pretty awesome, Alec. Great job!
Till _______________________________________________ List info: http://lists.roundcube.net/dev/
On Fri, 12 Sep 2008 09:35:46 -0600, Eric Stadtherr estadtherr@gmail.com wrote:
I have noticed that when bringing up a message display (i.e. after double-clicking on a message in the message list), the window is
initially
rendered (albeit momentarily) without the folder list. The folder list is then added, causing the message display frame to shrink towards the
right.
I believe this "flicker" is new as of the addition of the vertical
splitter
(or at least it's more distracting).
This doesn't seem to happen when switching back to the "message list"
page.
Check r1777.
much better!
On Fri, 12 Sep 2008 19:01:54 +0200, A.L.E.C alec@alec.pl wrote:
On Fri, 12 Sep 2008 09:35:46 -0600, Eric Stadtherr estadtherr@gmail.com wrote:
I have noticed that when bringing up a message display (i.e. after double-clicking on a message in the message list), the window is
initially
rendered (albeit momentarily) without the folder list. The folder list
is
then added, causing the message display frame to shrink towards the
right.
I believe this "flicker" is new as of the addition of the vertical
splitter
(or at least it's more distracting).
This doesn't seem to happen when switching back to the "message list"
page.
Check r1777.
-
A.L.E.C -
Cor Bosman -
Eric Stadtherr -
Patrick Nagel -
Raoul Bhatia [IPAX] -
Robin Elfrink -
Thomas Bruederli -
till