Hi List,
here is the initial release (or peer review release) of a plugin for message highlighting. It has been quickly packaged as a tarball and patch against the current trunk (r2456). This is not intended for production use.
We would be interested to hear what other devs have to say about this. We would like it to be less invasive into the internals of RC, however we did not find out how to get this functionality all inside the plugin.
There are ways in which RC seems not to be very coherent in its-self. For example the message list building data seems to be different between the JavaScript and HTML output. It seems to take two different paths through the code. Is this correct or have we overlooked something fundamental? If this is correct, is it by design and if so why?!?
We believe that the use of jQuery could be greatly improved. We do a _lot_ of jQuery development and, to us, lots of what has been implemented could do with being restructured and reworked.
We are also working on a Advanced Global Search plugin that we have working in-house but is not yet simple to package. That plugin is even more invasive into the RC internals than this one.
Looking forward your feedback.
Chris Moules
-- Global Media Systems
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/qM/hKQ6SQEv/message_highlighting.tgz Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Here is a minor update. It should fix the following:
- Labels are translated properly.
- Button label fix.
- Colour Picker translated.
Regards
Chris
Chris Moules wrote:
Hi List,
here is the initial release (or peer review release) of a plugin for message highlighting. It has been quickly packaged as a tarball and patch against the current trunk (r2456). This is not intended for production use.
We would be interested to hear what other devs have to say about this. We would like it to be less invasive into the internals of RC, however we did not find out how to get this functionality all inside the plugin.
There are ways in which RC seems not to be very coherent in its-self. For example the message list building data seems to be different between the JavaScript and HTML output. It seems to take two different paths through the code. Is this correct or have we overlooked something fundamental? If this is correct, is it by design and if so why?!?
We believe that the use of jQuery could be greatly improved. We do a _lot_ of jQuery development and, to us, lots of what has been implemented could do with being restructured and reworked.
We are also working on a Advanced Global Search plugin that we have working in-house but is not yet simple to package. That plugin is even more invasive into the RC internals than this one.
Looking forward your feedback.
Chris Moules
-- Global Media Systems
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/qM/hKQ6SQEv/message_highlighting.tgz Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/rn/QBDmHKBR/message_highlighting.tgz Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Chris Moules wrote:
There are ways in which RC seems not to be very coherent in its-self. For example the message list building data seems to be different between the JavaScript and HTML output. It seems to take two different paths through the code. Is this correct or have we overlooked something fundamental? If this is correct, is it by design and if so why?!?
One is for page reload and one for ajax. We could use ajax method after page load, but it will produce not wanted delay and one extra http request/imap connection, so I think it's ok. After both methods calls there's rcmail.init_message_row called for each row, maybe we should create 'init_row' hook? It could be usefull for you.
We believe that the use of jQuery could be greatly improved. We do a _lot_ of jQuery development and, to us, lots of what has been implemented could do with being restructured and reworked.
Feel free to create patches.
We are also working on a Advanced Global Search plugin that we have working in-house but is not yet simple to package. That plugin is even more invasive into the RC internals than this one.
Not everything must be a plugin.
On Tue, 12 May 2009 09:36:36 +0200, Chris Moules christopher@gms.lu wrote:
Here is a minor update. It should fix the following:
- Labels are translated properly.
- Button label fix.
- Colour Picker translated.
Regards
Chris
Chris Moules wrote:
Hi List,
here is the initial release (or peer review release) of a plugin for message highlighting. It has been quickly packaged as a tarball and patch against the current trunk (r2456). This is not intended for production use.
We would be interested to hear what other devs have to say about this. We would like it to be less invasive into the internals of RC, however we did not find out how to get this functionality all inside the
plugin.
There are ways in which RC seems not to be very coherent in its-self. For example the message list building data seems to be different
between
the JavaScript and HTML output. It seems to take two different paths through the code. Is this correct or have we overlooked something fundamental? If this is correct, is it by design and if so why?!?
We believe that the use of jQuery could be greatly improved. We do a _lot_ of jQuery development and, to us, lots of what has been implemented could do with being restructured and reworked.
We are also working on a Advanced Global Search plugin that we have working in-house but is not yet simple to package. That plugin is even more invasive into the RC internals than this one.
Looking forward your feedback.
Chris Moules
-- Global Media Systems
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/qM/hKQ6SQEv/message_highlighting.tgz Only click these links if you trust the sender, as well as this
message.
--- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/rn/QBDmHKBR/message_highlighting.tgz Only click these links if you trust the sender, as well as this
message.
--- 8< --- detachments --- 8< ---
This functionality sounds like a good candidate for inclusion in RoundCube core, not a plugin. Most e-mail clients implement message highlighting in some way, so it seems like a good general capability.
What do the other developers think?
-
A.L.E.C -
Chris Moules -
Eric Stadtherr