Re: [RCD] [Svn] [roundcube/roundcubemail] 9a0153: Implemented menu actions to copy/move messages, added folder-selector widget (#1484086)
Thanks for the copy-message feature!
So we disabled the 'copymessage' plugin, updated the 'contextmenu' plugin to v1.12 (since our previous version wasn't compatible with 1.0-git anymore anyway), all is looking good and working well, except:
The (still not translated) "Copy to..." menu item is not shown in 'contextmenu' (i.e. when you right-click on a message).
Is this an RC or a 'contextmenu' issue?
BTW: What is a "folder-selector widget" and what's its purpose?
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 15.12.2013 10:02, schrieb GitHub:
Branch: refs/heads/master Home: https://github.com/roundcube/roundcubemail Commit: 9a0153324eeb1f0e808cb1a063d1f37d49ad48e2
https://github.com/roundcube/roundcubemail/commit/9a0153324eeb1f0e808cb1a063... Author: Aleksander Machniak alec@alec.pl Date: 2013-12-15 (Sun, 15 Dec 2013)
Changed paths: M CHANGELOG M program/include/rcmail.php M program/js/app.js M program/localization/en_US/labels.inc M skins/classic/common.css M skins/classic/functions.js M skins/classic/includes/messagetoolbar.html M skins/classic/mail.css M skins/classic/templates/message.html M skins/larry/images/listicons.png M skins/larry/includes/mailtoolbar.html M skins/larry/mail.css M skins/larry/styles.css M skins/larry/templates/message.html M skins/larry/ui.js
Log Message:
Implemented menu actions to copy/move messages, added folder-selector widget (#1484086)
Commit: acfbe5ff4c71bf6cd9d5fda27eb93406f140b23f
https://github.com/roundcube/roundcubemail/commit/acfbe5ff4c71bf6cd9d5fda27e... Author: Aleksander Machniak alec@alec.pl Date: 2013-12-15 (Sun, 15 Dec 2013)
Changed paths: M .htaccess M CHANGELOG
Log Message:
Merge branch 'master' of github.com:roundcube/roundcubemail
Conflicts: CHANGELOG
Compare: https://github.com/roundcube/roundcubemail/compare/2dade15d83b9...acfbe5ff4c...
Roundcube SVN commits mailing list svn@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/svn
On 12/22/2013 09:52 PM, Michael Heydekamp wrote:
So we disabled the 'copymessage' plugin, updated the 'contextmenu' plugin to v1.12 (since our previous version wasn't compatible with 1.0-git anymore anyway), all is looking good and working well, except:
The (still not translated) "Copy to..." menu item is not shown in 'contextmenu' (i.e. when you right-click on a message).
I don't use contextmenu.
Is this an RC or a 'contextmenu' issue?
plugin issue.
BTW: What is a "folder-selector widget" and what's its purpose?
It is the list of folders displayed when you use More actions > Copy/Move to... It can be used by e.g. contextmenu plugin. So, it is now simpler to implement any action that requires folder selection.
Am 23.12.2013 08:06, schrieb A.L.E.C:
On 12/22/2013 09:52 PM, Michael Heydekamp wrote:
BTW: What is a "folder-selector widget" and what's its purpose?
It is the list of folders displayed when you use More actions > Copy/Move to... It can be used by e.g. contextmenu plugin. So, it is now simpler to implement any action that requires folder selection.
Understood.
@Phil: Would it be feasible that contextmenu will use this widget in the near future? It's way better and faster accessible than the folder list contextmenu is currently offering (and would also make the code of contextmenu smaller, I believe).
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Personally I have never understood the need for a copy message function
in
Roundcube though I understand other people find it useful. This combined with the fact that I wanted to demonstrate how to extend the
contextmenu
plugin is why it is separate.
But it applies to this particular function only? What if more functions together with menu items (and not only menu items for already existing but "hidden" functions) should be added to Roundcube in the future - would they appear in contextmenu automatically then?
Nothing is "automatic" the contextmenu only contains functions which have been added to it, nothing to do with the contents of the mail toolbar
@Phil: Would it be feasible that contextmenu will use this widget in the near future? It's way better and faster accessible than the folder list contextmenu is currently offering (and would also make the code of contextmenu smaller, I believe).
I do not think in the near future no. A quick look suggested that it is not as simple is swapping one function for another. There is already a ticket about it in the github repo of the plugin.
The (still not translated) "Copy to..." menu item is not shown in 'contextmenu' (i.e. when you right-click on a message).
The text comes from the core. It's only just been added so I guess it will take a little while to get translated.
You need the copymessage plugin to add the option to the context menu. The copy message function has been built it in Roundcube for some time. Copymessage uses the built in functions, its purpose is really just to add the element to the context menu. The recent change in Roundcube is only a cosmetic one, not functional.
Personally I have never understood the need for a copy message function in Roundcube though I understand other people find it useful. This combined with the fact that I wanted to demonstrate how to extend the contextmenu plugin is why it is separate.
Phil
-----Original Message----- From: dev-bounces@lists.roundcube.net [mailto:dev- bounces@lists.roundcube.net] On Behalf Of Michael Heydekamp Sent: 22 December 2013 20:53 To: Roundcube Development discussion mailing list Subject: Re: [RCD] [Svn] [roundcube/roundcubemail] 9a0153: Implemented menu actions to copy/move messages, added folder-selector widget (#1484086)
Thanks for the copy-message feature!
So we disabled the 'copymessage' plugin, updated the 'contextmenu' plugin to v1.12 (since our previous version wasn't compatible with 1.0-git anymore anyway), all is looking good and working well, except:
The (still not translated) "Copy to..." menu item is not shown in 'contextmenu' (i.e. when you right-click on a message).
Is this an RC or a 'contextmenu' issue?
BTW: What is a "folder-selector widget" and what's its purpose?
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 15.12.2013 10:02, schrieb GitHub:
Branch: refs/heads/master Home: https://github.com/roundcube/roundcubemail Commit: 9a0153324eeb1f0e808cb1a063d1f37d49ad48e2
https://github.com/roundcube/roundcubemail/commit/9a0153324eeb1f0e8 08cb1a063d1f37d49ad48e2
Author: Aleksander Machniak alec@alec.pl Date: 2013-12-15 (Sun, 15 Dec 2013)
Changed paths: M CHANGELOG M program/include/rcmail.php M program/js/app.js M program/localization/en_US/labels.inc M skins/classic/common.css M skins/classic/functions.js M skins/classic/includes/messagetoolbar.html M skins/classic/mail.css M skins/classic/templates/message.html M skins/larry/images/listicons.png M skins/larry/includes/mailtoolbar.html M skins/larry/mail.css M skins/larry/styles.css M skins/larry/templates/message.html M skins/larry/ui.js
Log Message:
Implemented menu actions to copy/move messages, added folder-
selector widget (#1484086)
Commit: acfbe5ff4c71bf6cd9d5fda27eb93406f140b23f
https://github.com/roundcube/roundcubemail/commit/acfbe5ff4c71bf6cd9 d5fda27eb93406f140b23f
Author: Aleksander Machniak alec@alec.pl Date: 2013-12-15 (Sun, 15 Dec 2013)
Changed paths: M .htaccess M CHANGELOG
Log Message:
Merge branch 'master' of github.com:roundcube/roundcubemail
Conflicts: CHANGELOG
Compare:
https://github.com/roundcube/roundcubemail/compare/2dade15d83b9...ac fbe5ff4c71
Roundcube SVN commits mailing list svn@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/svn
Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
Am 23.12.2013 10:16, schrieb Phil Weir:
You need the copymessage plugin to add the option to the context menu. The copy message function has been built it in Roundcube for some time. Copymessage uses the built in functions, its purpose is really just to add the element to the context menu. The recent change in Roundcube is only a cosmetic one, not functional.
Ah, that I wasn't aware of. Thanks for the insight.
Personally I have never understood the need for a copy message function in Roundcube though I understand other people find it useful. This combined with the fact that I wanted to demonstrate how to extend the contextmenu plugin is why it is separate.
But it applies to this particular function only? What if more functions together with menu items (and not only menu items for already existing but "hidden" functions) should be added to Roundcube in the future - would they appear in contextmenu automatically then?
One of the needs for copying messages BTW is if you are using an own Bayesian database for spam detection. In the past, we used to copy messages which were false positives to a specific ham folder. A cronjob did then make sure to add all messages in this folder as ham to the database.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 23.12.2013 21:34, schrieb Michael Heydekamp:
Am 23.12.2013 10:16, schrieb Phil Weir:
You need the copymessage plugin to add the option to the context menu. The copy message function has been built it in Roundcube for some time. Copymessage uses the built in functions, its purpose is really just to add the element to the context menu. The recent change in Roundcube is only a cosmetic one, not functional.
Ah, that I wasn't aware of. Thanks for the insight
sadly there is no way over IMAP to move/copy messages directly on the server otherwise our dbmail-setup could benefit a lot because it only had to update a database ID internally instead copy a new message, delete the old one and purge the old one with the cleanup-job phyiscally from the databse
-
A.L.E.C -
Michael Heydekamp -
Phil Weir -
Reindl Harald