That column is used only for log in. The current behaviour allows only one alias. Also not every installation is using it at all. What I propose is to:[[BR]]
- remove this column.
- add an option which will search for the username in identities table.
SELECT u.* FROM users.u JOIN identities i ON (i.user_id = u.user_id) WHERE email = ? LIMIT 1
So, this way searching for alias would be optional (which will improve performance, when not needed, e.g. there's a plugin which do alias mapping) and will give more possibilities.
What I'm afraid of is that there's a use-case where alias is not an email address.
http://trac.roundcube.net/ticket/1488581
On Tue, Jul 31, 2012 at 12:39 PM, A.L.E.C alec@alec.pl wrote:
That column is used only for log in. The current behaviour allows only one alias. Also not every installation is using it at all. What I propose is to:[[BR]]
- remove this column.
- add an option which will search for the username in identities table.
SELECT u.* FROM users.u JOIN identities i ON (i.user_id = u.user_id) WHERE email = ? LIMIT 1
So, this way searching for alias would be optional (which will improve performance, when not needed, e.g. there's a plugin which do alias mapping) and will give more possibilities.
What I'm afraid of is that there's a use-case where alias is not an email address.
You're exactly right. Our Roundcube installation (with several hundred users) is using a setup with Confixx. The e-mail accounts created by Confixx can only be accessed by a username (not e-mail address). To allow our users to log in using username AND e-mail address, I am using a plugin (authenticate_by_confixx). But if a user wants to use his real username as login, this would fail if the username is not in the alias column anymore. Please correct me if I'm wrong.
http://trac.roundcube.net/ticket/1488581
-- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net]
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
On Tue, Jul 31, 2012 at 2:40 PM, Claudio Kuenzler ck@claudiokuenzler.comwrote:
On Tue, Jul 31, 2012 at 12:39 PM, A.L.E.C alec@alec.pl wrote:
That column is used only for log in. The current behaviour allows only one alias. Also not every installation is using it at all. What I propose is to:[[BR]]
- remove this column.
- add an option which will search for the username in identities table.
SELECT u.* FROM users.u JOIN identities i ON (i.user_id = u.user_id) WHERE email = ? LIMIT 1
So, this way searching for alias would be optional (which will improve performance, when not needed, e.g. there's a plugin which do alias mapping) and will give more possibilities.
What I'm afraid of is that there's a use-case where alias is not an email address.
You're exactly right. Our Roundcube installation (with several hundred users) is using a setup with Confixx. The e-mail accounts created by Confixx can only be accessed by a username (not e-mail address). To allow our users to log in using username AND e-mail address, I am using a plugin (authenticate_by_confixx). But if a user wants to use his real username as login, this would fail if the username is not in the alias column anymore. Please correct me if I'm wrong.
I correct myself. I mixed up username and alias columns. The alias is of course an e-mail address while the username is the real username. So no worries from our side.
http://trac.roundcube.net/ticket/1488581
-- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net]
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
On Tue, Jul 31, 2012 at 12:39 PM, A.L.E.C alec@alec.pl wrote:
That column is used only for log in. The current behaviour allows only one alias. Also not every installation is using it at all. What I propose is to:[[BR]]
- remove this column.
- add an option which will search for the username in identities table.
SELECT u.* FROM users.u JOIN identities i ON (i.user_id = u.user_id) WHERE email = ? LIMIT 1
So, this way searching for alias would be optional (which will improve performance, when not needed, e.g. there's a plugin which do alias mapping) and will give more possibilities.
Yep, that column was indeed never really used. To make the average case work, one could always update the alias column with the email address of the default identity once that is updated. But I guess after introducing the plugin API we can easily drop that column from the schema and let plugins solve specific requirements.
The option to search in identities as a fall back does sound. Please just add AND del <> 1 to the SQL query then.
What I'm afraid of is that there's a use-case where alias is not an email address.
-> use plugins for that.
~Thomas
-
A.L.E.C -
Claudio Kuenzler -
Thomas Bruederli