Hi !
I made a small patch that will quote names that contains special chars (as defined in RFC822) in auto-completion (fix bug #1483999, http://trac.roundcube.net/ticket/1483999 )
Also, should we check (using Javascript) if destination fields ("To:", "Cc:", "Bcc:") are RFC822 compliant before sending mail ? I mean throwing an error with bad formatted field (Buggy: name buggy@example.org isn't valid, but "Buggy: name" buggy@example.org is).
Thank you !
-- Benjamin Vanheuverzwin iWeb Technologies http://www.iweb.com
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/a5/ZCLqW2dU/bugfix1483999.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Benjamin Vanheuverzwijn wrote:
Also, should we check (using Javascript) if destination fields ("To:", "Cc:", "Bcc:") are RFC822 compliant before sending mail ? I mean throwing an error with bad formatted field (Buggy: name buggy@example.org isn't valid, but "Buggy: name" buggy@example.org is).
Good idea. You're welcome to extend the according javascript function to check this complex syntax. Or even better, try to escape it first (as done in your patch) and then throw an error if there's still something wrong.
Regards, Thomas
List info: http://lists.roundcube.net/dev/
Thomas Bruederli wrote:
Benjamin Vanheuverzwijn wrote:
Also, should we check (using Javascript) if destination fields ("To:", "Cc:", "Bcc:") are RFC822 compliant before sending mail ? I mean throwing an error with bad formatted field (Buggy: name buggy@example.org isn't valid, but "Buggy: name" buggy@example.org is).
Good idea. You're welcome to extend the according javascript function to check this complex syntax. Or even better, try to escape it first (as done in your patch) and then throw an error if there's still something wrong.
it should be done according to rfc1522, look at http://trac.roundcube.net/ticket/1484884 and http://www.squirrelmail.org/docs/phpdoc/squirrelmail/_functions---mime.php.h...
...but, of course, Benjamin's patch is a move in right way.
Regards
Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.alec.pl _______________________________________________ List info: http://lists.roundcube.net/dev/
-
A.L.E.C -
Benjamin Vanheuverzwijn -
Thomas Bruederli