With debug_level = 4, I was getting the following warning output when I clicked on a folder:
Warning: mktime() expects parameter 5 to be long, string given in
/usr/local/src/roundcube-cvs/roundcubemail/program/lib/imap.inc
on line 625
The message index would not display sometimes; for example, 1. click on trash 2. drag message (unread) to inbox 3. click on inbox (yup, msg there) 4. click on trash (no message index displayed)
Very strange, as when I viewed the source the table that display the message index was there.
When I fixed the warning by casting to an int, the behavior was fixed.
# diff -u program/lib/imap.inc.orig program/lib/imap.inc --- program/lib/imap.inc.orig Wed Apr 26 17:01:40 2006 +++ program/lib/imap.inc Wed Apr 26 17:03:01 2006 @@ -611,7 +611,7 @@ //$month_a=array("Jan"=>1,"Feb"=>2,"Mar"=>3,"Apr"=>4,"May"=>5,"Jun"=>6,"Jul"=>7,"Aug"=>8,"Sep"=>9,"Oct"=>10,"Nov"=>11,"Dec"=>12); $month_str=$a[1]; $month=$IMAP_MONTHS[$month_str];
$day=$a[0];
$day=(int)$a[0]; $year=$a[2]; $time=$a[3]; $tz_str = $a[4];
#
I'll stick this (and my README patch) in sf.net as a patch so it doesn't get lost in the mailing list.
Thanks Mark!
I just applied your patches and committed the files to the CVS.
Regards, Thomas
Mark Bucciarelli wrote:
With debug_level = 4, I was getting the following warning output when I clicked on a folder:
Warning: mktime() expects parameter 5 to be long, string given in /usr/local/src/roundcube-cvs/roundcubemail/program/lib/imap.inc on line 625The message index would not display sometimes; for example, 1. click on trash 2. drag message (unread) to inbox 3. click on inbox (yup, msg there) 4. click on trash (no message index displayed)
Very strange, as when I viewed the source the table that display the message index was there.
When I fixed the warning by casting to an int, the behavior was fixed.
# diff -u program/lib/imap.inc.orig program/lib/imap.inc --- program/lib/imap.inc.orig Wed Apr 26 17:01:40 2006 +++ program/lib/imap.inc Wed Apr 26 17:03:01 2006 @@ -611,7 +611,7 @@ //$month_a=array("Jan"=>1,"Feb"=>2,"Mar"=>3,"Apr"=>4,"May"=>5,"Jun"=>6,"Jul"=>7,"Aug"=>8,"Sep"=>9,"Oct"=>10,"Nov"=>11,"Dec"=>12); $month_str=$a[1]; $month=$IMAP_MONTHS[$month_str];
$day=$a[0];
$day=(int)$a[0]; $year=$a[2]; $time=$a[3]; $tz_str = $a[4];#
I'll stick this (and my README patch) in sf.net as a patch so it doesn't get lost in the mailing list.
I occasionaly get a similar error, but it is usually paramter 2 or 3 for mktime() (and for me it happens on any folder with the invalid message). i find it is due to spammers not abiding by the date formatting of the RFC.
should we not type cast all of those parameters? or
if the mktime() call fails, catch the error and use the date written in the email?
it is a real pain when then message list doesn't show up and i have to go on to my box to fix one little message (especially since it's almost always spam and i'm just going to delete it anyways)
any thoughts?
Jared
/goes back to lurking
On Mon, 01 May 2006 16:14:03 +0200, Thomas Bruederli roundcube@gmail.com wrote:
Thanks Mark!
I just applied your patches and committed the files to the CVS.
Regards,
Thomas
Mark Bucciarelli wrote:
With debug_level = 4, I was getting the following warning output
when I clicked on a folder:
Warning: mktime() expects parameter 5 to be long, string given in
/usr/local/src/roundcube-cvs/roundcubemail/program/lib/imap.inc
on line 625
The message index would not display sometimes; for example,
1. click on trash
2. drag message (unread) to inbox
3. click on inbox (yup, msg there)
4. click on trash (no message index displayed)
Very strange, as when I viewed the source the table that display the
message index was there.
When I fixed the warning by casting to an int, the behavior was fixed.
# diff -u program/lib/imap.inc.orig
program/lib/imap.inc
--- program/lib/imap.inc.orig Wed Apr 26 17:01:40 2006
+++ program/lib/imap.inc Wed Apr 26 17:03:01 2006
@@ -611,7 +611,7 @@
//$month_a=array("Jan"=>1,"Feb"=>2,"Mar"=>3,"Apr"=>4,"May"=>5,"Jun"=>6,"Jul"=>7,"Aug"=>8,"Sep"=>9,"Oct"=>10,"Nov"=>11,"Dec"=>12);
$month_str=$a[1];
$month=$IMAP_MONTHS[$month_str];
$day=$a[0];
$day=(int)$a[0];
$year=$a[2];
$time=$a[3];
$tz_str = $a[4];
#
I'll stick this (and my README patch) in sf.net as a patch so it doesn't
get lost in the mailing list.
On Mon, May 01, 2006 at 12:22:15PM -0400, Jared McKnight wrote:
I occasionaly get a similar error, but it is usually paramter 2 or 3 for mktime() (and for me it happens on any folder with the invalid message). i find it is due to spammers not abiding by the date formatting of the RFC.
I had been meaning to go back and figure out why that param was not an int. It obviously is in some (most?) cases.
should we not type cast all of those parameters? or
if the mktime() call fails, catch the error and use the date written
in the email?
In retrospect, I would catch the error and branch. I really should have figured out the cause and addressed that instead of the symptom.
I'll make a second try, probably next week.
m
-
Jared McKnight -
Mark Bucciarelli -
Thomas Bruederli