Hi,
For various reasons (mostly having to do with not wanting to ask one user in particular to "try out larry"...) I renamed the larry theme on my installation to "default". This worked fine in 0.8.0, but breaks pretty hard in 0.8.1 -- any users using "default" get a "service not available! errno 501" error page when trying to log in.
The error wasn't showing up in any of RC's various logs, even with all the knobs turned up. A quick grep found rcube_template to be the most likely cause; on a whim I decided to grep the installation for "larry" and found a half-dozen or so references there. Changing them all to "default" made everything happy again.
Is it possible to not hard-code the name of a theme, and instead grab it from the config file?
Thanks!
- R.
On 08/28/2012 07:51 AM, Rob Sheldon wrote:
The error wasn't showing up in any of RC's various logs, even with all the knobs turned up. A quick grep found rcube_template to be the most likely cause; on a whim I decided to grep the installation for "larry" and found a half-dozen or so references there. Changing them all to "default" made everything happy again.
Is it possible to not hard-code the name of a theme, and instead grab it from the config file?
No, there always be a need to hardcoded fallback. You just encountered a bug in 0.8.0, which was fixed in 0.8.1. It means in 0.8.1 you shouldn't need to change anything.
On 2012-08-27 22:57, A.L.E.C wrote:
On 08/28/2012 07:51 AM, Rob Sheldon wrote:
The error wasn't showing up in any of RC's various logs, even with all the knobs turned up. A quick grep found rcube_template to be the most likely cause; on a whim I decided to grep the installation for "larry" and found a half-dozen or so references there. Changing them all to "default" made everything happy again.
Is it possible to not hard-code the name of a theme, and instead grab it from the config file?
No, there always be a need to hardcoded fallback. You just encountered a bug in 0.8.0, which was fixed in 0.8.1. It means in 0.8.1 you shouldn't need to change anything.
A hardcoded fallback would be OK, but there was no reason for 0.8.1 to be "falling back"; there was a folder in /skins called "default", the user preferences were set to "default". I don't understand why crashing would be the preferred behavior here.
- R.
On 08/28/2012 08:18 AM, Rob Sheldon wrote:
A hardcoded fallback would be OK, but there was no reason for 0.8.1 to be "falling back"; there was a folder in /skins called "default", the user preferences were set to "default". I don't understand why crashing would be the preferred behavior here.
Because for backward compatybility we've added a mapping default => larry. So, if user removes larry skin it won't work. With 0.8.1 you can just keep larry and don't worry about skin setting in user preferences.
Maybe we should make this mapping conditional, ie. change to larry if skins/default folder doesn't exist.
On 2012-08-28 0:16, A.L.E.C wrote:
Because for backward compatybility we've added a mapping default => larry. So, if user removes larry skin it won't work. With 0.8.1 you can just keep larry and don't worry about skin setting in user preferences.
Maybe we should make this mapping conditional, ie. change to larry if skins/default folder doesn't exist.
Ahh, that makes sense. I did the 0.8.0 upgrade first, changed the skin there, before that was fixed in 0.8.1. (Otherwise I wouldn't've messed with it.)
Let me know what you decide to do long-term and I'll fix whatever I need to on my end to make it work with future versions.
Thanks,
- R.
-
A.L.E.C -
Rob Sheldon