On 8/31/07, Robin Elfrink elfrink@introweb.nl wrote:

Hi,

I've (re)started some changes in folder management. Goal is to be able to move a folder to another parent (or top-) folder.

Attached patch shows what I have so far; changing a folder's parent works.

Things to be done:

• Refresh subscription list after moving a folder
• Make newly selected folder selectable
• Optional: Add 'parent' dropdown in new-folder form

Hmm, drag and drop?

I might even need to make sure another separator than '.' can be used, although I haven't checked the need for that (rfc, docs).

Any comments so far? Should I continue or go another way?

Continue! ;-)

I tried drag&drop, which worked more or less, except for two things:

• A folder in the top of the list cannot be moved to a folder in the

bottom of the list, if the list is bigger than the table (ie the scrollbar doesn't move along). Though that can possibly be fixed with a bit of JS.

• I have no idea what the best dropping place would be if I want to move

a folder to the root of the tree.

Maybe a "blank" spot?

I am thinking, we could also use "arrows" to move up and down in a folder tree?

Anyway, good work. :-)

Till _______________________________________________ List info: http://lists.roundcube.net/dev/

Brett Patterson wrote:

I would expect (since folders are naturally alphabetically sorted) that dropping at the top (above the top-most folder, but below the gray header) would be a good spot to move a folder to the root.

The spot must be very obvious and not too small. I'll think about it again. Drag & drop is much nicer.

I can't say this 100%; but I can swear that there are other sub-folder separators other than the ".". I know some servers (not sure which ones) allow you to choose the separator.

From my dovecot config:

namespace private { separator = . prefix = INBOX. inbox = yes }

I'll check the roundcube sources for any mentioning of a separator, and put it somewhere in the main object if it isn't already there. I recall seeing an IMAP command about long time ago.

Robin _______________________________________________ List info: http://lists.roundcube.net/dev/

I was thinking more along the lines of like how Photoshop or Fireworks does "Layers" in their images. You have the list of folders, and get a nice black line that defines where you'd be dropping it. Attached is a screen-shot of what I mean.

~Brett

Robin Elfrink wrote:

Brett Patterson wrote:

...

I would expect (since folders are naturally alphabetically sorted) that dropping at the top (above the top-most folder, but below the gray header) would be a good spot to move a folder to the root.

The spot must be very obvious and not too small. I'll think about it again. Drag & drop is much nicer.

...

I can't say this 100%; but I can swear that there are other sub-folder separators other than the ".". I know some servers (not sure which ones) allow you to choose the separator.

From my dovecot config:

namespace private { separator = . prefix = INBOX. inbox = yes }

I'll check the roundcube sources for any mentioning of a separator, and put it somewhere in the main object if it isn't already there. I recall seeing an IMAP command about long time ago.

Robin

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/5w/G6yDFyfu/drag_drop_layer.gif Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---

List info: http://lists.roundcube.net/dev/

Robin Elfrink wrote:

The file program/lib/imap.inc has function iil_C_NameSpace(&$conn). But it isn't used anywhere in RoundCube.

Oh darn, RC uses the term 'delimiter' :)

function get_hierarchy_delimiter().

Good, I can use that.

Robin _______________________________________________ List info: http://lists.roundcube.net/dev/