Since yesterday evening, I can't load any mails and the addressbook anymore in 1.2-git [GIT 20160110.1602]. Flags such as read/unread are still set, though.
After attempting to load a mail, RC doesn't react anymore (can't even logout). After a reload of the page, it does react again, but still doesn't load mails.
The log is telling this:
[10-Jan-2016 21:57:17 Europe/Berlin] PHP Fatal error: Can't use function return value in write context in /kunden/394333_40476/webseiten/webmail-beta/program/lib/Roundcube/rcube_addressbook.php on line 553 [... and 20 or so times more till I gave up ...]
Any idea? As the -git is my production environment, a soon help would be appreciated.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On 01/11/2016 03:19 PM, Michael Heydekamp wrote:
[10-Jan-2016 21:57:17 Europe/Berlin] PHP Fatal error: Can't use function return value in write context in
I fixed this a few hours ago.
Am 11.01.2016 15:22, schrieb A.L.E.C:
On 01/11/2016 03:19 PM, Michael Heydekamp wrote:
[10-Jan-2016 21:57:17 Europe/Berlin] PHP Fatal error: Can't use function return value in write context in
I fixed this a few hours ago.
Right, thanks and fix (after git-pull) confirmed. :)
Sorry for posting in HTML this time, but it makes my life easier, as I have found two/three more issues which I can better demonstrate with small pics (except for the first one):
* When replying to an own message in RC stable, the message goes to myself
(that's NOT how it should be). When replying to the very same message in 1.2-git, it goes to the original recipient (that's how it should be!). So 1.2-git is more stable than our current stable 1.0.8 [GIT 20151223.0948] in this regard. If you need more detailed info, please let me know.
*
The headers List-* are display-wise currently collected into one header and displayed this way in 1.2-git:
Not quite how it should be, I would assume...?
Plus that it should read "MAILINGLISTE" rather than "MAILING LISTE" in German. A common error thanks to "anglifying" everything these days.
*
Another translation issue - if you click on the down arrow of an attachment, you'll see:
Ehm... Who the hell did translate this? Of course, the English term "Open" also means "Offen", but in this context it should of course read "Öffnen". Are we doing Google or Babelfish translations in Roundcube these days...?
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On 01/12/2016 01:54 AM, Michael Heydekamp wrote:
- When replying to an own message in RC stable, the message goes to myself (that's *not* how it should be). When replying to the very same message in 1.2-git, it goes to the original recipient (that's how it should be!). So 1.2-git is more stable than our current stable 1.0.8 [GIT 20151223.0948] in this regard. If you need more detailed info, please let me know.
There were many changes between 1.0 and 1.2, I don't really have time to dig which fixed that and if it's safe to backport it to 1.0.
The headers List-* are display-wise currently collected into one header and displayed this way in 1.2-git:
Yeah, there was a change recently to the headers output. I see this break some plugins. However, I don't see a way to fix this on core code side, so the plugin needs to change.
The commit is here https://github.com/roundcube/roundcubemail/commit/9aaeb23d9de9324f2b5450b844...
Plus that it should read *"Mailingliste"* rather than *"Mailing Liste"* in German. A common error thanks to "anglifying" everything these days.
That's listcommands plugin, write to its author.
Another translation issue - if you click on the down arrow of an attachment, you'll see: Ehm... Who the hell did translate this? Of course, the English term "Open" also means "Offen", but in this context it should of course read "Öffnen". Are we doing Google or Babelfish translations in Roundcube these days...?
Become a member of our translation team at https://www.transifex.com/roundcube/roundcube-webmail/ and fix it by yourself, please.
On 01/12/2016 08:16 AM, A.L.E.C wrote:
The headers List-* are display-wise currently collected into one header and displayed this way in 1.2-git:Yeah, there was a change recently to the headers output. I see this break some plugins. However, I don't see a way to fix this on core code side, so the plugin needs to change.
The commit is here https://github.com/roundcube/roundcubemail/commit/9aaeb23d9de9324f2b5450b844...
Actually there was another bug. Fixed, but listcommands may still be broken.
2016-01-12 12:50 időpontban A.L.E.C ezt írta:
On 01/12/2016 08:16 AM, A.L.E.C wrote:
The headers List-* are display-wise currently collected into one header and displayed this way in 1.2-git:Yeah, there was a change recently to the headers output. I see this break some plugins. However, I don't see a way to fix this on core code side, so the plugin needs to change.
The commit is here https://github.com/roundcube/roundcubemail/commit/9aaeb23d9de9324f2b5450b844...
Actually there was another bug. Fixed, but listcommands may still be broken.
Yes, broken. I followed this changes with a simple modification in listcommands.php: https://github.com/corbosman/listcommands/blob/master/listcommands.php#L56 You have to add a 'html' => true element to the array like this commit: https://github.com/Takika/listcommands/commit/1a0446e2151d55c9e94996c76a7d09...
On 14 Jan 2016, at 02:28, Sandor Takacs taki@alkoholista.hu wrote:
2016-01-12 12:50 időpontban A.L.E.C ezt írta:
On 01/12/2016 08:16 AM, A.L.E.C wrote:
The headers List-* are display-wise currently collected into one header and displayed this way in 1.2-git:
Yeah, there was a change recently to the headers output. I see this break some plugins. However, I don't see a way to fix this on core code side, so the plugin needs to change. The commit is here https://github.com/roundcube/roundcubemail/commit/9aaeb23d9de9324f2b5450b844...
Actually there was another bug. Fixed, but listcommands may still be broken.
Yes, broken. I followed this changes with a simple modification in listcommands.php: https://github.com/corbosman/listcommands/blob/master/listcommands.php#L56 You have to add a 'html' => true element to the array like this commit: https://github.com/Takika/listcommands/commit/1a0446e2151d55c9e94996c76a7d09...
If you do a PR with that patch I can accept it. Alec, is that the way to fix the plugin with regards to the changes in core?
Cor
On 01/15/2016 02:13 PM, cor@xs4all.nl wrote:
Yes, broken. I followed this changes with a simple modification in listcommands.php: https://github.com/corbosman/listcommands/blob/master/listcommands.php#L56 You have to add a 'html' => true element to the array like this commit: https://github.com/Takika/listcommands/commit/1a0446e2151d55c9e94996c76a7d09...
If you do a PR with that patch I can accept it. Alec, is that the way to fix the plugin with regards to the changes in core?
Yes.
-
A.L.E.C -
Aurélio de Souza Ribeiro Neto -
cor＠xs4all.nl -
Michael Heydekamp -
Sandor Takacs