Hi,
here is a patch to return languages array in an order specified by 'program/localization/index.inc'. Without this Russian is shown as a last element of a list while everybody expect it to be somewhere at 3/4. If using ksort on array, then Chinese localizations move down which is probably incorrect too, so I decided to keep order mentioned above.
Best, Bubble
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/SN/4qrnU1HB/roundcube-languages-.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Vladislav Bogdanov wrote:
here is a patch to return languages array in an order specified by 'program/localization/index.inc'. Without this Russian is shown as a last element of a list while everybody expect it to be somewhere at 3/4.
What you say for this? http://trac.roundcube.net/changeset/2989
A.L.E.C wrote:
Vladislav Bogdanov wrote:
here is a patch to return languages array in an order specified by 'program/localization/index.inc'. Without this Russian is shown as a last element of a list while everybody expect it to be somewhere at 3/4.
What you say for this? http://trac.roundcube.net/changeset/2989
I'd not do it such way... I prefer not to have such hacks in a code. English 'P' (pi) is not a replacement for russian 'Р' (er). It is better to rename label to 'Russian (Русский)'. Or to apply my patch... It guaranties order will not be screwed up even if all languages with non-latin characters will be labeled with native labels.
Vladislav _______________________________________________ List info: http://lists.roundcube.net/dev/
Vladislav Bogdanov wrote:
English 'P' (pi) is not a replacement for russian 'Р' (er). It is better to rename label to 'Russian (Русский)'.
There was a mess on languages list, so now we're using <English name> (<original name>) notation.
http://trac.roundcube.net/changeset/2990
On Sep 25, 2009, A.L.E.C wrote:
English 'P' (pi) is not a replacement for russian '??' (er). It is better to rename label to 'Russian (??????????????)'.
There was a mess on languages list, so now we're using <English name> (<original name>) notation.
Oops, then you need to change this:
'cy_GB' => 'Cymric (Cymraeg)',
to
'cy_GB' => 'Welsh (Cymraeg)',
List info: http://lists.roundcube.net/dev/
A.L.E.C wrote:
Vladislav Bogdanov wrote:
English 'P' (pi) is not a replacement for russian 'Р' (er). It is better to rename label to 'Russian (Русский)'.
There was a mess on languages list, so now we're using <English name> (<original name>) notation.
That is fine for me.
Vladislav _______________________________________________ List info: http://lists.roundcube.net/dev/
-
A.L.E.C -
Dafydd Tomos -
Vladislav Bogdanov