till wrote:

I read the thread and I never noticed this error before. Does this happen when you use RoundCube in multiple tabs? Is that the catch?

Can you explain more in detail how you reproduce this message because I can't. Step-by-step, please. Also include PHP version, OS etc..

I had this happen, and it was happening constantly. What I noticed whas that $_SESSION['compose'] was empty when entering program/steps/mail/compose.inc.

After that I haven't looked at the problem for about a week, and when I did it was gone. Haven't seen it again since. Which kind of sucks, because no problem -> no debugging :(

Robin _______________________________________________ List info: http://lists.roundcube.net/dev/

A.L.E.C wrote:

till wrote:

...

I read the thread and I never noticed this error before. Does this happen when you use RoundCube in multiple tabs? Is that the catch?

I was thinking if we can get rid of $_SESSION for mail composing. It's possible and should prevent from multitabs and session issues, but will require to sent real saved attachment filenames to the client. It'd to be some secure issue?

As long as you still store all of them in an session array and validate client values against the server-side list I don't think this is an issue.

Best regards,

Michael

till wrote:

...

...

I read the thread and I never noticed this error before. Does this happen when you use RoundCube in multiple tabs? Is that the catch?

I was thinking if we can get rid of $_SESSION for mail composing. It's possible and should prevent from multitabs and session issues, but will require to sent real saved attachment filenames to the client. It'd to be some secure issue?

Real saved attachments? Can you explain that?

Sorry for my English. I mean, filenames of attachments saved on disk by upload or on reply (in temp dir), e.g. rcmAttmntMzsXKZ.

till wrote:

Hmm, if we'd attach that, people would be mad. ;-) Maybe we could do upload_tmp_dir/user/filename (name from $_FILES). We either clean up the files regulary, or we use the tmp_name and store the real name somewhere else ($_SESSION)?

The idea is to get rid of session ;)

Michael Baierl wrote:

...

The idea is to get rid of session ;)

Question - why?

1. In current solution you can't compose two emails in the same time

(exactly you can compose, but you can't sent the second one). 2. There're session race condition issues (e.g.if you click compose while getunread or check-recent action is in progress).

Maybe we can use session for attachments only (with some mods), but it would be better to get rid of session for other compose data.

Maybe borrow the idea behind mqueues? Use a uniq compose id for a message and then create a mail attachment info/data file sets.

$_SESS['rcmcpmid'] = 'n3ECQ9sQ018441';

then in $tmp_dir/compose/

n3ECQ9sQ018441

which then contains a unique file 'pick up' id, and a real file name.

e.g.

df985jhfkjaf, real.file.name kjfa8kjf749f, other.file.txt

then in $tmp_dir/cmppickup/

df985jhfkjaf kjfa8kjf749f

which is the temporary store for the attachments.

On Tue, 14 Apr 2009 14:12:37 +0200, till klimpong@gmail.com wrote:

Hmm, if we'd attach that, people would be mad. ;-) Maybe we could do upload_tmp_dir/user/filename (name from $_FILES). We either clean up the files regulary, or we use the tmp_name and store the real name somewhere else ($_SESSION)?

Till _______________________________________________ List info: http://lists.roundcube.net/dev/

On Tue, Apr 14, 2009 at 2:40 PM, Robert King robk@mun.ca wrote:

Maybe borrow the idea behind mqueues?  Use a uniq compose id for a message and then create a mail attachment info/data file sets.

$_SESS['rcmcpmid'] = 'n3ECQ9sQ018441';

then in $tmp_dir/compose/

n3ECQ9sQ018441

which then contains a unique file 'pick up' id, and a real file name.

e.g.

df985jhfkjaf, real.file.name kjfa8kjf749f, other.file.txt

then in $tmp_dir/cmppickup/

df985jhfkjaf kjfa8kjf749f

which is the temporary store for the attachments.

Yeah, that's what I basically wanted. I think the idea is to fix our session handling. I mean on the flip side, it wasn't designed to be used in multiple tabs, but if that is what people want -- guess we'll have to fix it.

Till _______________________________________________ List info: http://lists.roundcube.net/dev/