Hi Eric,

Would you please try Roundcube SVN r2851 with a patch I've sent originally? I definitely touched that part of Chris's code (with slices/counts).

Alternatively, you could try 0.3-RC1 with patch I attach here. There is one note on it, files app.js.src and list.js.src should be copied over respectively app.js and list.js right after applying. You will see rejects (app.js and list.js) while applying this patch, please ignore them, this patch is made against a specially-crafted RC1 copy. This one is an original version of patch I've made, it was ported to apply cleanly to SVN trunk then.

If problem persists I'll try to reproduce and firebug it.

Best, Vladislav

Eric Appelt wrote:

Hi Chris and Vladislav

thx for your work show the attached image ...

The green and yellow Messages are the same after deleting 4 Messages

When i delete 4 Messages and the next 4 loads in the message list the

4 reloaded Messages are exists already in the message list the already

exists Messages can't select or click this issue comes from threading patch testet with my

patched installation clean RC0.3 snapshot and the snapshot from atomice.com this issue is only

by the versions with threading it threading display enabled or disabled or preview is

enabled or disabled is all the same after deleting some messages to four times

some messages shows twice in messagelist i have testet with some browsers IE Firefox Opera and chrome

on Windows XP and Gentoo and i have testet with an courier, cyrus and exim by all installations

i have this issue with threading. I hope you find a solution

Thx Lacri

*Detachments* -The following attachments have been detached and are available for viewing.

* http://detached.gigo.com/rc/jY/gdVQUrR4/threaded_bug.jpg 

Only click these links if you trust the sender, as well as this message.

---

---

List info: http://lists.roundcube.net/dev/

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Ma/GqPpsa9J/roundcubemail-0.3-RC.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---

List info: http://lists.roundcube.net/dev/

Hi Vladislav,

i forgott the video here is the missing file sorry i have this only as wmv.

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/wR/wBRA9pUu/07122007-1.wmv Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---

List info: http://lists.roundcube.net/dev/

On Thu, Aug 27, 2009 at 03:52:46PM +0300, Vladislav Bogdanov wrote:

Hi Eric, Hi all

Eric Appelt wrote:

...

Hi Vladislav,

i forgott the video here is the missing file

Yep, video is useful. I'm able to reproduce it.

More, here is a nasty problem when deleting thread-leading message while it's not expanded. Children are neither shown nor deleted. Mailbox reload shows them then.

There two possible ways: either delete child messages too, or show next level of depth (and mode if that messages are in expanded state) immediately.

Question to all: What way is a preferred one?

I'm not sure yet if these problems are related or not. Will dig deeper.

Vladislav

I worked on Chris' threading patches a while back. I can't remember if I did something about the delete issue, but here was something I did about moving and copying whole threads:

http://code.nkinka.de/gitweb?p=roundcube.git;a=commitdiff;h=f3bb47d0e30a2e58...

I haven't been using Roundcube for some time now, and I can't remember whether this patch was 100% working.

Nathan _______________________________________________ List info: http://lists.roundcube.net/dev/

Hi!

It is transparent for me that copy/move operations should touch nested messages as well. I incline to use the same approach for a delete operation, so nested messages will be deleted as well.

The more I think about it the more I sure that nested messages should only be copied/moved/deleted if selected parent message is in collapsed state. If it is, then user doesn't see nested messages and whole thread should be affected by an operation. If parent message is 'expanded', then it should be affected alone because next expansion level is visible to user. If that messages were left unselected, then user wanted to copy not a whole thread.

Opinions?

Vladislav _______________________________________________ List info: http://lists.roundcube.net/dev/