here's a small patch for 0.1.1
for large imap folders when the imap server supports sorting the speed increase is vast. on my very slow epia box it took 90+ seconds to browse my 14k email inbox (only showing the first 40!). after the patch down to about 6 seconds.
there's a fix to rep_specialchars_output as well, as at least php5.2.5 seemed to always recreate the js_rep_table (which takes a lot of time, about 3 seconds or so on my slow system)
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/gb/cCronKdx/performance-jh1.diff Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Justin Heesemann wrote:
here's a small patch for 0.1.1
for large imap folders when the imap server supports sorting the speed increase is vast. on my very slow epia box it took 90+ seconds to browse my 14k email inbox (only showing the first 40!). after the patch down to about 6 seconds.
there's a fix to rep_specialchars_output as well, as at least php5.2.5 seemed to always recreate the js_rep_table (which takes a lot of time, about 3 seconds or so on my slow system)
It looks very nice. On my box with 5k messages, before was 4-5 sec. Now it opens/sorts the box in 1-2 sec. Patch applied. Thanks.
ps. in future use trac, please.
On Tue, 29 Apr 2008 08:48:02 +0200, "A.L.E.C" alec@alec.pl wrote:
It looks very nice. On my box with 5k messages, before was 4-5 sec. Now it opens/sorts the box in 1-2 sec. Patch applied. Thanks.
Thank you, the improvement is quite measurable! :)
List info: http://lists.roundcube.net/dev/
Thanks Justin!
Highly appreciated!
On Tue, Apr 29, 2008 at 1:49 AM, Justin Heesemann ever-roundcube@blocksberg.com wrote:
here's a small patch for 0.1.1
for large imap folders when the imap server supports sorting the speed increase is vast. on my very slow epia box it took 90+ seconds to browse my 14k email inbox (only showing the first 40!). after the patch down to about 6 seconds.
there's a fix to rep_specialchars_output as well, as at least php5.2.5 seemed to always recreate the js_rep_table (which takes a lot of time, about 3 seconds or so on my slow system)
List info: http://lists.roundcube.net/dev/
On Apr 28, 2008, at 6:49 PM, Justin Heesemann wrote:
for large imap folders when the imap server supports sorting
There were several posts that this change works well, but no mention
of what IMAP server software was used in those tests.
Courier - Web site [1] says "IMAP extensions that implement server-
side sorting."
Cyrus - The Wiki [2] indicates it supports "IMAP SORT and THREAD
Extension"
Dovecot - Home page [3] says "Supports multiple commonly used IMAP
extensions, including SORT, THREAD and IDLE."
Those are the commonly used servers in my experience, are people
using other software, and does that software support sorting ?
There is this list of servers that support IMAP :
<http://en.wikipedia.org/wiki/ Internet_Message_Access_Protocol#Common_Server_implementations>
and this list :
http://en.wikipedia.org/wiki/List_of_mail_servers#POP.2FIMAP
[1] - http://www.courier-mta.org/imap/features.html [2] - <http://cyrusimap.web.cmu.edu/twiki/bin/view/Cyrus/ SpecificationsAndStandards> [3] - http://dovecot.org/
Charles Dostale System Admin - Silver Oaks Communications http://www.silveroaks.com/ 824 17th Street, Moline IL 61265
List info: http://lists.roundcube.net/dev/
On Tue, 29 Apr 2008 12:19:59 -0500, chasd chasd@silveroaks.com wrote:
On Apr 28, 2008, at 6:49 PM, Justin Heesemann wrote:
for large imap folders when the imap server supports sorting
There were several posts that this change works well, but no mention
of what IMAP server software was used in those tests.Courier - Web site [1] says "IMAP extensions that implement server- side sorting." Cyrus - The Wiki [2] indicates it supports "IMAP SORT and THREAD
Extension" Dovecot - Home page [3] says "Supports multiple commonly used IMAP
extensions, including SORT, THREAD and IDLE."Those are the commonly used servers in my experience, are people
using other software, and does that software support sorting ?
Are you concerned that the change will break RoundCube on non-SORTing IMAP servers? He didn't change the logic that looks for the 'sort' capability in the capabilities list, so non-SORT-capable IMAP servers should work just as well as before the change (and benefit from the array handling speedup).
There is this list of servers that support IMAP :
<http://en.wikipedia.org/wiki/ Internet_Message_Access_Protocol#Common_Server_implementations>
and this list :
http://en.wikipedia.org/wiki/List_of_mail_servers#POP.2FIMAP
[1] - http://www.courier-mta.org/imap/features.html [2] - <http://cyrusimap.web.cmu.edu/twiki/bin/view/Cyrus/ SpecificationsAndStandards> [3] - http://dovecot.org/
Charles Dostale System Admin - Silver Oaks Communications http://www.silveroaks.com/ 824 17th Street, Moline IL 61265
List info: http://lists.roundcube.net/dev/
Are you concerned that the change will break RoundCube on non- SORTing IMAP servers?
Not really.
He didn't change the logic that looks for the 'sort' capability in the capabilities list, so non-SORT-capable IMAP servers should work
just as well as before the change (and benefit from the array handling
speedup).
If you promote this as a feature of a new version, then you would
need to qualify it by saying when used with specific IMAP servers.
I might be a good idea to add to the Requirements page [1] beyond this :
# An IMAP server which supports IMAP 4 rev 1
to also recommend one that supports sorting [2] for best performance.
Also, saying WFM without mentioning what platform, what IMAP server
software and version is similar to saying a certain JavaScript change
WFM without mentioning what platform, what browser and version you
tested. The responses seemed odd to me. If developers really only
test using a small set of IMAP servers, then that small set should be
delineated somehow.
[1] - http://trac.roundcube.net/wiki/Howto_Requirements [2] - <http://www.ietf.org/internet-drafts/draft-ietf-imapext- sort-20.txt>
Charles Dostale System Admin - Silver Oaks Communications http://www.silveroaks.com/ 824 17th Street, Moline IL 61265
List info: http://lists.roundcube.net/dev/
-
A.L.E.C -
chasd -
Eric Stadtherr -
Justin Heesemann -
Sebastian Krämer -
till