I updated from SVN version 285 to 288, and in doing so I now have problems with the message sort order on BincIMAP. It's working fine on my Courier server.
What happens is that the messages in the inbox are in random order, even though the "date" column header is highlighted. If it refreshes to check new mail and finds something, it does go at the top. However, once you reload the page the messages return to their previous order. The order doesn't correspond to any discernible pattern.
If I move back and forth between pages, the messages stay in the same order.
BincIMAP does not support server-side sorting, so the usual sort functions in Roundcube are disabled (column headers are not clickable.) Perhaps there needs to be an additional capability check that can default back to client-side sorting in this case?
I really, really wish I didn't have to deal with BincIMAP, but I guess it does help to hunt down bugs in lesser-used code paths...
Jim
On Tue, 01 Aug 2006 12:34:04 -0400, Jim Pingle lists@pingle.org wrote:
I updated from SVN version 285 to 288, and in doing so I now have problems with the message sort order on BincIMAP. It's working fine on my Courier server.
I'm having this too, showed up in yesterday's checkout (not sure about Sunday) -=- NOTE: I run Dovecot for IMAP:
What happens is that the messages in the inbox are in random order, even though the "date" column header is highlighted.
I don't have this, they stay in time/date order, regardless of if I have 'pretty dates' on or off, but the newest one is always on the bottom of the list
If it refreshes to check new mail and finds something, it does go at the top. However, once you reload the page the messages return to their previous order. The order doesn't correspond to any discernible pattern.
I get this exact behavior.
I know there were some patches to fix sorting (although I never had any sorting issues until these patches hit :))
P
If I move back and forth between pages, the messages stay in the same order.
BincIMAP does not support server-side sorting, so the usual sort functions in Roundcube are disabled (column headers are not clickable.) Perhaps there needs to be an additional capability check that can default back to client-side sorting in this case?
I really, really wish I didn't have to deal with BincIMAP, but I guess it does help to hunt down bugs in lesser-used code paths...
Jim
-- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
-- http://fak3r.com - you don't have to kick it
Eric Stadtherr wrote:
I am partially responsible for the sorting "fixes" of late, so I'd like to take part in the resolution of this one. Rev288 contains a fix I made to the code that manages the results of the server-side sorting Although the fix is working, it seems that it negatively impacted the behavior in the absence of "SORT" capability on the IMAP server.
I believe the behavior before my fix was to simply display the messages in IMAP Message Sequence Number order (basically the order the messages arrived in the folder). I think I can come up with an easy patch to restore this behavior when "SORT" capability is absent. How does that sound?
Sounds good to me. Hopefully it will be an easy fix!
If you need me to try any patches, let me know.
Thanks, Jim
On Tue, 01 Aug 2006 13:53:49 -0400, Jim Pingle lists@pingle.org wrote:
Eric Stadtherr wrote:
I am partially responsible for the sorting "fixes" of late, so I'd like to take part in the resolution of this one. Rev288 contains a fix I made to the code that manages the results of the server-side sorting Although the fix is working, it seems that it negatively impacted the behavior in the absence of "SORT" capability on the IMAP server.
I believe the behavior before my fix was to simply display the messages in IMAP Message Sequence Number order (basically the order the messages arrived in the folder). I think I can come up with an easy patch to restore this behavior when "SORT" capability is absent. How does that sound?
Sounds good to me. Hopefully it will be an easy fix!
If you need me to try any patches, let me know.
I agree, I'd rather have if fixed than making it another config option -- also I'm open for testing patches against Dovecot, just let me know.
Thanks
P
Thanks, Jim
-- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
-- http://fak3r.com - you don't have to kick it
On Tue, 01 Aug 2006 13:53:49 -0400, Jim Pingle wrote: Eric Stadtherr wrote:
I am partially responsible for the sorting "fixes" of late, so
I'd like
to take part in the resolution of this one. Rev288 contains a fix
I made
to the code that manages the results of the server-side sorting
Although
the fix is working, it seems that it negatively impacted the
behavior in
the absence of "SORT" capability on the IMAP server.
I believe the behavior before my fix was to simply display the
messages
in IMAP Message Sequence Number order (basically the order the
messages
arrived in the folder). I think I can come up with an easy patch
to
restore this behavior when "SORT" capability is absent. How does
that
sound?
Sounds good to me. Hopefully it will be an easy fix!
If you need me to try any patches, let me know.
I agree, I'd rather have if fixed than making it another config option -- also I'm open for testing patches against Dovecot, just let me know.
Thanks
P
Thanks, Jim
On Tue, 1 Aug 2006 12:06:09 -0600, Eric Stadtherr estadtherr@gmail.com wrote:
Phil,
I'm a little confused about why you're seeing errors with Dovecot. Dovecot is my IMAP server as well, and it sorts perfectly. What version of Dovecot do you have?
-Eric On Tue, 1 Aug 2006 12:58:49 -0500, phil wrote:
dovecot-1.0.r2 - I don't see anything in dovecot.conf that deals with sorting, so I don't know how it could be on my side (but I"m happy to look further)
P
-- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean
-- http://fak3r.com - you don't have to kick it -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
Hi Eric,
I've applied your patch and it solved the issue I was having with sorting in my mailboxes. I'm not sure why the server-side sorting isn't working for me, given that hMailserver supports it.. but I'll dig into that separately.
Thanks!!
Andrew
On Tue, 1 Aug 2006 13:14:26 -0600, Eric Stadtherr estadtherr@gmail.com wrote:
All,
I have a patch that restores the message sorting behavior in cases where the IMAP server does not support the "SORT" command:
http://stadtherr.bounceme.net/files/imap_no_sort.patch [1] It was created against a working copy of Subversion rev288.
Sorry for the goofup - I didn't have a non-sorting IMAP server to test with!
-Eric On Tue, 1 Aug 2006 11:07:00 -0600, Eric Stadtherr wrote: I am partially responsible for the sorting "fixes" of late, so I'd like to take part in the resolution of this one. Rev288 contains a fix I made to the code that manages the results of the server-side sorting. Although the fix is working, it seems that it negatively impacted the behavior in the absence of "SORT" capability on the IMAP server.
I believe the behavior before my fix was to simply display the messages in IMAP Message Sequence Number order (basically the order the messages arrived in the folder). I think I can come up with an easy patch to restore this behavior when "SORT" capability is absent. How does that sound?
-EricOn Tue, 01 Aug 2006 12:34:04 -0400, Jim Pingle wrote: I updated from SVN version 285 to 288, and in doing so I now have problems with the message sort order on BincIMAP. It's working fine on my Courier server.
What happens is that the messages in the inbox are in random order, even though the "date" column header is highlighted. If it refreshes to check new mail and finds something, it does go at the top. However, once you reload the page the messages return to their previous order. The order doesn't correspond to any discernible pattern.
If I move back and forth between pages, the messages stay in the same order.
BincIMAP does not support server-side sorting, so the usual sort functions in Roundcube are disabled (column headers are not clickable.) Perhaps there needs to be an additional capability check that can default back to client-side sorting in this case?
I really, really wish I didn't have to deal with BincIMAP, but I guess it does help to hunt down bugs in lesser-used code paths...
Jim
Links:
On Wed, 2 Aug 2006 12:55:07 -0700, Andrew Fladmark afladmark@orbital-webcom wrote:
Hi Eric,
I've applied your patch and it solved the issue I was having with sorting in my mailboxes. I'm not sure why the server-side sorting isn't working for me, given that hMailserver supports it.. but I'll dig into that separately.
Has this already been applied to trunk? I ask because I just checked out a fresh copy from svn and everything works now; sorting is good to go.
P
Thanks!!
Andrew
On Tue, 1 Aug 2006 13:14:26 -0600, Eric Stadtherr estadtherr@gmail.com wrote:
All,
I have a patch that restores the message sorting behavior in cases where the IMAP server does not support the "SORT" command:
http://stadtherr.bounceme.net/files/imap_no_sort.patch [1] It was created against a working copy of Subversion rev288.
Sorry for the goofup - I didn't have a non-sorting IMAP server to test with!
-Eric On Tue, 1 Aug 2006 11:07:00 -0600, Eric Stadtherr wrote: I am partially responsible for the sorting "fixes" of late, so I'd like to take part in the resolution of this one. Rev288 contains a fix I made to the code that manages the results of the server-side sorting. Although the fix is working, it seems that it negatively impacted the behavior in the absence of "SORT" capability on the IMAP server.
I believe the behavior before my fix was to simply display the messages in IMAP Message Sequence Number order (basically the order the messages arrived in the folder). I think I can come up with an easy patch to restore this behavior when "SORT" capability is absent. How does that sound?
-EricOn Tue, 01 Aug 2006 12:34:04 -0400, Jim Pingle wrote: I updated from SVN version 285 to 288, and in doing so I now have problems with the message sort order on BincIMAP. It's working fine on my Courier server.
What happens is that the messages in the inbox are in random order, even though the "date" column header is highlighted. If it refreshes to check new mail and finds something, it does go at the top. However, once you reload the page the messages return to their previous order. The order doesn't correspond to any discernible pattern.
If I move back and forth between pages, the messages stay in the same order.
BincIMAP does not support server-side sorting, so the usual sort functions in Roundcube are disabled (column headers are not clickable.) Perhaps there needs to be an additional capability check that can default back to client-side sorting in this case?
I really, really wish I didn't have to deal with BincIMAP, but I guess it does help to hunt down bugs in lesser-used code paths...
Jim
Links:
-- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
-- http://fak3r.com - you don't have to kick it
On Tue, 1 Aug 2006 11:07:00 -0600, Eric Stadtherr estadtherr@gmail.com wrote:
I am partially responsible for the sorting "fixes" of late, so I'd like to take part in the resolution of this one. Rev288 contains a fix I made to the code that manages the results of the server-side sorting Although the fix is working, it seems that it negatively impacted the behavior in the absence of "SORT" capability on the IMAP server.
I believe the behavior before my fix was to simply display the messages in IMAP Message Sequence Number order (basically the order the messages arrived in the folder). I think I can come up with an easy patch to restore this behavior when "SORT" capability is absent. How does that sound?
For me date order and arravial order are two different ways of sorting messages.
--
Lic. Martín Marqués | SELECT 'mmarques' || Centro de Telemática | '@' || 'unl.edu.ar'; Universidad Nacional | DBA, Programador, del Litoral | Administrador
On Tue, 1 Aug 2006 12:58:49 -0500, phil phil@cryer.us wrote:
I agree, I'd rather have if fixed than making it another config option -- also I'm open for testing patches against Dovecot, just let me know.
I'm using dovecot without a problem. Which version of dovecot are you using?
--
Lic. Martín Marqués | SELECT 'mmarques' || Centro de Telemática | '@' || 'unl.edu.ar'; Universidad Nacional | DBA, Programador, del Litoral | Administrador
On Thu, 3 Aug 2006, Eric Stadtherr wrote:
Are you proposing that those be two different sort fields - essentially DATE and MSN (in IMAP-speak)?
Internally yes, but for the user, I would add the new two sort orders in the date column, as kmail does it, changing the header so that the user knows what ordere is being used.
-- 21:50:04 up 2 days, 9:07, 0 users, load average: 0.92, 0.37, 0.18
Lic. Martín Marqués | SELECT 'mmarques' || Centro de Telemática | '@' || 'unl.edu.ar'; Universidad Nacional | DBA, Programador, del Litoral | Administrador
-
Andrew Fladmark -
Eric Stadtherr -
Jim Pingle -
Martin Marques -
phil -
Phil Cryer