Eric Stadtherr wrote:

* Spellchecking doesn't work within the HTML editor - I'm
  contemplating various solutions (anyone?)
* When sending an HTML message, a plain text version is also
  included in the outgoing MIME message.

Well, you could generate that plain text version when spellchecking is called and pass that on to the spellchecker. You'd simply use the same function in another place.

That makes me think of another feature - "Send if spelling is correct". This would send a mail when the spell checker has no complaints, and would mean you only have to convert the message to plain text once.

Cheers, ~Mik

Eric Stadtherr wrote:

All,

I just committed my changes to integrate the TinyMCE editor into RoundCube for HTML editing. The Subversion revision is 345. Everything should be pretty seamless, but please note the following:

Well, that looks very nice so far.

* To enable use of the editor for composing HTML messages, check the
  "Use HTML Editor" box in the Settings page

I would suggest to change the label to "Compose HTML messages", similar as Thunderbird calls this option.

* When replying/forwarding a plain text message, the plain text
  editor is always used by default. You can toggle on the HTML
  editor using the radio buttons below the text area

There's another feature request to forward messages as attachment (message/rfc822). I guess we can solve this when adding that feature.

* Spellchecking doesn't work within the HTML editor - I'm
  contemplating various solutions (anyone?)

TinyMCE uses a similar interface (google spell) for spell checking. They also have a pspell integration. Probably we could merge all together.

* There's a new column in the "identities" database table to store
  whether the signature is HTML or not. I modified the "initial" and
  "update" scripts in the SQL directory, but let me know if there
  are problems...

I have to find out, how the sqlite update script should look like. The mysql.update.sql included wrong quotes but I already committed a fix.

* When sending an HTML message, a plain text version is also
  included in the outgoing MIME message.

Perfect!

* Displaying picture attachments within the editor doesn't work - I
  think a custom TinyMCE plugin would be needed to bridge between
  the two.

I guess that requires us to make a file browser for attachments...

There are some other things that could possibly cause problems or could IMO be improved.

• in rcmail_compose_body() the same lines are repeated three times. The

code could be re-arranged in order to make it shorter and more readable.

• in rcmail_create_forward_body() you should run

rep_specialchars_output() on every header field in order to quote HTML entities.

• when you write HTML code for the editor, please use XHTML notation.

• Please use the radiobutton class to create the radio fields for input

mode. Also, <label>s would be nice to click on.

• There's a new function log_debug() in bugs.inc. Please remove it and

use write_log() in main.inc instead. I guess those two function are meant to do the same.

• As far as I can see (haven't tested it yet) every emoticon is added to

the mime message in rcmail_attach_emoticons(). If I add 5 :-) to my message, my mail gets 5 images attached. You should compare the file names and only add icons that are not already included.

Thanks for the work! Thomas

I just committed my changes to integrate the TinyMCE editor into RoundCube for HTML editing. The Subversion revision is 345. Everything should be pretty seamless, but please note the following:

• To enable use of the editor for composing HTML messages, check the "Use HTML Editor" box in the Settings page

It would be nice to have an admin override in the config file to not allow that choice. Some of us old farts think styled e-mail is a scourge that is surpassed in disdain only by the plague known as TNEF.

Charles Dostale System Admin - Silver Oaks Communications http://www.silveroaks.com/ 824 17th Street, Moline IL 61265

I agree that there should be a $CONFIG variable to disable it entirely, thereby giving the admin and the users a choice.

On a possibly related note: I normally don't top-post or leave so much quoted, but I did this time so the HTML that showed up at the end of your message is visible. Were you using the HTML editor on Roundcube? It appears that you tried to use HTML in your signature, and it wasn't interpreted as HTML by Thunderbird when I received it. Also, the signature "header" (--) was repeated, once inside a < p > tag and once without.

I didn't get a chance to see how it was interpreted inside of Roundcube itself.

Jim

Eric Stadtherr wrote:

It would be easy enough to add a $CONFIG variable to control whether the HTML editor is allowed or not, but I chose a "leave it off by default but let users turn it on" approach (similar to Net@ddress's free webmail service).

How does everyone else feel about this?

-Eric

On Fri, 15 Sep 2006 10:06:41 -0500, chasd@silveroaks.com wrote:

...

...

I just committed my changes to integrate the TinyMCE editor into RoundCube for HTML editing. The Subversion revision is 345. Everything should be pretty seamless, but please note the following:

• To enable use of the editor for composing HTML messages, check the "Use HTML Editor" box in the Settings page

It would be nice to have an admin override in the config file to not allow that choice. Some of us old farts think styled e-mail is a scourge that is surpassed in disdain only by the plague known as TNEF.

Charles Dostale System Admin - Silver Oaks Communications http://www.silveroaks.com/ 824 17th Street, Moline IL 61265

--

<p> -- </p> <p> <strong>Eric Stadtherr</strong> </p> <p> <a href="estadtherr@gmail.com">estadtherr@gmail.com</a> </p>