On Wed, Oct 12, 2011 at 13:17, Cor Bosman cor@xs4all.nl wrote:

With threads the zebra code is pretty much useless. Id just remove it, less to worry about.

I won't call it useless in threading mode. There we could use one color for the entire conversation.

~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

Hi,

2011.10.12 13:12, A.L.E.C rašė:

We have in Roundcube a feature which adds odd/even classes to table rows. This feature is currently buggy. Doesn't work as expected for threaded view and for row replacement actions e.g. in folder manager.

Fixing these bugs can be expensive and the way how the fixes would be implemented will be probably an expensive javascript operation (iterate over all rows of a table, detect and change class).

This feature is not used in default skin.

That's why I think we could remove this feature. Does anyone using it in custom skins?

I'm not a skin designer, but still decided to chime in.

Doesn't this feature duplicate the CSS3 nth-child pseudo-class, which is already supported by many browsers, including IE9? Also, jQuery provides similar selectors, and IIRC RoundCube now depends on jQuery, right?

I think with these two points in mind, it would make sense to drop this feature, if it's buggy and nobody wants to waste time on fixing it.

Regards, Rimas _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80