Hello,
now to the correct list address (sorry for dupe posting):
Apparently due to the commit quoted below, I (and not only me) can't send mail with 1.3-git anymore. I'm seeing a huge attachment window area, but no editor window area where I could enter any text.
Would it be possible to test at least this particular function before committing? Composing and sending a message is quite an essential feature of a webmail client. ;)
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
From git://github.com/roundcube/roundcubemail 9debc38..2225cf1 master -> origin/master 2fdb9c4..0e7d5a6 release-1.2 -> origin/release-1.2 Updating 9debc38..2225cf1 Fast-forward CHANGELOG | 7 + Dockerfile | 20 +- bin/jsshrink.sh | 8 +- plugins/jqueryui/README | 2 +- plugins/jqueryui/composer.json | 24 - plugins/jqueryui/config.inc.php.dist | 1 - plugins/jqueryui/jqueryui.php | 49 +- plugins/jqueryui/js/jquery-ui-1.10.4.custom.min.js | 252 ----- plugins/jqueryui/js/jquery-ui.min.js | 228 ++++ plugins/jqueryui/js/jquery.miniColors.min.js | 49 - plugins/jqueryui/js/jquery.minicolors.min.js | 11 + .../themes/classic/images/animated-overlay.gif | Bin 1738 -> 0 bytes .../classic/images/ui-bg_flat_0_aaaaaa_40x100.png | Bin 180 -> 0 bytes .../classic/images/ui-bg_flat_75_ffffff_40x100.png | Bin 178 -> 0 bytes .../classic/images/ui-bg_flat_90_cc3333_40x100.png | Bin 212 -> 0 bytes .../classic/images/ui-bg_glass_95_fef1ec_1x400.png | Bin 119 -> 0 bytes .../ui-bg_highlight-hard_90_a3a3a3_1x100.png | Bin 114 -> 0 bytes .../ui-bg_highlight-hard_90_e6e6e7_1x100.png | Bin 101 -> 0 bytes .../ui-bg_highlight-hard_90_f4f4f4_1x100.png | Bin 122 -> 0 bytes .../classic/images/ui-icons_000000_256x240.png | Bin 4369 -> 0 bytes .../classic/images/ui-icons_333333_256x240.png | Bin 4369 -> 0 bytes .../classic/images/ui-icons_444444_256x240.png | Bin 0 -> 6992 bytes .../classic/images/ui-icons_555555_256x240.png | Bin 0 -> 6988 bytes .../classic/images/ui-icons_666666_256x240.png | Bin 4369 -> 0 bytes .../classic/images/ui-icons_777620_256x240.png | Bin 0 -> 4549 bytes .../classic/images/ui-icons_777777_256x240.png | Bin 0 -> 6999 bytes .../classic/images/ui-icons_cc0000_256x240.png | Bin 0 -> 4549 bytes .../classic/images/ui-icons_cc3333_256x240.png | Bin 5355 -> 0 bytes .../classic/images/ui-icons_dddddd_256x240.png | Bin 4369 -> 0 bytes .../classic/images/ui-icons_ffffff_256x240.png | Bin 0 -> 6299 bytes .../{jquery-ui-1.10.4.custom.css => jquery-ui.css} | 669 ++++++----- .../{roundcube-custom.diff => jquery-ui.css.diff} | 114 +- .../themes/larry/images/jquery.minicolors.png | Bin 0 -> 68627 bytes .../themes/larry/images/minicolors-all.png | Bin 13370 -> 0 bytes .../themes/larry/images/minicolors-handles.gif | Bin 421 -> 0 bytes .../larry/images/ui-icons_004458_256x240.png | Bin 3395 -> 0 bytes .../larry/images/ui-icons_444444_256x240.png | Bin 0 -> 6992 bytes .../larry/images/ui-icons_555555_256x240.png | Bin 0 -> 6988 bytes .../larry/images/ui-icons_777620_256x240.png | Bin 0 -> 4549 bytes .../larry/images/ui-icons_777777_256x240.png | Bin 0 -> 6999 bytes .../larry/images/ui-icons_cc0000_256x240.png | Bin 0 -> 4549 bytes .../larry/images/ui-icons_d7211e_256x240.png | Bin 3378 -> 0 bytes .../larry/images/ui-icons_ffffff_256x240.png | Bin 0 -> 6299 bytes .../{jquery-ui-1.10.4.custom.css => jquery-ui.css} | 774 +++++++------ .../{jquery-ui-css.diff => jquery-ui.css.diff} | 297 +++-- .../jqueryui/themes/larry/jquery.miniColors.css | 106 -- .../jqueryui/themes/larry/jquery.minicolors.css | 327 ++++++ plugins/jqueryui/themes/larry/tagedit.css | 17 - .../themes/redmond/images/animated-overlay.gif | Bin 1738 -> 0 bytes .../redmond/images/ui-bg_flat_0_aaaaaa_40x100.png | Bin 180 -> 0 bytes .../redmond/images/ui-bg_flat_55_fbec88_40x100.png | Bin 182 -> 0 bytes .../redmond/images/ui-bg_glass_75_d0e5f5_1x400.png | Bin 162 -> 0 bytes .../redmond/images/ui-bg_glass_85_dfeffc_1x400.png | Bin 123 -> 0 bytes .../redmond/images/ui-bg_glass_95_fef1ec_1x400.png | Bin 119 -> 0 bytes .../images/ui-bg_gloss-wave_55_5c9ccc_500x100.png | Bin 3457 -> 0 bytes .../images/ui-bg_inset-hard_100_f5f8f9_1x100.png | Bin 104 -> 0 bytes .../images/ui-bg_inset-hard_100_fcfdfd_1x100.png | Bin 88 -> 0 bytes .../redmond/images/ui-icons_217bc0_256x240.png | Bin 4369 -> 0 bytes .../redmond/images/ui-icons_2e83ff_256x240.png | Bin 4369 -> 0 bytes .../redmond/images/ui-icons_469bdd_256x240.png | Bin 4369 -> 0 bytes .../redmond/images/ui-icons_6da8d5_256x240.png | Bin 4369 -> 0 bytes .../redmond/images/ui-icons_cd0a0a_256x240.png | Bin 4369 -> 0 bytes .../redmond/images/ui-icons_d8e7f3_256x240.png | Bin 4369 -> 0 bytes .../redmond/images/ui-icons_f9bd01_256x240.png | Bin 4369 -> 0 bytes .../themes/redmond/jquery-ui-1.10.4.custom.css | 1178 -------------------- plugins/legacy_browser/composer.json | 24 - plugins/legacy_browser/js/iehacks.js | 108 -- plugins/legacy_browser/js/jquery.min.js | 4 - plugins/legacy_browser/legacy_browser.php | 112 -- plugins/legacy_browser/skins/classic/iehacks.css | 295 ----- .../skins/classic/images/abook_toolbar.gif | Bin 5753 -> 0 bytes .../skins/classic/images/mail_toolbar.gif | Bin 15356 -> 0 bytes plugins/legacy_browser/skins/larry/ie7hacks.css | 211 ---- plugins/legacy_browser/skins/larry/iehacks.css | 200 ---- .../legacy_browser/skins/larry/images/buttons.gif | Bin 14822 -> 0 bytes plugins/legacy_browser/tests/LegacyBrowser.php | 23 - plugins/managesieve/managesieve.js | 5 +- plugins/managesieve/skins/classic/managesieve.css | 9 - plugins/zipdownload/zipdownload.php | 24 +- program/include/rcmail_output_html.php | 4 +- program/js/app.js | 17 +- program/js/common.js | 9 +- program/js/jquery.min.js | 10 +- program/lib/Roundcube/README.md | 9 + program/lib/Roundcube/html.php | 5 +- program/lib/Roundcube/rcube_charset.php | 6 - program/steps/mail/compose.inc | 54 +- program/steps/mail/get.inc | 11 +- program/steps/mail/viewsource.inc | 22 +- skins/classic/functions.js | 17 +- skins/classic/splitter.js | 4 +- skins/larry/addressbook.css | 3 - skins/larry/includes/links.html | 1 - skins/larry/mail.css | 21 +- skins/larry/styles.css | 63 +- skins/larry/svggradient.php | 43 - skins/larry/svggradients.css | 185 --- skins/larry/templates/compose.html | 15 +- skins/larry/ui.js | 5 +- tests/phpunit.xml | 1 - 100 files changed, 1760 insertions(+), 3893 deletions(-) delete mode 100644 plugins/jqueryui/composer.json delete mode 100755 plugins/jqueryui/js/jquery-ui-1.10.4.custom.min.js create mode 100644 plugins/jqueryui/js/jquery-ui.min.js delete mode 100644 plugins/jqueryui/js/jquery.miniColors.min.js create mode 100644 plugins/jqueryui/js/jquery.minicolors.min.js delete mode 100755 plugins/jqueryui/themes/classic/images/animated-overlay.gif delete mode 100755 plugins/jqueryui/themes/classic/images/ui-bg_flat_0_aaaaaa_40x100.png delete mode 100755 plugins/jqueryui/themes/classic/images/ui-bg_flat_75_ffffff_40x100.png delete mode 100755 plugins/jqueryui/themes/classic/images/ui-bg_flat_90_cc3333_40x100.png delete mode 100755 plugins/jqueryui/themes/classic/images/ui-bg_glass_95_fef1ec_1x400.png delete mode 100755 plugins/jqueryui/themes/classic/images/ui-bg_highlight-hard_90_a3a3a3_1x100.png delete mode 100755 plugins/jqueryui/themes/classic/images/ui-bg_highlight-hard_90_e6e6e7_1x100.png delete mode 100755 plugins/jqueryui/themes/classic/images/ui-bg_highlight-hard_90_f4f4f4_1x100.png delete mode 100755 plugins/jqueryui/themes/classic/images/ui-icons_000000_256x240.png delete mode 100755 plugins/jqueryui/themes/classic/images/ui-icons_333333_256x240.png create mode 100644 plugins/jqueryui/themes/classic/images/ui-icons_444444_256x240.png create mode 100644 plugins/jqueryui/themes/classic/images/ui-icons_555555_256x240.png delete mode 100755 plugins/jqueryui/themes/classic/images/ui-icons_666666_256x240.png create mode 100644 plugins/jqueryui/themes/classic/images/ui-icons_777620_256x240.png create mode 100644 plugins/jqueryui/themes/classic/images/ui-icons_777777_256x240.png create mode 100644 plugins/jqueryui/themes/classic/images/ui-icons_cc0000_256x240.png delete mode 100755 plugins/jqueryui/themes/classic/images/ui-icons_cc3333_256x240.png delete mode 100755 plugins/jqueryui/themes/classic/images/ui-icons_dddddd_256x240.png create mode 100644 plugins/jqueryui/themes/classic/images/ui-icons_ffffff_256x240.png rename plugins/jqueryui/themes/classic/{jquery-ui-1.10.4.custom.css => jquery-ui.css} (67%) mode change 100755 => 100644 rename plugins/jqueryui/themes/classic/{roundcube-custom.diff => jquery-ui.css.diff} (68%) create mode 100644 plugins/jqueryui/themes/larry/images/jquery.minicolors.png delete mode 100644 plugins/jqueryui/themes/larry/images/minicolors-all.png delete mode 100644 plugins/jqueryui/themes/larry/images/minicolors-handles.gif delete mode 100644 plugins/jqueryui/themes/larry/images/ui-icons_004458_256x240.png create mode 100644 plugins/jqueryui/themes/larry/images/ui-icons_444444_256x240.png create mode 100644 plugins/jqueryui/themes/larry/images/ui-icons_555555_256x240.png create mode 100644 plugins/jqueryui/themes/larry/images/ui-icons_777620_256x240.png create mode 100644 plugins/jqueryui/themes/larry/images/ui-icons_777777_256x240.png create mode 100644 plugins/jqueryui/themes/larry/images/ui-icons_cc0000_256x240.png delete mode 100644 plugins/jqueryui/themes/larry/images/ui-icons_d7211e_256x240.png create mode 100644 plugins/jqueryui/themes/larry/images/ui-icons_ffffff_256x240.png rename plugins/jqueryui/themes/larry/{jquery-ui-1.10.4.custom.css => jquery-ui.css} (74%) mode change 100755 => 100644 rename plugins/jqueryui/themes/larry/{jquery-ui-css.diff => jquery-ui.css.diff} (77%) delete mode 100644 plugins/jqueryui/themes/larry/jquery.miniColors.css create mode 100644 plugins/jqueryui/themes/larry/jquery.minicolors.css delete mode 100755 plugins/jqueryui/themes/redmond/images/animated-overlay.gif delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-bg_flat_0_aaaaaa_40x100.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-bg_flat_55_fbec88_40x100.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-bg_glass_75_d0e5f5_1x400.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-bg_glass_85_dfeffc_1x400.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-bg_glass_95_fef1ec_1x400.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-bg_gloss-wave_55_5c9ccc_500x100.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-bg_inset-hard_100_f5f8f9_1x100.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-bg_inset-hard_100_fcfdfd_1x100.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-icons_217bc0_256x240.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-icons_2e83ff_256x240.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-icons_469bdd_256x240.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-icons_6da8d5_256x240.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-icons_cd0a0a_256x240.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-icons_d8e7f3_256x240.png delete mode 100755 plugins/jqueryui/themes/redmond/images/ui-icons_f9bd01_256x240.png delete mode 100755 plugins/jqueryui/themes/redmond/jquery-ui-1.10.4.custom.css delete mode 100644 plugins/legacy_browser/composer.json delete mode 100644 plugins/legacy_browser/js/iehacks.js delete mode 100644 plugins/legacy_browser/js/jquery.min.js delete mode 100644 plugins/legacy_browser/legacy_browser.php delete mode 100644 plugins/legacy_browser/skins/classic/iehacks.css delete mode 100644 plugins/legacy_browser/skins/classic/images/abook_toolbar.gif delete mode 100644 plugins/legacy_browser/skins/classic/images/mail_toolbar.gif delete mode 100644 plugins/legacy_browser/skins/larry/ie7hacks.css delete mode 100644 plugins/legacy_browser/skins/larry/iehacks.css delete mode 100644 plugins/legacy_browser/skins/larry/images/buttons.gif delete mode 100644 plugins/legacy_browser/tests/LegacyBrowser.php delete mode 100644 skins/larry/svggradient.php delete mode 100644 skins/larry/svggradients.css
Roundcube Users mailing list users@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/users
On 08/20/2016 11:08 PM, Michael Heydekamp wrote:
Apparently due to the commit quoted below, I (and not only me) can't send mail with 1.3-git anymore. I'm seeing a huge attachment window area, but no editor window area where I could enter any text.
Would it be possible to test at least this particular function before committing? Composing and sending a message is quite an essential feature of a webmail client. ;)
Well, that's not a production branch.
Works for me in Firefox and Chrome. What browser (and version), what skin, what plugins?
Please, note that we dropped support for IE<10.
Am 21.08.2016 11:52, schrieb A.L.E.C:
On 08/20/2016 11:08 PM, Michael Heydekamp wrote:
Apparently due to the commit quoted below, I (and not only me) can't send mail with 1.3-git anymore. I'm seeing a huge attachment window area, but no editor window area where I could enter any text.
Would it be possible to test at least this particular function before committing? Composing and sending a message is quite an essential feature of a webmail client. ;)
Well, that's not a production branch.
But I'm using it as my production branch for a long while already, because I have to: Some things do not work (or work different) in the stable version - e.g. the identity selection when I reply to this or any other Roundcube list. The default identity is chosen in the stable version rather than the list identity. Probably because the stable version doesn't support the X-Envelope-To and/or the additional Delivered-To header which we add as the very last header upon arrival, I assume...
Works for me in Firefox and Chrome. What browser (and version), what skin, what plugins?
Win10/64 Pro, FF 42.0, Classic Skin, Plugins see below:
This is what I get when I reply to your message with 1.3-git:
BTW: The second message of last night should have gone to the dev-list, but although the address was correct this time, it againt went to the users list.
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On 08/21/2016 04:05 PM, Michael Heydekamp wrote:
But I'm using it as my production branch for a long while already, because I have to: Some things do not work (or work different) in the stable version - e.g. the identity selection when I reply to this or any other Roundcube list. The default identity is chosen in the stable version rather than the list identity. Probably because the stable version doesn't support the X-Envelope-To and/or the additional Delivered-To header which we add as the very last header upon arrival, I assume...
I don't see a change in master that would be related to this and not in release-1.2 branch.
Works for me in Firefox and Chrome. What browser (and version), what skin, what plugins?
Win10/64 Pro, FF 42.0, Classic Skin, Plugins see below:
Did you check browser error console? Maybe some external plugin is not compatible with new version of jQuery/jQuery-UI.
Am 21.08.2016 19:02, schrieb A.L.E.C:
On 08/21/2016 04:05 PM, Michael Heydekamp wrote:
But I'm using it as my production branch for a long while already, because I have to: Some things do not work (or work different) in the stable version - e.g. the identity selection when I reply to this or any other Roundcube list. The default identity is chosen in the stable version rather than the list identity. Probably because the stable version doesn't support the X-Envelope-To and/or the additional Delivered-To header which we add as the very last header upon arrival, I assume...
I don't see a change in master that would be related to this and not in release-1.2 branch.
I don't know, but as a matter of fact, identity selection doesn't work for me in the stable version - while it does in 1.3-git. I have to change the
From address manually.
I also just noticed that a reply to an own message is also not correctly detected in the stable version - while it is in 1.3-git.
But I also just noticed that we're still using 1.0.9 as stable version. I'll have to bug my main admin. ;) Personally, I didn't care that much for the stable version.
Works for me in Firefox and Chrome. What browser (and version), what skin, what plugins?
Win10/64 Pro, FF 42.0, Classic Skin, Plugins see below:
Did you check browser error console? Maybe some external plugin is not compatible with new version of jQuery/jQuery-UI.
Will revert asap to this.
I believe I did ask that before: Is there no way to make sure that all plugins will be compatible with a new commit? Are the plugin developers made aware at all of such significant changes?
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On 08/22/2016 12:57 AM, Michael Heydekamp wrote:
I believe I did ask that before: Is there no way to make sure that all plugins will be compatible with a new commit? Are the plugin developers made aware at all of such significant changes?
Plugin authors have beta releases, changelog and time to update their plugins. Sometimes we keep backward compatibility for some time, but it would be hard for changes like this one.
Am 21.08.2016 19:02, schrieb A.L.E.C:
Did you check browser error console? Maybe some external plugin is not compatible with new version of jQuery/jQuery-UI.
Debugging didn't work, but disabling one by one, we've now detected 'contextmenu' as the dusturbing plugin. An update to 2.1-git solved the problem.
I'm wondering how this could be automated...
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany