Dev January 2006

dev@lists.roundcube.net

76 participants
79 discussions

Updated bosnian translation
by Begzudin Omerovic 21 Jan '06

21 Jan '06

Hi, here comes the updated version of the bosnian translation, now in utf-8. Put this files in the bs_BA directory and please add in the index.inc file (program/localization/ directory) $rcube_languages = array( 'bs_BA' => 'Bosnian (Bosanski)' and $rcube_language_aliases = array( 'bs' => 'bs_BA', Regards, -- Begzudin Omerovic www.oglasi.com

1 0

Pbs with the french version
by Contact 20 Jan '06

20 Jan '06

I'll try to speak english, but.... I have a problem with french version : when i have some accent in my message, it will not appear. exemple : Concernant la r?n?tion, l'agence est commissionn?áuteur de 0.5 % ±%. Comme convenu lors de la r?ion, 40 % TTC seront revers?directement ìa personne qui a prescrit. in stade of Concernant la rémunération, l'agence est commissionnée à auteur de 0.5 % à 1%. Comme convenu lors de la réunion, 40 % TTC seront reversés directement à la personne qui a prescrit. I have verify the source of the mail and it was correct Some one could help me ?

2 1

Next release?
by John Galt 20 Jan '06

20 Jan '06

What's the ETA on the next release?

2 1

%u not parsing during SMTP authentication.
by Kevin Landers 20 Jan '06

20 Jan '06

Hi list, I am currently using the CVS from the first week of January. In my config file I use the following pieces of code to generate a login based upon what domain a user is accessing round cube from. // the mail host chosen to perform the log-in // leave blank to show a textbox at login, give a list of hosts // to display a pulldown menu or set one host as string. // To use SSL connection, enter ssl://hostname:993 $rcmail_config['default_host'] = 'mail.' . '' . str_replace("www.", "", $_SERVER['HTTP_HOST']); (This allows me to accept just the user name in the login screen and use this install across different domains.) I then do the same for the SMTP server. // use this host for sending mails. // to use SSL connection, set ssl://smtp.host.com // if left blank, the PHP mail() function is used $rcmail_config['smtp_server'] = 'mail.' . '' . str_replace("www.", "", $_SERVER['HTTP_HOST']); (This contacts the SMTP of the domain being accessed.) Next, our SMTP server requires that the user specify their full email address as their user name. In round cube I have been making this happen automatically by using the following code: // SMTP username (if required) if you use %u as the username RoundCube // will use the current username for login $rcmail_config['smtp_user'] = '%u' . '@' . '' . str_replace("www.", "", $_SERVER['HTTP_HOST']); It has been working so that it takes the domain, converts it to @domain.com and then adds the user's name before the @ symbol. However, upon using the CVS version, I am now showing in my SMTP-Auth logs that it is trying to login as %u(a)domain.com instead of username(a)domain.com Any ideas as to why this is no longer working? I am in the midst of updating to the newest CVS. I am just affraid that that is not going to be the problem. Round Cube's error log shows the following: [17-Jan-2006 12:27:58 -0500] SMTP Error: SMTP error: authentication failure in /domain.com/www/roundcube/program/steps/mail/sendmail.inc on line 216 Thanks in advance, Kevin L.

2 2

what's the current status for a serious release?
by sdk 20 Jan '06

20 Jan '06

Something comparable to Squirrelmail or Gmail? I work for an ISP and we are looking to move away from Squirrelmail. Thx, sdk

3 2

Re: shift-select and control-select patch
by Charles McNulty 20 Jan '06

20 Jan '06

Sorry about that. I just retried it and got the same problems. Try this one. I created the one I sent earlier with cvs diff. This one was created with Tortoise with whatever default options it throws into the bag. This one works fine with the latest CVS (1.27 of app.js, I believe.) Good luck. -Charles Daniel Paquet wrote: > Is the patch work with a freshly cvs'ed source? > > The patch is failing for me. With error > > patching file app.js > Hunk #3 FAILED at 1006. > Hunk #5 FAILED at 1043. > Hunk #6 FAILED at 1052. > Hunk #7 succeeded at 1048 (offset -25 lines). > Hunk #8 FAILED at 1053. > Hunk #9 succeeded at 1064 (offset -111 lines). > Hunk #10 succeeded at 1081 (offset -111 lines). > Hunk #11 succeeded at 2762 (offset -111 lines). > 4 out of 11 hunks FAILED -- saving rejects to file app.js.rej > > > Index: program/js/app.js =================================================================== RCS file: /cvsroot/roundcubemail/roundcubemail/program/js/app.js,v retrieving revision 1.27 diff -u -r1.27 app.js --- program/js/app.js 13 Jan 2006 17:14:38 -0000 1.27 +++ program/js/app.js 19 Jan 2006 05:23:23 -0000 @@ -13,6 +13,10 @@ $Id: app.js,v 1.27 2006/01/13 17:14:38 roundcube Exp $ */ +// Constants +var CONTROL_KEY = 1; +var SHIFT_KEY = 2; +var CONTROL_SHIFT_KEY = 3; var rcube_webmail_client; @@ -997,11 +1001,30 @@ if (this.dont_select) return false; + // selects currently unselected row if (!this.in_selection_before) - { - var ctrl = this.check_ctrlkey(e); - this.select(id, ctrl); + { + var mod_key = this.get_modifier(e); + if (!mod_key) { + this.select(id, false); + this.last_selected = id; + } else { + switch (mod_key) { + case SHIFT_KEY: { this.shift_select(id,false); break; } + case CONTROL_KEY: { + this.select(id, true); + this.last_selected = id; + break; + } + case CONTROL_SHIFT_KEY: { this.shift_select(id,true); break;} + default: { + this.select(id, false); + this.last_selected = id; + break; + } + } } + } if (this.selection.length) { @@ -1017,7 +1040,7 @@ // onmouseup-handler of message list row this.click_row = function(e, id) { - var shift = this.check_shiftkey(e); + var mod_key = this.get_modifier(e); // don't do anything (another action processed before) if (this.dont_select) @@ -1026,16 +1049,33 @@ return false; } - if (!this.drag_active && this.in_selection_before==id) - { - this.select(id, (shift && this.task!='settings')); + // unselects currently selected row + if (!this.drag_active && this.in_selection_before==id) { + if (!mod_key) { + this.last_selected = id; + this.select(id, false); + } else { + switch (mod_key) { + case SHIFT_KEY: { this.shift_select(id,false); break; } + case CONTROL_KEY: { + this.last_selected = id; + this.select(id, (this.task!='settings')); + break; + } + case CONTROL_SHIFT_KEY: {this.shift_select(id,true);break;} + default: { + this.select(id, false); + this.last_selected = id; + break; + } + } } - + } this.drag_start = false; this.in_selection_before = false; // row was double clicked - if (this.task=='mail' && this.list_rows && this.list_rows[id].clicked && !shift) + if (this.task=='mail' && this.list_rows && this.list_rows[id].clicked) { this.show_message(id); return false; @@ -1132,7 +1172,6 @@ this.selection = a_pre.concat(a_post); this.set_classname(this.list_rows[id].obj, 'selected', false); } - selected = (this.selection.length==1); } @@ -1150,6 +1189,28 @@ }; +// select all rows from the last selected row to the current one, while deselecting all other rows + this.shift_select = function(id,control) + { + var from_rowIndex = this.list_rows[this.last_selected].obj.rowIndex; + var to_rowIndex = this.list_rows[id].obj.rowIndex; + + var i = ((from_rowIndex < to_rowIndex)? from_rowIndex : to_rowIndex); + var j = ((from_rowIndex > to_rowIndex)? from_rowIndex : to_rowIndex); + + // iterate through the entire message list + for (var n in this.list_rows) { + if ((this.list_rows[n].obj.rowIndex >= i) && (this.list_rows[n].obj.rowIndex <= j)) { + if (!this.in_selection(n)) + this.select(n, true); + } else { + if (this.in_selection(n) && !control) + this.select(n, true); + } + } + }; + + this.clear_selection = function() { for(var n=0; n<this.selection.length; n++) @@ -2809,6 +2870,26 @@ return false; } + +// returns modifier key (constants defined at top of file) + this.get_modifier = function(e) + { + var opcode = 0; + if (e = e || window.event) + { + opcode += (e.ctrlKey && CONTROL_KEY) + (e.shiftKey && SHIFT_KEY); + return opcode; + } + if (e.cancelBubble) + { + e.cancelBubble = true; + e.returnValue = false; + } + else if (e.preventDefault) + e.preventDefault(); + } + + this.get_mouse_pos = function(e) { if(!e) e = window.event;

3 3

stability of CVS
by Jon Daley 19 Jan '06

19 Jan '06

Hi. This looks like an excellent piece of software. I have shown it to a couple people who care about design sorts of things, and they were quite impressed. I see the don't-use-the-cvs-version-unless-you-want-to-have-broken-email warning on the sourceforge page, and I am wondering how much you mean it. (: I am willing to put up with some instability, but I want it to work most of the time. Should I stick with the official releases? I am familiar with cvs (and svn - glad to hear that you are converting over sometime soon) and comfortable working on code. Do you have a suggestion? -- Jon Daley http://jon.limedaley.com/

6 5

5 features worth implementing?
by Sjon 19 Jan '06

19 Jan '06

After loosing an important mail composed under Roundcube (just pushed the send-button, 'something' went wrong and the email was lost forever) I have thought of ideas to avoid this. I think the following might be feasible: currently mails are send in the background; a failure means the message disappears. Might it be an idea not to use an AJAX backgrounded thread for sending the email, but staying on the foreground; only to return to the inbox once the message has succesfully been send? Some other stuff I thought of: * move the current overflow-scrollbar style from the table to the tbody. This would leave the thead always visible, while currently it will disappear when scrolling * make the attachment-icon (singleclick) in the messagelisting jump directly to the message-attachment. Currently it is just an icon without any link * a javascript prompt before any actual delete action, for example in the addressbook page * could we merge the _auth (GET) and sessid (COOKIE) into 1 sessionID? Comments welcome :) Regards, Sjon

9 11

shift-select and control-select patch
by popquizh＠popquizhotshot.com 19 Jan '06

19 Jan '06

I tried sending this message with RoundCube, but I don't think the attachment was working. Anyway, this patch changes the control-select and shift-select behavior for lists to emulate that of standard windows applications (or at least Outlook and Thunderbird which is what I tested it against). Please give it a try and let me know how it turns out. Also let me know if any further steps need to be taken to have this patch considered for merge into the main code. -Charles

4 5

Re: public ldap search features implemented
by justin randell 18 Jan '06

18 Jan '06

hi pieter, thanks for the feedback :-) > I've found one bug! When there is only one server, the server-dropdown > list is not displayed. This is fine. But, the javascript filling the > searchfield requires this dropdownlist! So, when there is only one > server, the searchfields are not filled and the searchfunction does > not work!! good catch - fix committed to cvs. > Another thing that confused me, was the $rcmail_config['ldap_public'] > config. The default value is false. But I wanted to enable it, so I > set it to true. But this doesn't work. It appears that you can set it > to false for disabling it, OR specify servers to enable it. I know > this is just the way PHP works, but it did confuse me... Maybe a > better way, to solve this, is not specify the > $rcmail_config['ldap_public'] = false; option in the default config, > and that this option is disabled because there aro no servers defined. or just add a note explaining that in the config file? i don't mind either way. what do others think? > Few suggestions: > * Could the interface be more integrated with the > addressbookinterface? (Listing the results on the left) there's a good chance that most of the results returned from a search of a large public ldap server wont be of any interest (eg - typing 'justin' to get my details from our public ldap server returns 11 results, only one of which is me), so automatically adding all results to the list on the left is probably not going to be that useful. i think its better to make it easy to act on the returned results (add to private addressbook or compose mail to) rather than just add them to the list on the left. its likely that i'm just missing a better way to do it, so i'd be happy if someone could suggest how to get around problems like the one above. > * Could there be a "List all" option? if the ldap server you are hitting will give you a list of all contacts. this will not be possible for all servers though, and could return very large results, so we would need to page them. do other people want this as well? > * I do no realy like the Searchfield dropdown. Could there be an > option so that automaticly all fields are searched? yep, we could even have it so that this is configurable by admins - they can have a choice, or they can set it to automatically search all fields. i'm prepared to implement that if people think it would be useful. what do others think? > * The searchfields could use aliasses... could you give me more detail on this point? > * Optional integration with the Autocompletion feature would be great! this is a tricky one, because the autocomplete works on a javascript array, not by sending keystrokes over the network. i think that the autocomplete would be too slow (even on a quick setup) if it wasn't operating on an in-memory array. as soon as any returned results are added to the private addressbook, they are available in the autocomplete for composing mail. one thing that occurred to me: maybe we should make an autocomplete for the private addressbook available in the contacts page. what do other people think? again, thanks for the feedback. justin

3 4

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev January 2006