Dev

dev@lists.roundcube.net

2 participants
4318 discussions

PHP openssl_pkcs7_decrypt BUG
by Kyle Francis 06 Oct '16

06 Oct '16

So it appears as though there is a bug in decrypting emails when using . It appears as though the error only surfaces (sometimes) when decrypting with the sender's credentials. This leads to some, not all, messages not being able to be decrypted from the "Sent" folder in Roundcube. The emails that cannot be decrypted from the "Sent" folder are successfully decrypted when viewing in Thunderbird (either from the recipients account or the sender's account). This tells me the bug is with the php function openssl_pkcs7_decrypt. The same email is also not able to be decrypted utilizing openssl from the command line. All emails successfully decrypt with gpgsm. I could do one of two things: 1. Decrypt utilizing gpgsm, keep openssl_pkcs7_* functions for everything else and attempt to fix/submit patch for openssl[_pkcs7_decrypt] function at a later date. Pro - least amount of re-work could make it into an upcoming beta Con - "messy"/fragmented solution 2. Re-write all openssl_pkcs7_* PHP functions to utilize gpgsm Pro - unified, "clean" solution gpgsm integrates with gpg for public/private key storage decrypted emails would never be written to file Con - extensive rework Probably won't make the next beta Importing pkcs12 files into keyrings is currently "messy" and would still require use of openssl_pkcs7 function for certificate manipulation I'd really like to see this feature be wrapped up, but I also want to do it right. Thoughts? -Kyle

2 1

Update 1.2.2 and 1.1.6 released
by A.L.E.C 30 Sep '16

30 Sep '16

Dear subscribers We just published updates to both stable versions 1.2 and 1.1 delivering important bug fixes and again more improvements of the Enigma plugin introduced in version 1.2. Version 1.1.6 comes with cherry-picked fixes from the more recent version and improvements in contacts searching as well as a few localization fixes. See the full changelog in the wiki [1] and the selection for 1.1.6 on the release page [2]. Both versions are considered stable and we recommend to update all productive installations of Roundcube with either of these versions. Download them from GitHub via https://roundcube.net/download. As usual, don’t forget to backup your data before updating! Best, Alec [1] https://github.com/roundcube/roundcubemail/wiki/Changelog#release-122 [2] https://github.com/roundcube/roundcubemail/releases/tag/1.1.6

1 0

GB2312 and ISO-2022-KR
by Vladimir Gorpenko 29 Sep '16

29 Sep '16

Hello. Sometimes to me letters in such charsets come. No, I don't correspond with Chinese or Koreans. But someone writes on cyrillic using these charsets. These codings, as well as UTF-8, allow to mix characters of different national alphabets, including Latin and cyrillic in the letter. Some e-mail clients work with this coding normally. As far as I can judge, RC 1.1.4 doesn't support these codings. Whether there is a support of these codings in the latest version of RC? Whether it is planned to add it to next versions? Most likely, I should add it to RC 1.1.4 urgently. I will be grateful if to me help to find places where different codings for a letter body, both HTML, and the text are processed. I found processing of codings in titles recently. If it is interesting to someone, I am ready to transfer results of this work. -- Best regards, Vladimir Gorpenko

5 10

Enigma hybrid decryption
by Kyle Francis 28 Sep '16

28 Sep '16

Hey everyone, So I'm mostly finished with the implementation of the hybrid decryption model. So far I have the following working: enigma.js calls a mailvelope API I added for decrypting session key out of a PGP message - decrypted session key and PGP message get posted (over https) back to the enigma plugin enigma.php catches posted data and decrypts PGP message with session key - modified Crypt_GPG to additionally utilize GPG's "--override-session-key" So I can write the decrypted email to a file on the server, but I'd like to replace the body of the email and reload. When doing this while decrypting S/MIME it was simple since the replacing occurred before the message was completely loaded and rendered out as html. Is there any way to replace the body (and subsequently parse the body structure) after all the plugin hooks have run? I tried calling exec_hook for message_part_body, but as far as I can tell I would need to pass the rcube_message object as an argument to do this but I don't have access to it. Any thoughts would be greatly appreciated. -Kyle

7 29

GB2312, ISO-2022-KR
by Vladimir Gorpenko 27 Sep '16

27 Sep '16

Something managed to be clarified. Perhaps, it will be interesting. If you remember, I have two servers, will call them W and T. T normally opens letters in these codings, W shows something like the Arab characters. 1. In case of conversion of the codings RC at first tries to use iconv. As iconv(php) is an interface to the linux utility iconv, it doesn't work at the server W where chroot is used. On the T server iconv transforms both of these codings normally. 2. In the second queue RC tries to apply mbstring to conversion of codings. Mbstring, apparently, doesn't understand GB2312 (GBK), but understands ISO-2022-KR. Nevertheless, mbstring also doesn't work at W server. I think, the reason is also somehow connected to chroot. I suppose, RC has problems with different codings by operation under chroot. Though I still hope to set up operation of iconv and mbstring. -- Best regards, Vladimir Gorpenko

4 13

Re: [RCD] Plugin - AJAX GET request to cross domain
by Thomas Bruederli 26 Sep '16

26 Sep '16

On Wed, Sep 21, 2016 at 3:03 AM, Joogl <jooglnetz(a)posteo.uk> wrote: > Thank you Thomas, Please try to reply to the mailinglist and not to me privately. Otherwise you might wait for days until you get a response :-) > > I very appreciate it. > Since I have to query an external API, I am calling it with cURL. > But whenever I do this, I get an Internal Server Error Message. But I > can't find any logs about it. When I try it in my local workspace, > everything works fine. > Does Roundcube forbid cURL? Roundcube does not forbid anything. curl needs to be installed with PHP on your server. Fatal errors are logged into Roundcube's error log or the error log file of your webserver. ~Thomas > function sendCurl($url) > { > $ch = curl_init($url); > $curlResult["msg"] = curl_exec($ch); > $curlResult["http"] = curl_getinfo($ch, CURLINFO_HTTP_CODE); > curl_close($ch); > return $curlResult; > } > > Am 18.09.2016 um 23:20 schrieb Thomas Bruederli: >> On Sun, Sep 18, 2016 at 10:53 AM, Joogl <jooglnetz(a)posteo.uk> wrote: >>> Thanks a lot Thomas, >>> was not too hard to be honest. >>> >>> But I still have problems with my values I want to transfer. >>> Do I really have to use $_POST? I mean, for what reason do I have the >>> $args variable? >> >> Actually, the $args variable is empty in this case. >> In order to access request data, you should use the dedicated function [1]: >> >> rcube_utils::get_input_value('someparam', rcube_utils::INPUT_GPC); >> >> This does proper input sanitization like html tag stripping and >> charset conversion. >> Use rcube_utils::INPUT_GET or rcube_utils::INPUT_POST to access GET or >> POST parameters specifically. >> >> Regards, >> Thomas >> >> >> [1] https://github.com/roundcube/roundcubemail/blob/master/program/lib/Roundcub… >> >> >>> Am 17.09.2016 um 00:56 schrieb Thomas Bruederli: >>>> On Mon, Sep 12, 2016 at 11:21 AM, Jakob Bachhuber <jakob-b(a)posteo.de> wrote: >>>>> [...] >>>>> >>>>> Of course, I have read the documentation. I also analysed some other >>>>> plugins, but it is still just random guessing for me. >>>> >>>> The relevant part for you is probably here: >>>> https://github.com/roundcube/roundcubemail/wiki/Plugin-API#ajax-requests-an… >>>> >>>>> In my php I do: >>>>> $this->register_action('plugin.someaction', array($this, 'actions')); >>>>> >>>>> and >>>>> >>>>> function actions($args) >>>>> { >>>>> echo '<script type="text/javascript">alert("' . $args . >>>>> '")</script>'; >>>>> echo '<script type="text/javascript">alert("' . $args['value'] . >>>>> '")</script>'; >>>>> $this->rc->ouput->send(); >>>>> } >>>> >>>> The way to pass data back to the client is not using `echo` but send >>>> it a "command" for which your plugin has already registered an event >>>> listener: >>>> >>>> $rcmail->output->command('plugin.somecallback', $args); >>>> >>>> Makes sense? >>>> >>>> ~Thomas >>>>

1 0

GB2312, ISO-2022-KR and other problems
by Vladimir Gorpenko 23 Sep '16

23 Sep '16

First, I am not sure now that the problem with GB2312 was on a test server before reload of system. Perhaps, it always worked correctly. In any case, it has no errors log. On the work server the error log present. As I understand, the record [23-Sep-2016 10:48:49 Europe/Moscow] PHP Notice: No suitable function found for UTF-8 encoding in /var/www/html/mail/program/lib/Roundcube/rcube_charset.php on line 276 has a direct bearing on my problems with G2312. What does it mean? Secondly, on this server in a log there is a group of the errors relating to spell-checker. [23-Sep-2016 10:24:05 Europe/Moscow] PHP Warning: fsockopen(): SSL operation failed with code 1. OpenSSL Error messages: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed in /var/www/html/mail/program/lib/Roundcube/rcube_spellcheck_googie.php on line 87 [23-Sep-2016 10:24:05 Europe/Moscow] PHP Warning: fsockopen(): Failed to enable crypto in /var/www/html/mail/program/lib/Roundcube/rcube_spellcheck_googie.php on line 87 [23-Sep-2016 10:24:05 Europe/Moscow] PHP Warning: fsockopen(): unable to connect to ssl://spell.roundcube.net:443 (Unknown error) in /var/www/html/mail/program/lib/Roundcube/rcube_spellcheck_googie.php on line 87 Thirdly, after the Linux updating RC ceased to work at the work server. More precisely, the authentication page opens and works normally. The wrong password is processed normally. But after input of the correct password the RC page doesn't open, and the browser (Chrome) reports ERR_EMPTY_RESPONSE. In the RC error log there is no diagnostics about it. I will be grateful for any consultations on search of the reasons of this failure. Updating of Linux was very big. One more question which doesn't have a direct relation on RC, but here are specialists in e-mail. Perhaps, somebody will be so kind that he will answer. In case of attachment of the file in the letter the title in which cyrillic is encoded quite peculiar is created. Content-Disposition: attachment; filename*0*=UTF-8''%D0%9E%D1%82... I can't find the function which is realizing such coding or descriptions of the standard. I just don't know that I should look for. How this coding is named? -- Best regards, Vladimir Gorpenko

2 5

Re: [RCD] Plugin - AJAX GET request to cross domain
by Thomas Bruederli 18 Sep '16

18 Sep '16

On Sun, Sep 18, 2016 at 10:53 AM, Joogl <jooglnetz(a)posteo.uk> wrote: > Thanks a lot Thomas, > was not too hard to be honest. > > But I still have problems with my values I want to transfer. > Do I really have to use $_POST? I mean, for what reason do I have the > $args variable? Actually, the $args variable is empty in this case. In order to access request data, you should use the dedicated function [1]: rcube_utils::get_input_value('someparam', rcube_utils::INPUT_GPC); This does proper input sanitization like html tag stripping and charset conversion. Use rcube_utils::INPUT_GET or rcube_utils::INPUT_POST to access GET or POST parameters specifically. Regards, Thomas [1] https://github.com/roundcube/roundcubemail/blob/master/program/lib/Roundcub… > Am 17.09.2016 um 00:56 schrieb Thomas Bruederli: >> On Mon, Sep 12, 2016 at 11:21 AM, Jakob Bachhuber <jakob-b(a)posteo.de> wrote: >>> [...] >>> >>> Of course, I have read the documentation. I also analysed some other >>> plugins, but it is still just random guessing for me. >> >> The relevant part for you is probably here: >> https://github.com/roundcube/roundcubemail/wiki/Plugin-API#ajax-requests-an… >> >>> In my php I do: >>> $this->register_action('plugin.someaction', array($this, 'actions')); >>> >>> and >>> >>> function actions($args) >>> { >>> echo '<script type="text/javascript">alert("' . $args . >>> '")</script>'; >>> echo '<script type="text/javascript">alert("' . $args['value'] . >>> '")</script>'; >>> $this->rc->ouput->send(); >>> } >> >> The way to pass data back to the client is not using `echo` but send >> it a "command" for which your plugin has already registered an event >> listener: >> >> $rcmail->output->command('plugin.somecallback', $args); >> >> Makes sense? >> >> ~Thomas >>

1 0

Widescreen layout (three column view) is coming to you
by A.L.E.C 17 Sep '16

17 Sep '16

I just pushed "layout modes" change into dev-layouts branch. This is an implementation of three column view for mail UI. This is a BC breaking change. So, if you're an author of a skin or a plugin that modifies the messages list, you'll most likely have to do some modifications of your code. You can also just start beta-testing of this change, so it will be ready for 1.3-beta release. Have fun! https://kolabian.wordpress.com/2016/09/17/widescreen-layout-aka-three-colum… -- Aleksander 'A.L.E.C' Machniak Kolab Groupware Developer [http://kolab.org] Roundcube Webmail Developer [http://roundcube.net] ---------------------------------------------------- PGP: 19359DC1 # Blog: https://kolabian.wordpress.com

1 0

What can be reached, changing skin?
by Vladimir Gorpenko 16 Sep '16

16 Sep '16

I wasn't engaged in development of skins for RC yet. Before being engaged in it, I would like to understand what results can be received. Whether it is possible to change configuration of the screen? To make RC more convenient for operation from the smartphone? It seems, someone advertized the paid skins intended for this purpose. So it is possible? And maybe, the decision of this task already exists? I know the program RoundCube for Android which not bad adapts the interface. Though it is not absolutely correct. And for iOS such program is? -- Best regards, Vladimir Gorpenko

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev