Dev

dev@lists.roundcube.net

2 participants
4318 discussions

Re: Improving cache algorithm
by DrSlump 09 Oct '05

09 Oct '05

Mark Mackay - Orcon wrote: > Hi Ivan - > > I tried this new function, and I think there may be a problem with it (or my > PHP installation, etc). > Roundcube refused to present the login page with this pasted in: > > Running "php4 rcube_imap.inc" produced: > > Parse error: parse error, unexpected T_OBJECT_OPERATOR in > /var/www/roundcube/program/include/rcube_imap.inc on line 321 > > The offending lines were: > > //check for changes using the UID > if ($hdr->uid === end($a_out)->uid) > $revalidate = false; > > It worked when I commented these out, but obviously this skipped the > comparison of the last UID. > Thanks Mark for the bug report, I'm using PHP5 so I guess PHP4 is complaining about the "end($a_out)->uid" bit. Just replace that lines with this ones: $lastCacheHdr = end($a_out); if ($hdr->uid === $lastCacheHdr->uid) $revalidate = false; ciao, ivan

1 0

Improving cache algorithm
by DrSlump 08 Oct '05

08 Oct '05

Hi, I've been reading the IMAP specification to find ways to improve current rcube cache algorithms. The following is from the IMAPv4 specs: 2.3.1.2. Message Sequence Number Message Attribute A relative position from 1 to the number of messages in the mailbox. This position MUST be ordered by ascending unique identifier. As each new message is added, it is assigned a message sequence number that is 1 higher than the number of messages in the mailbox before that new message was added. Currently rcube stores the whole header list for each mailbox in the DB. If the current message count is bigger than the message count of the cache then it fetches the whole header list again and stores it in the cache on DB. I think this could be improved by redesigning the caching algorithm, since each new message in a mailbox is given a sequence number higher than the other ones, we can just fetch the new messages. The following code should clarify the idea: $mbox_count = messagecount($mbox); $cache_count = count($cache); if ($mbox_count > $cache_count) { $newMessages = iil_C_FetchHeaders( $conn, $mbox, "$cache_count:$mbox_count" ); $cache = array_merge( $cache, $newMessages ); } Unfortunatly the specs also say: Message sequence numbers can be reassigned during the session. For example, when a message is permanently removed (expunged) from the mailbox, the message sequence number for all subsequent messages is decremented. The number of messages in the mailbox is also decremented. Similarly, a new message can be assigned a message sequence number that was once held by some other message prior to an expunge. We can solve this however since we have the UID of each header in the cache. Instead of fetching the (mbox_count - cache_count) headers, we can fetch (mbox_count-cache_count)+1, with this we should get as the first header the last one in the cache. We then compare its UID, so if we have in the cache the last header with id=269 and uid=468 but in the new list it has the id=269 but the uid=493 it means that there have been deleted messages in that folder and that we must revalidate the whole list. This could also be optimized but it'll require a quite complex algorithm which I guess is not worth it for most cases. The following pseudo-code should show the idea good enough: $mbox_count = messagecount($mbox); $cache_count = count($cache); if ($mbox_count > $cache_count) { $newMessages = iil_C_FetchHeaders( $conn, $mbox, ($cache_count-1).":$mbox_count" ); if ($newMessages[0]->uid != end($cache)->uid) { //revalidate the cache $cache = iil_C_FetchHeaders( $conn, $mbox, "0:".($cache_count-1)); } $cache = array_merge( $cache, $newMessages ); } The code I think is simple enough although I would like to discuss this before trying its implementation, I'm worried about the specs support in different servers. ciao, ivan

1 1

fix for error on bad time parameter in message
by joshua 08 Oct '05

08 Oct '05

Hi all, I've been getting this error (only on my inbox - apparently somebody sent me a message with a bad time parameter (empty)) Warning: strtotime() [function.strtotime]: Called with an empty time parameter. in /opt/web/devmail/roundcubemail/program/include/main.inc on line 896 the fix is really simple, but I don't have CVS commit access, so... <originalCode lines 893-896> if (is_numeric($date)) $ts = $date; else $ts = strtotime($date); </originalCode> <replacementCode> if (is_numeric($date)) $ts = $date; else if (strlen($date)) $ts = strtotime($date); else $ts = ''; </replacementCode> There are probably more elegant ways to do this, but it works. HTH, j.

2 1

resolved -- Fwd: Re: anyone having problems with SMTP auth?
by joshua 08 Oct '05

08 Oct '05

Perhaps this was my error originally, but regardless, with the new (20051007) build, SMTP auth is working correctly for me. regards, j. -------- Original Message -------- Subject: Re: anyone having problems with SMTP auth? Date: Sat, 08 Oct 2005 10:29:37 -0700 From: Joshua Layne <joshua(a)willowisp.net> To: "dev(a)lists.roundcube.net" <dev(a)lists.roundcube.net> I was able to get SMTP to work be specifying localhost (I allow relaying from localhost), but am unable to get the authorization aspect to work (I'll try again with the new build). I was using the domain name 'willowisp.net' with SMTP authorization. works in other clients, so I don't think it is a server problem. anyway, I'll try in the new version and report back. on a totally different note, has anyone put together a cookie monster to clear session info? I am finding that occasionally I enter a hung state that can only be fixed by dropping the session and logging in again. Also, my previous comments were 'pie in the sky' thinking - I think roundcube is the slickest email client i have ever used - great work. j. Geoffrey McCaleb wrote: >It works for me when enabled. > >Quick question, what do you have smtp_server set to? Localhost, local IP >(e.g. 127.x.x.x), or the hostname? > >Geoffrey > >On 10/8/2005, "Joshua Layne" <joshua(a)willowisp.net> wrote: > > > >>Hi all, >>My SMTP auth works fine with Mozilla thunderbird (using system account), >>but fails with a: >> >>*SMTP Error in /opt/web/roundcube/program/steps/mail/sendmail.inc >>(179):* Connection failed: 554 : Relay access denied >> >>No valid recipients >> >>in roundcube. Anyone else running into this problem? Have workarounds? >> >>I have my SMTP domain, username and password set in the config file - >>seems like it could be nice to have this keyed off of the end-users >>username:password also, is there any way to store these in the session >>and pull them out for this purpose, or is that generally frowned upon? >>(I always want to do this for "single sign on" across my various PHP >>apps anyway) >> >>thanks for any info, >>j. >> >> > > > >

1 0

RE: 0.1-20051007 Comments/feedback
by Geoffrey McCaleb 08 Oct '05

08 Oct '05

Just to make sure the rest of the group got to see Mark's reply (see below). To add my own comment to Mark's reply: While I am by no means a javascript guru, I don't believe it is possible for javascript to affect the local PC. The cursor icon, is controlled by the core API of whatever OS you happen to be running (OSX, Windows Shell, KDE, etc). Web scripting, generally doesn't have access to that API (with the exception of ActiveX). I wonder if instead of changing the cursor, you could certainly have some help text appear to help guide the user to the correct action. Though, from a usability perspective, you are correct web users expect to single click to open mail or any other link. Requiring 3 clicks, without any noticable gain, seems confusing. My 2 cents. Geoffrey On 10/8/2005, "Mark Mackay - Orcon" <mark(a)orcon.net.nz> wrote: >I just wanted to clarify my comments about the message double-click: > >I like the double-click, it's just that I found that with IE6/Win when I >double-clicked on a subject, the line would highlight, then the word I >double-clicked on -- then wait 1-5 secs then the message would load (meaning >I often double-double-clicked, triple clicked, etc). > >Changing the cursor to an hourglass/watch would give the visual feedback >needed to let me stop clicking, however the highlighting of the word I >clicked over (rather than just the selected line) is a bit unexpected, >compared with a desktop app. Not sure if this is resolvable. > >-- > >OTH users of the web are used to single-clicking (although there are those >pesky double-clickers), so it's something to guide people into. By watching >our first test users I found most people expected to single-click and get a >preview pane. If this is in the pipeline as an optional UI element, then the >double-click to view the message on its own will make more sense. > >If not, or in any case, we're better to guide the users as to how to use it: >maybe just some help text is needed "double click a message to open it". >This could appear after a delay if someone just selected a message and did >nothing else maybe. > >-- > >I could be being a bit overzealous here. Most people figured it out quickly >enough, and I think the hourglass if that's easily doable will probably >solve it. > >Regards, >Mark Mackay. > >

1 0

08 Oct '05

Hi, A couple of coworkers have large mailboxes with 3000 to 7000 mails. Hence it takes a while before the mailbox overview (first screen after logging in) is rendered. They thought Roundcube was hanging as Horde/IMP doesn't have that delay. I presume the difference is because Horde/IMP is depending on the 'imap' PHP extension while Roundcube just talks IMAP over the established socket connection to the imap-server. Can't Roundcube be configured to read the first 300 mails (or the first 4 pages) when logging in and read the other mails on demand, that is when the user uses the navigation in the top right. In the majority of the cases one doesn't need to see the other/older mail. Or maybe the other mails can be read in the background after the 'homepage' is loaded. This allows reading the new mail etc and will make Roundcube more snappier. Just my 2 cents. Jasper

1 0

Roundcube 20051007 and loading times
by Raphael Reich 08 Oct '05

08 Oct '05

Hello list, yesterday I upgraded to Roundcube 20051007. The loading time has significantly increased for any action I tried. e.g. opening an email consisting of just one simple text line takes about 15 sec. I switched back to version 20050820 and Roundcube is working quickly as it used to before the upgrade. Has anyone discovered similar problems? Raphael

1 0

Re: Re: Re: Message Source not configured properly?
by Geoffrey McCaleb 08 Oct '05

08 Oct '05

That was it! I can't believe I didn't think of that. Both the other webmail packages send mail directly....though I wonder why php mail() has that problem on my server. Oh well, thanks! Geoffrey On 10/7/2005, "Jon Wolf" <wolf(a)domojo.com> wrote: > >Perhaps the problem lies in your PHP mail() function. >Have you tried sending it through your mail server directly? >The options are in config/main.inc.php > >// use this host for sending mails. >// if left blank, the PHP mail() function is used >$rcmail_config['smtp_server'] = ''; > >// SMTP port (default is 25) >$rcmail_config['smtp_port'] = 25; > >// SMTP username (if required) >$rcmail_config['smtp_user'] = ''; > >// SMTP password (if required) >$rcmail_config['smtp_pass'] = ''; > >If you force sending through an SMTP server, does the problem persist? > >jw > >On Fri, 07 Oct 2005 17:59:13 -0100, "Geoffrey McCaleb" <geoffrey(a)tabasco.net> wrote: >> Hi Jon, >> Thanks for your note. But its not really a browser issue. The problem >> (for me at least) seems to be that the receiver of the mail gets the >> body and header scrambled. If I send a mail to myself, the display seems >> fine. >> >> Its a weird problem. I've got two other webmail packages on my server >> (IlohaMail & Horde) and they don't experience the same problem. >> >> Thanks! >> >> Geoffrey >> >> On 10/7/2005, "Jon Wolf" <wolf(a)domojo.com> wrote: >> >>> >>>I also upgraded to today's release and am not experiancing that problem >> in either of my browsers (Firefox 1.5 Beta 1; Opera 8.5). >>> >>>On Fri, 07 Oct 2005 17:24:28 -0100, "Geoffrey McCaleb" >> <geoffrey(a)tabasco.net> wrote: >>>> I've tried upgrading to the latest version and the problem still >> persists >>>> (was using 0.1-20050820, now on the build released today 0.1-20051007). >>>> >>>> Am I the only one getting this problem? Here is a screenshot if my >>>> description was too confusing. >>>> >>>> http://www.idiotabroad.com/pix/messagebody.png >>>> >>>> (while the above shows the problem in gmail, I get the same when >> sending >>>> to my work account which uses MS Outlook). >>>> >>>> Thanks everyone, >>>> >>>> Geoffrey >>>> >>>> On 10/7/2005, "Geoffrey McCaleb" <geoffrey(a)tabasco.net> wrote: >>>> >>>>>Hi All, >>>>>First off, just wanted to say what a great mail package RoundCube is. >> Its >>>>>fully featured, looks great, and simply is an amazing package! >>>>> >>>>>Sadly, I have a problem that is keeping me from using it. When sending >>>>>mail it seems that the message body somehow gets mixed with the header >>>>>(or vice versa). >>>>> >>>>>I've tried sending mails to gmail, and my work account. In both cases, >>>>>the message source looks like so: >>>>> >>>>><snip> >>>>>From: Geoffrey McCaleb <geoffrey(a)tabasco.net> >>>>>Message-ID: <e991f295cfe46cb15888fc09062011fb@osiris> >>>>>X-Sender: geoffrey(a)tabasco.net >>>>>User-Agent: RoundCube Webmail/0.1a >>>>>Content-Type: text/plain; charset="ISO-8859-1" >>>>>Content-Transfer-Encoding: 7bit >>>>> >>>>>Return-Path: geoffrey(a)tabasco.net >>>>>X-CTCH-ID: _C77A15DC-8C41-4BF6-87F4-09DB82AE628E_ >>>>>X-CTCH-RefID: 0001.0A090205.43464939.0029-A- >>>>>X-CTCH-Action: Ignore >>>>>X-OriginalArrivalTime: 07 Oct 2005 10:15:25.0453 (UTC) >>>>>FILETIME=[08ABBBD0:01C5CB28] >>>>> >>>>>This is another test. >>>>></snip> >>>>> >>>>>The body of the mail should have just been: "This is another test". >>>>> >>>>>Any idea what the problem might be? >>>>> >>>>>Thanks! >>>>> >>>>>Geoffrey >>>>> >>>>> >>> >

1 0

better results with new IMAPD (courier-imap4)
by Joshua Layne 08 Oct '05

08 Oct '05

Hi all, I just wanted to report that a newer IMAP server works WONDERS! I upgraded to courier-imap 4 from courier-imap 2.2 and the overall experience is much... zippier. if you are having problems with timeouts, your imap server may be the problem (IME) Also, if anyone is running against mac (tiger), I can walk them through the config process for courier imap 4 - took me a whilke anyway with the authlib stuff. regardless, I am excited by this performance increase - now I need to pull down the CVS version and put it up. is there anything that needs looking at? I am competent in PHP, not so competent in mail transfer and mail protocols, not competent in AJAX, though XML and javascript alone don\\\\\\\'t bother me, I\\\\\\\'ve just never mixed them. let me know if I can help. j.

1 0

Re: Re: Message Source not configured properly?
by Geoffrey McCaleb 07 Oct '05

07 Oct '05

Hi Jon, Thanks for your note. But its not really a browser issue. The problem (for me at least) seems to be that the receiver of the mail gets the body and header scrambled. If I send a mail to myself, the display seems fine. Its a weird problem. I've got two other webmail packages on my server (IlohaMail & Horde) and they don't experience the same problem. Thanks! Geoffrey On 10/7/2005, "Jon Wolf" <wolf(a)domojo.com> wrote: > >I also upgraded to today's release and am not experiancing that problem in either of my browsers (Firefox 1.5 Beta 1; Opera 8.5). > >On Fri, 07 Oct 2005 17:24:28 -0100, "Geoffrey McCaleb" <geoffrey(a)tabasco.net> wrote: >> I've tried upgrading to the latest version and the problem still persists >> (was using 0.1-20050820, now on the build released today 0.1-20051007). >> >> Am I the only one getting this problem? Here is a screenshot if my >> description was too confusing. >> >> http://www.idiotabroad.com/pix/messagebody.png >> >> (while the above shows the problem in gmail, I get the same when sending >> to my work account which uses MS Outlook). >> >> Thanks everyone, >> >> Geoffrey >> >> On 10/7/2005, "Geoffrey McCaleb" <geoffrey(a)tabasco.net> wrote: >> >>>Hi All, >>>First off, just wanted to say what a great mail package RoundCube is. Its >>>fully featured, looks great, and simply is an amazing package! >>> >>>Sadly, I have a problem that is keeping me from using it. When sending >>>mail it seems that the message body somehow gets mixed with the header >>>(or vice versa). >>> >>>I've tried sending mails to gmail, and my work account. In both cases, >>>the message source looks like so: >>> >>><snip> >>>From: Geoffrey McCaleb <geoffrey(a)tabasco.net> >>>Message-ID: <e991f295cfe46cb15888fc09062011fb@osiris> >>>X-Sender: geoffrey(a)tabasco.net >>>User-Agent: RoundCube Webmail/0.1a >>>Content-Type: text/plain; charset="ISO-8859-1" >>>Content-Transfer-Encoding: 7bit >>> >>>Return-Path: geoffrey(a)tabasco.net >>>X-CTCH-ID: _C77A15DC-8C41-4BF6-87F4-09DB82AE628E_ >>>X-CTCH-RefID: 0001.0A090205.43464939.0029-A- >>>X-CTCH-Action: Ignore >>>X-OriginalArrivalTime: 07 Oct 2005 10:15:25.0453 (UTC) >>>FILETIME=[08ABBBD0:01C5CB28] >>> >>>This is another test. >>></snip> >>> >>>The body of the mail should have just been: "This is another test". >>> >>>Any idea what the problem might be? >>> >>>Thanks! >>> >>>Geoffrey >>> >>> >

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev