Dev

dev@lists.roundcube.net

1 participants
4289 discussions

[PATCH] Threaded messagelist view patch rev5 (against r3022)
by Vladislav Bogdanov 07 Oct '09

07 Oct '09

Hi all, here is a most recent revision of a threaded view patch. Most notable changes since rev4 (http://lists.roundcube.net/mail-archive/dev/2009-09/0000143.html): 1. Port to RC r3022 2. Add children of a last shift-selected message to selection too. Alec, would you please check this patch to not interfere with your last additions (message index) in a improper way? Vladislav --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/b0/CxyyRJRs/roundcubemail-thread.patch http://detached.gigo.com/rc/b0/CxyyRJRs/unread_children.png Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

5 16

Updated Swedish localization
by Jonas Nasholm 07 Oct '09

07 Oct '09

Hi, I’ve attached an updated Swedish localization. Regards, Jonas Nasholm Bitfuse Network --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/ve/t9qVAg1v/sv_SE.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] [PATCH] Threaded messagelist view patch rev5 (against r3022)
by Vladislav Bogdanov 07 Oct '09

07 Oct '09

Mark Little wrote: >>> I have a test RC folder that I updated to 3022 and then applied your >>> patch cleanly [1]. However it doesn't appear to be working for me.. >> Did you try to enable per-folder threading in a Folders tab of a >> settings? > > Ah - I didn't even realize it was an option under Folders. Very cool. Not as cool as it is intended to be... It should be easily locateable. I think it should be in some place in a messagelist widget. And this would be more natural too, because one may want to switch between threaded and plain views in a one click, just because fresh reply to an old thread could appear somewhere where nobody can find it (on a third page f.e.)... This is still to be discussed with devs. So I'm CC'ing to dev list just not to repeat myself. > >> They should be visible only if threading is supported and enabled for >> folder. >> But subject in a message-list should be moved a bit to right in this >> case to leave a space for expand/collapse icons... It isn't in your > case... > > In my root inbox I don't have threading enabled because generally thats > for individual emails, and any mailing lists I am on have their own folder. > > I enabled the threading for some mailing lists and it looks to be working That's OK. > great on all the threaded folders, however I am still experiencing problems > on non-threaded folders. Hmm, everything works for me on such folders... Would you please describe problems a bit more detailed? If you simply mean that two states of a three-state switch look identically while third shown things in reverse, then it is OK. And, I seen thread controls on your previous screenshots. Are they still there for a non-threaded view? They should be hidden for thread-unaware folders... > > From what I can tell - the new sort option doesn't appear to have any > effect? Also, no matter what I do, the sorting doesn't change when > threading is disabled for a folder. It's original function was to present 'unsorted' view. It seems to be superseded by last changes in trunk. I didn't realized that while porting to the newest version. This issue is being discussed at dev list right now by the original patch author (Chris January) and RC core devs (I'm only porting it to current SVN from time to time and adding some fixes, bells and whistles ;) , changes set is available in my posts to dev list). And I hope this issue will be resolved before merging to trunk which I in turn hope will occur soon. > Do you still want me to do the debug? Do you want me to do it a couple of > times or just ones? Let me know what options/sorting mode you want. No, if it all works except for what I wrote above. Thank you. Vladislav _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] [PATCH] Threaded messagelist view patch rev5 (against r3022)
by Chris January 07 Oct '09

07 Oct '09

On Wed, 07 Oct 2009 13:26:43 +0200, "A.L.E.C" <alec(a)alec.pl> wrote: > Chris January wrote: > >>>> Sorting by anything but the default order (i.e. index_sort=true) is >>>> incredibly slow with 30,000 or so messages. >>> THREAD command returns messages (threads) sorted by date, it's not >>> possible to speed this up. Index_sort option will not help and we have >>> two possibilities: >>> - re-sort by root message index if index_sort=true, >>> - forget about index_sort option when using threads >> >> This is why there is a 'default' sort order in the threading patch. The >> THREAD command returns, as you say, messages sorted by date. Roundcube >> then >> sorts them again which can be very slow with lots of messages. So the >> threading patch introduces the 'default' sort order, which could be >> better >> called the 'unsorted' sort order, i.e. the messages aren't sorted at all >> but kept in the same order they are returned by the server. > > But re-sorting by message index shouldn't be very slow, since we don't > fetch any data from IMAP server. I still force to not use this 'default' > stuff. Sorting ~30,000 threads with ~60,000 messages in them takes in the order of minutes on my machine. This is unacceptably slow, that's why I added the 'default' option. Chris _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

Documentation for skins
by Andres Sulleiro 06 Oct '09

06 Oct '09

Is the documentation for skins available anywhere? Thanks. // Andrés _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

Fwd: rc userinfo plugin hu_HU
by till 06 Oct '09

06 Oct '09

Hi Peter, I'm forwarding this email to our dev@ mailing list where this should have went. Also, if it's not too much to ask, please supply a patch next time. :-) Till ---------- Forwarded message ---------- From: Péter Varga <info(a)vargapeter.com> Date: 2009/10/5 Subject: rc userinfo plugin hu_HU To: hello(a)roundcube.net Hy! For the next release I translated the plugins localization: $labels['userinfo'] = 'Felhasználó'; $labels['created'] = 'Létrehozva'; $labels['lastlogin'] = 'Utolsó bejelentkezés'; $labels['defaultidentity'] = 'Alapértelmezett profil'; And a little "bug": On the top "Infos for xxx(a)domain.xxx" wasn't translated. (attached screenshot). In hunagrian (hu_HU) means: "Információk a felhasználóról:" Best regards, Peter _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

ISO to UTF-8 mapping errors
by Mirko Buffoni 06 Oct '09

06 Oct '09

Hi, I checked my error logs with roundcube and found several repeated issues with conversion to UTF-8. [06-Oct-2009 09:01:09 +0200]: PHP Error: Could not convert string from ISO-1040 to UTF-8. Make sure iconv/mbstring is installed or lib/utf8.class is available. in /home/roundcubemail/program/include/main.inc on line 279 (GET /?_task=mail) [06-Oct-2009 09:02:54 +0200]: PHP Error: Could not convert string from ISO-1040 to UTF-8. Make sure iconv/mbstring is installed or lib/utf8.class is available. in /home/roundcubemail/program/include/main.inc on line 279 (GET /?_task=mail&_mbox=INBOX&_page=1) [06-Oct-2009 09:43:22 +0200]: PHP Error: Could not convert string from ISO-88659-1 to UTF-8. Make sure iconv/mbstring is installed or lib/utf8.class is available. in /home/roundcubemail/program/include/main.inc on line 279 (GET /?_task=mail) most of them are related to ISO-1040 and ISO-88659-1 conversion. Are these equivalent to some other charset and can be added to aliases? or do we need to include a new mapping file to encodings directory? Thanks. Mirko _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

authenticate plugin hook and host parameter
by Jernej Porenta 05 Oct '09

05 Oct '09

Heya all, I am trying to develop a plugin that would change the default_host config variable. The issue is quite similar to following thread: http://lists.roundcube.net/mail-archive/dev/2009-09/0000049.html If I set up the authenticate plugin hook, the return host value, should also be listed in config.inc.php (reference: program/include/rcmail.php line 439), so that means that if I have multiple IMAP backends, all of them must be listed in config.inc.php default_host variable. Meanwhile, that means that on login page drop down box appears (loginform object in rcube_template.php). So, is there a way to skip server drop down box on login page and properly use authenticate hook to set up the host parameter. If this is not possible, I would omit host parameter in authenticate hook, since it cannot be altered. Pedro R. Benito da Rocha made a good suggestion that 'skip dialog' config option could be present and used in rcube_template.php to skip server box display. IMHO that is the way to deal with it... regards, Jernej _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] [Svn] r3010 - in trunk/roundcubemail: . program/include
by A.L.E.C 05 Oct '09

05 Oct '09

Thomas Bruederli wrote: >> - if (empty($o_part->charset)) >> + if (empty($o_part->charset) || strtolower($o_part->charset) == 'us-ascii') >> $o_part->charset = $this->default_charset; >> > > Hi Alec > > Hmm, I have some concerns that this change might break the display of > messages that really are encoded with US-ASCII. How is such an e-mail > displayed if the default charset is some chinese character set? I think most of encodings contains ASCII subset, so there should be no significant problem with this. We need to test this more. -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

czech translation update
by Aleš Pospíchal 04 Oct '09

04 Oct '09

Hello, here is new translation update for czech language. Changes: uploading - translated notuploadedwarning - translated Aleš Pospíchal --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/4q/cURATWBE/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev