Dev

dev@lists.roundcube.net

4290 discussions

Delete/move bug fixed
by NetOne - Doichin Dokov 26 Oct '06

26 Oct '06

Hi guys, I belive i've fixed bug #1484044 <http://trac.roundcube.net/trac.cgi/ticket/1484044>, please review it and and to SVN if the fix is OK. Regards, Doichin

5 7

Patch for having transparent server selection for multiple domains
by Clément Moulin 25 Oct '06

25 Oct '06

Hi I've already proposed this patch (in April), but you'd asked me to update it for current release. http://209.85.129.104/search?q=cache:HCto6VkAqNIJ:www.roundcubeforum.net/ind ex.php%3Ftopic%3D122.msg2162+round+cube+simplerezo&hl=fr&gl=fr&ct=clnk&cd=1 So here the patch for the current SVN version: --- index.php.old Tue Oct 17 17:18:46 2006 +++ index.php Tue Oct 17 17:19:28 2006 @@ -166,6 +166,23 @@ if ($_action=='login' && $_task=='mail') { $host = $_POST['_host'] ? $_POST['_host'] : $CONFIG['default_host']; + + // auto host + if (is_array($host) && is_array(reset($host))) + { + if (isset($_POST['_user'])) + { + $tmp = split('@', $_POST['_user']); + if (sizeof($tmp) > 1) + foreach ($host as $cur_host => $domains) + if (in_array($tmp[1], $domains)) + { + $host_ok = $cur_host; + break;; + } + $host = isset($host_ok) ? $host_ok : ''; + } + } // check if client supports cookies if (empty($_COOKIE)) --- config/main.inc.php.dist.old Tue Oct 17 17:20:09 2006 +++ config/main.inc.php.dist Tue Oct 17 17:21:39 2006 @@ -35,6 +35,12 @@ // leave blank to show a textbox at login, give a list of hosts // to display a pulldown menu or set one host as string. // To use SSL connection, enter ssl://hostname:993 +// auto-selection of host depending on domain specified can +// be enabled using a value like this: +// $rcmail_config['default_host'] = array( +// 'mail.server.com' = array('domaine1.com', 'domaine2.net'), +// 'mail.server2.com' = array('my.otherdomain.net'), +// 'host.hosting.com' = array('a.net', 'b.org', 'c.com')); $rcmail_config['default_host'] = ''; // TCP port used for IMAP connections --- program/include/main.inc.old Tue Oct 17 17:22:14 2006 +++ program/include/main.inc Tue Oct 17 17:23:10 2006 @@ -1717,10 +1717,13 @@ { $select_host = new select(array('name' => '_host', 'id' => 'rcmloginhost')); - foreach ($CONFIG['default_host'] as $key => $value) - $select_host->add($value, (is_numeric($key) ? $value : $key)); + if (!(is_array($CONFIG['default_host']) && is_array(reset($CONFIG['default_host'])))) + { + foreach ($CONFIG['default_host'] as $key => $value) + $select_host->add($value, (is_numeric($key) ? $value : $key)); - $fields['host'] = $select_host->show($_POST['_host']); + $fields['host'] = $select_host->show($_POST['_host']); + } } else if (!strlen($CONFIG['default_host'])) { I quote myself: [ Note: you can use in main.inc.php something like: $rcmail_config['default_host'] = include('mystuff.inc.php'); And in mystuff.inc.php doing whatever you like for building and returning the associative arrays (retrieving informations from a database for an example, like we do). Just be aware that this file is called for every HTTP request (so if you are using database as I said, it could have some performance issues....). ] I hope this will be committed soon. -- Clement Moulin SimpleRezo

2 1

Preview pane for SVN 361
by Robin Elfrink 24 Oct '06

24 Oct '06

Hi, I managed to spend some time on my preview pane, to make it work in the current SVN revision 361. Two options were added to config/main.inc.php: // Enable preview pane $rcmail_config['enable_preview'] = FALSE; // display preview pane if enabled $rcmail_config['preview'] = FALSE; Some issues that I have: - Attachment filenames are gone, even though the preview pane displays them correctly. - There should be a 'view source' button if a message is previewed. Robin Index: config/main.inc.php.dist =================================================================== --- config/main.inc.php.dist (revision 361) +++ config/main.inc.php.dist (working copy) @@ -171,6 +171,9 @@ // Leave empty for default set of Google spell check languages $rcmail_config['spellcheck_languages'] = NULL; +// Enable preview pane +$rcmail_config['enable_preview'] = FALSE; + // path to a text file which will be added to each sent message // paths are relative to the RoundCube root folder $rcmail_config['generic_message_footer'] = ''; @@ -216,6 +219,9 @@ // prefer displaying HTML messages $rcmail_config['prefer_html'] = TRUE; +// display preview pane if enabled +$rcmail_config['preview'] = FALSE; + // show pretty dates as standard $rcmail_config['prettydate'] = TRUE; Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 361) +++ program/include/main.inc (working copy) @@ -1200,6 +1200,7 @@ 'editorselector' => 'rcmail_editor_selector', 'searchform' => 'rcmail_search_form', 'receiptcheckbox' => 'rcmail_receipt_checkbox', + 'preview' => 'rcmail_message_preview', // ADDRESS BOOK 'addresslist' => 'rcmail_contacts_list', Index: program/localization/nl_NL/labels.inc =================================================================== --- program/localization/nl_NL/labels.inc (revision 361) +++ program/localization/nl_NL/labels.inc (working copy) @@ -202,6 +202,7 @@ $labels['pagesize'] = 'Rijen per pagina'; $labels['signature'] = 'Onderschrift'; $labels['dstactive'] = 'Zomertijd'; +$labels['preview'] = 'Voorbeeldvenster'; $labels['folder'] = 'Map'; $labels['folders'] = 'Mappen'; Index: program/localization/en_US/labels.inc =================================================================== --- program/localization/en_US/labels.inc (revision 361) +++ program/localization/en_US/labels.inc (working copy) @@ -207,6 +207,7 @@ $labels['dstactive'] = 'Daylight savings'; $labels['htmleditor'] = 'Compose HTML messages'; $labels['htmlsignature'] = 'HTML signature'; +$labels['preview'] = 'Preview message'; $labels['autosavedraft'] = 'Automatically save draft'; $labels['everynminutes'] = 'every $n minutes'; Index: program/js/app.js =================================================================== --- program/js/app.js (revision 361) +++ program/js/app.js (working copy) @@ -135,7 +135,7 @@ } // enable mail commands - this.enable_command('list', 'checkmail', 'compose', 'add-contact', 'search', 'reset-search', true); + this.enable_command('list', 'checkmail', 'compose', 'add-contact', 'search', 'reset-search', 'load-attachment', true); if (this.env.action=='show') { @@ -552,6 +552,7 @@ var input_pagesize = rcube_find_object('_pagesize'); var input_name = rcube_find_object('_name'); var input_email = rcube_find_object('_email'); + var input_preview = rcube_find_object('_preview'); // user prefs if (input_pagesize && isNaN(input_pagesize.value)) @@ -1039,6 +1040,8 @@ this.enable_command('show', 'reply', 'reply-all', 'forward', 'print', selected); this.enable_command('delete', 'moveto', list.selection.length>0 ? true : false); } + if (selected && this.env.enable_preview && this.env.preview) + this.show_preview(list.selection[0]); }; @@ -1067,6 +1070,30 @@ /*********************************************************/ + this.show_preview = function(id, safe) + { + var add_url = ''; + var target = window; + var contentframe = rcube_find_object('mailcontframe'); + var previewpane = rcube_find_object('previewpane'); + + if (id && contentframe && previewpane) + { + rcmail.set_busy(true, 'loading'); + if (previewpane.style.display=='none') + { + contentframe.style.height = (contentframe.offsetHeight/2) + 'px'; + previewpane.style.top = (contentframe.offsetTop+contentframe.offsetHeight) + 'px'; + previewpane.style.display = 'block'; + var message = rcube_find_object('rcmrow' + id); + message.scrollIntoView(); + } + var url = '_action=preview&_uid='+id; + rcmail.http_request('preview', url, true); + } + }; + + // when user doble-clicks on a row this.show_message = function(id, safe) { @@ -3115,6 +3142,12 @@ case 'expunge': this.enable_command('select-all', 'select-none', 'expunge', this.env.messagecount ? true : false); break; + + case 'preview': + var previewpane = rcube_find_object('previewpane'); + previewpane.innerHTML = request_obj.get_text(); + previewpane.scrollTop = 0; + break; } request_obj.reset(); Index: program/steps/settings/func.inc =================================================================== --- program/steps/settings/func.inc (revision 361) +++ program/steps/settings/func.inc (working copy) @@ -155,6 +155,17 @@ rep_specialchars_output(rcube_label('htmleditor')), $input_htmleditor->show($CONFIG['htmleditor']?1:0)); + // Show option for preview pane + if ($CONFIG['enable_preview']) + { + $field_id = 'rcmfd_preview'; + $input_preview = new checkbox(array('name' => '_preview', 'id' => $field_id, 'value' => 1)); + $out .= sprintf("<tr><td class=\"title\"><label for=\"%s\">%s</label></td><td>%s</td></tr>\n", + $field_id, + rep_specialchars_output(rcube_label('preview')), + $input_preview->show($CONFIG['preview']?1:0)); + } + if (!empty($CONFIG['drafts_mbox'])) { $field_id = 'rcmfd_autosave'; @@ -242,4 +253,4 @@ } -?> \ No newline at end of file +?> Index: program/steps/settings/save_prefs.inc =================================================================== --- program/steps/settings/save_prefs.inc (revision 361) +++ program/steps/settings/save_prefs.inc (working copy) @@ -29,8 +29,11 @@ $a_user_prefs['pagesize'] = is_numeric($_POST['_pagesize']) ? (int)$_POST['_pagesize'] : $CONFIG['pagesize']; $a_user_prefs['prefer_html'] = isset($_POST['_prefer_html']) ? TRUE : FALSE; $a_user_prefs['htmleditor'] = isset($_POST['_htmleditor']) ? TRUE : FALSE; +if ($CONFIG['enable_preview']) + $a_user_prefs['preview'] = isset($_POST['_preview']) ? TRUE : FALSE; $a_user_prefs['draft_autosave'] = isset($_POST['_draft_autosave']) ? intval($_POST['_draft_autosave']) : 0; + // MM: Date format toggle (Pretty / Standard) $a_user_prefs['prettydate'] = isset($_POST['_pretty_date']) ? TRUE : FALSE; Index: program/steps/mail/show.inc =================================================================== --- program/steps/mail/show.inc (revision 361) +++ program/steps/mail/show.inc (working copy) @@ -171,6 +171,8 @@ if ($_action=='print') parse_template('printmessage'); +else if ($_action=='preview') + parse_template('previewmessage'); else parse_template('message'); -?> \ No newline at end of file +?> Index: program/steps/mail/func.inc =================================================================== --- program/steps/mail/func.inc (revision 361) +++ program/steps/mail/func.inc (working copy) @@ -480,6 +480,8 @@ $javascript .= sprintf("%s.set_env('pagecount', %d);\n", $JS_OBJECT_NAME, ceil($message_count/$IMAP->page_size)); $javascript .= sprintf("%s.set_env('sort_col', '%s');\n", $JS_OBJECT_NAME, $sort_col); $javascript .= sprintf("%s.set_env('sort_order', '%s');\n", $JS_OBJECT_NAME, $sort_order); + if ($CONFIG['enable_preview']) + $javascript .= sprintf("%s.set_env('preview', '%s');\n", $JS_OBJECT_NAME, $CONFIG['preview']); if ($attrib['messageicon']) $javascript .= sprintf("%s.set_env('messageicon', '%s%s');\n", $JS_OBJECT_NAME, $skin_path, $attrib['messageicon']); Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 361) +++ skins/default/templates/mail.html (working copy) @@ -52,6 +52,8 @@ attachmentIcon="/images/icons/attachment.png" /> </div> +<div id="previewpane" style="display: none;"></div> + <div id="listcontrols"> <roundcube:label name="select" />:  <roundcube:button command="select-all" label="all" classAct="active" />  Index: skins/default/mail.css =================================================================== --- skins/default/mail.css (revision 361) +++ skins/default/mail.css (working copy) @@ -120,7 +120,30 @@ height: expression((parseInt(document.documentElement.clientHeight)-125)+'px'); } +#previewpane +{ + position: absolute; + display: none; + top: 85px; + left: 200px; + right: 40px; + bottom: 40px; + border: 1px solid #999999; + border-top: none; + background-color: #F9F9F9; + overflow: auto; + /* css hack for IE */ + width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); + height: expression(( + parseInt(document.documentElement.clientHeight) - + parseInt(document.getElementById('mailcontframe').clientHeight) - 125)+'px'); +} +body > div#previewpane +{ + height: auto; +} + #messagepartframe { border: 1px solid #999999; Index: index.php =================================================================== --- index.php (revision 361) +++ index.php (working copy) @@ -262,7 +262,7 @@ { include_once('program/steps/mail/func.inc'); - if ($_action=='show' || $_action=='print') + if ($_action=='show' || $_action=='print' || $_action=='preview') include('program/steps/mail/show.inc'); if ($_action=='get')

2 1

Bug report: invalid header modification
by Morten Mertner 24 Oct '06

24 Oct '06

Hi All, I'm seeing errors like this in my error_log: .. PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0 .. PHP Stack trace: .. PHP 1. {main}() /var/www/localhost/htdocs/roundcube-svn/index.php:0 .. PHP 2. include() /var/www/localhost/htdocs/roundcube-svn/index.php:299 I hope this is useful - and do let me know if I should rather post this somewhere else. Yours, Morten

5 5

Problema
by brilo＠brilo.net.ar 23 Oct '06

23 Oct '06

Estoy teniendo problemas con este webmail y lamentablemente no se inglés, no se como expresarme y como entender lo que dicen los foros. Paso a explicar mi problema por aqui, espero puedan entenderme. El Webmail "funciona bien"... puedo enviar mensajes, guarda las preferencias, etc. Pero el problema es que cuando lista los mensajes no me muestra ni el asunto ni la fecha, no muestra nada, solo el tamaño y tampoco me deja abrirlos. Les adjunto un screen de la pantalla para que me entiendan mejor. Espero que puedan ayudarme. Desde ya, muchas gracias. Atte. Fernando R. Briloni

2 1

SMTP Error: SMTP error: Failed to add recipient
by Robin Elfrink 18 Oct '06

18 Oct '06

Hi, I have (had) some users getting the following error: SMTP Error: SMTP error: Failed to add recipient 'random(a)email.address' It happens with the same users continuously. So I tried adding some debugging to the function that caused this error, and changed this: // set mail recipients foreach ($recipients as $recipient) { if (PEAR::isError($SMTP_CONN->rcptTo($recipient))) { smtp_reset(); $SMTP_ERROR .= "Failed to add recipient '$recipient'\n"; return FALSE; } } into this: // set mail recipients foreach ($recipients as $recipient) { $error = $SMTP_CONN->rcptTo($recipient); if (PEAR::isError($error)) { smtp_reset(); $SMTP_ERROR .= "Failed to add recipient '$recipient'\n"; $SMTP_ERROR .= "SMTP error: '".$error->getMessage()."'\n"; return FALSE; } } and all of a sudden the problem is gone for the users. Is my pear install broken? Does PEAR::isError() have a problem with $SMTP_CONN->rcptTo() somehow? Robin

1 0

problem sending email
by jrivera＠igraficaestudio.com 16 Oct '06

16 Oct '06

i just install round cube, after having some problems with the erro 1f4 jajaja i read many have bump in to it, but now wend i try to send and emal it just wont send, can anybody help me please i have no clue what to no next

4 4

Developer required?
by Hans-Christian Otto 14 Oct '06

14 Oct '06

Hi, do you still 'need' help by a developer who wants to contribute to an opensource project? ;-) I'm using roundcube by myself, and I really like it. Due to this and to the fact that I'm coding php for a few years now, I decided to ask whether the roundcube projects wants my the help. :) I'm waiting for your reply, greetings, Christian -- Hans-Christian Otto www: http://muh-die-kuh.de mail: c.otto(a)lab9.de jabber: muh-die-kuh(a)jabber.ccc.de icq: 127751895 gpg: 0xE5004DA3

2 1

Adressbook done , almost - heres a patch
by shane＠gnative.com 14 Oct '06

14 Oct '06

Someone pointed out that the link on the dev list isn't working for the patch/diff So i have put up a link on my site of anyone wants to grab it.. www.gnative.com/dev/ also i have send an email of the initial one containing the attachment and the list of TODO the the demo site as well use the same link above. I also realized that not all the contacts would load the first time (if you have more than 40) as i forgot to remove the "page limit" in func.inc on the limitquery for the DB. yes there are still bugs to be swatted.. wish i had a couple more days then i could have all these done for you. Glad to get the response that i have gotten so far. Thank you ---------------------------------------------------------------------- Variety is the spice of life .. except in Thailand where the spice makes your life slip out your arsehole. ----------------------------------------------------------------------

1 0

Adressbook done , almost - heres a patch
by shane＠gnative.com 13 Oct '06

13 Oct '06

Address-book development is almost done if someone wants to have a play at finishing it Unfortunately i have to head up to China and beyond tomorrow and will be off the beaten track for a few months till i get back to Europe sometime in the snow covered months. I hope someone is willing to pick up where i have left off Added support to Addressbook is : 1. vCard upload/importing to v3.0 standard 2. Contact grouping 3. Contact searching.. Yes it works and its bloody fantastic. You can even search for a birth-date or phone number. 4. Multiple emails and clicking on these links will take you to compose (thanks Phil) You can demo at : www.gnative.com/dev/rcdev/ I've attached a diff here of what i have done. Below is where i was up to Hope you can all find a use for this Happy Xmas and a Merry Halloween Shane shane(a)gnative.com TODO: ===================================================================================== 1. Enable other forms of import/export -cvs -xsl -output to PDF / HTML - print 2. Include image support thumbnailing if GD or Imagemagic present, i like this idea but some might not.. worth a discussion or as a plugin ?? 3. It was mentioned to add support for selecting folder that could become global As in all users of the app could have access to it.. I have left support in the contactsgrouping SQL tables for this as i thought this was a good idea. Just needs to be set in preferences 4. Something seems to be up with trying to move large amounts of contacts to a group folder. It seems to be clearing the group. 5. The buttons for group folder display funny in IE they float over the groupbox listing area instead of staying below 6. Language support so far i have only done EN_GB and EN_US. 7. Add a warning message of "duplicate upload" on vcard loaded frame Small bugs to fix. ------------------------------------------------------------------------------------- 1. Hitting enter on the add group when in the input field returns the page to mail 2. Need to sort out the page numbering.. i have been removing this and had the thought of making this click through the contacts in the row column that is currently listed 3. Check to see how LDAP support is working as i don't have a LDAP account so haven't been able to do this 4. Change how the folders get reloaded at the moment its just document write instead of off the DOM (lazy ha). I figured I'd get this fixed once i have a look at the other main changes i want to look (see below). This looked like it would go with what was happening in the functions for settings and its folders. It could become a generic object for all folder directories blah blah blah. 5. Do the database thing for initial and upgrade. I have only worked off the mysql.initial at the mo. Note: altered "contacts" table and added "contactgroup" table (unavoidable). Main fixes to be done (Mainly just tiding up). ------------------------------------------------------------------------------------- 1. Many of the functions that i use have been regurgitated from the mail's set of functions for listing mail. These can be made reusable across the entire board I.E made into common functions. - Prime example is the simply the row functions in app.js 2. Javascript needs revisiting and done the same to as above. I was think of how to make this more object orientated as in a mail object and address-book object - this would make things better for a plug-in styled API as the plugins could extend on those objects. For now the functions just need to be made so that they can be used by both mail and address-book side to decrease file size and make scripting easier. Don't fancy working with large files like this 3. Check for better error catchment.

2 1

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev