Dev

dev@lists.roundcube.net

4290 discussions

Addressbook improvements, first shot
by Paul Carrasco 04 Oct '06

04 Oct '06

Hello everybody, I use roundcube for my emails but I think the adressbook is lacking a lot of interesting features. 1) Ability to store multiple email adresses, phones numbers, pictures and other info about my contacts 2) Ability to share contacts (eg : my contacts could be seen by my wife, since we have some friends in common ;) 3) Ability to import/export from csv files or other adequate format 4) Ability to display pictures of my contacts when I receive mail from them (can anyone remember of the "picons" idea? see http://www.cs.indiana.edu/picons/ftp/faq.html#what) So I propose the following: 1) see the code below to implement an extended version of the contacts. At the moment it can : - eidt, save and display multiple info about your contacts - mailto links working with the various emails of the contact - I chose not to store the image in the db itself but only a link to it, since it was simpler; but it means cross-linking between your roudcube web site and the site hosting the image Todo : - when auto-completing recipient address only the first email of the contacts can be matched - when adding a new contact, only the first email address is checked for redundancy 2) Not implemented yet To share contacts, I have included a "global" attribute in the contact profile. When set to True this will make the contact visible to everybody, but editable only by the user who created it. There will be a config attribute to disable this behaviour. 3) Not implemented yet, but should'nt be hard 4) I really like this idea (try gmail to see how it could work). I think I will add : - mouse-over info box that displays the contact profile when the mouse is over a mail - when displaying a message, show at the top the picture and some info from the addressbook Please tell me if you think this can be included in roundcube 'official' version, and in that case I will send you the future updates. If you find bugs, please send them to me. It seems to work ok for me. If you prefer to work with cvs, I can do so, but on the web site it is said to propose code by mail. Bye Paul Code to implement feature 1) A/ DB modification (I use mysql, so this is the code to update the db scheme). ALTER TABLE `contacts` ADD `email2` VARCHAR( 128 ) NOT NULL , ADD `email3` VARCHAR( 128 ) NOT NULL , ADD `email4` VARCHAR( 128 ) NOT NULL , ADD `im` VARCHAR( 128 ) NOT NULL , ADD `homephone` VARCHAR( 128 ) NOT NULL , ADD `mobilephone` VARCHAR( 128 ) NOT NULL , ADD `workphone` VARCHAR( 128 ) NOT NULL , ADD `sip` VARCHAR( 128 ) NOT NULL , ADD `webpage` VARCHAR( 256 ) NOT NULL , ADD `birthdate` DATE NOT NULL , ADD `pgppublickey` TEXT NOT NULL , ADD `homeaddress` TEXT NOT NULL , ADD `workaddress` TEXT NOT NULL , ADD `company` VARCHAR( 128 ) NOT NULL , ADD `comments` TEXT NOT NULL , ADD `picture` VARCHAR( 256 ) NOT NULL , ADD `globalcontact` BOOL NOT NULL ; B/ Localization files updates (done only for US and fr files) US file: program/localization/en_US/labels.inc.php // address boook $labels['name'] = 'Display name'; $labels['firstname'] = 'First name'; $labels['surname'] = 'Last name'; $labels['email'] = 'E-Mail'; //new labels $labels[email2] = 'E-Mail 2'; $labels[email3] = 'E-Mail 3'; $labels[email4] = 'E-Mail 4'; $labels[im] = 'Instant messaging'; $labels[homephone] = 'Home phone'; $labels[mobilephone] = 'Mobile phone'; $labels[workphone] = 'Work phone'; $labels[sip] = 'SIP'; $labels[webpage] = 'Web page'; $labels[birthdate] = 'Birth date'; $labels[pgppublickey]= 'PGP public key'; $labels[homeaddress] = 'Home address'; $labels[workaddress] = 'Work address'; $labels[company] = 'Company'; $labels[comments] = 'Comments'; $labels[picture] = 'Picture'; $labels[globalcontact]= 'Global contact'; fr file: program/localization/fr/labels.inc.php // address boook $labels['name'] = 'Nom à afficher'; $labels['firstname'] = 'Prénom'; $labels['surname'] = 'Nom'; $labels['email'] = 'e-Mail'; //new labels $labels[email2] = 'e-Mail 2'; $labels[email3] = 'e-Mail 3'; $labels[email4] = 'e-Mail 4'; $labels[im] = 'Messagerie instantanée'; $labels[homephone] = 'Téléphone domicile'; $labels[mobilephone] = 'Téléphone mobile'; $labels[workphone] = 'Téléphone professionnel'; $labels[sip] = 'SIP'; $labels[webpage] = 'Page web'; $labels[birthdate] = 'Date de naissance'; $labels[pgppublickey]= 'Clé publique PGP'; $labels[homeaddress] = 'Adresse domicile'; $labels[workaddress] = 'Adresse professionnelle'; $labels[company] = 'Société'; $labels[comments] = 'Commentaires'; $labels[picture] = 'Image'; $labels[globalcontact]= 'Contact global'; C/ New config options To be appended at the end of the file: config/main.inc.php // addressbook configuration // chose which columns in the addressbook to enable, the columns are displayed in the specified order $rcmail_config['addressbook_show_cols'] = array('picture', 'name', 'firstname', 'surname', 'email', 'email2', 'email3', 'email4', 'im', 'homephone', 'mobilephone', 'workphone', 'sip', 'webpage', 'birthdate', 'pgppublickey', 'homeaddress', 'workaddress', 'company', 'comments', 'globalcontact'); // image size in address book $rcmail_config['addressbook_image_width'] = '100'; $rcmail_config['addressbook_image_height'] = '100'; // enable global contacts $rcmail_config['adressbook_enable_global_contacts'] = 'true'; D/ Show contact update Update the rcmail_contact_details function in the file: program/steps/addressbook/show.inc function rcmail_contact_details($attrib) { global $CONFIG, $CONTACT_RECORD, $JS_OBJECT_NAME; if (!$CONTACT_RECORD) return show_message('contactnotfound'); // a specific part is requested if ($attrib['part']) return rep_specialchars_output($CONTACT_RECORD[$attrib['part']]); // return the complete address record as table $out = "<table>\n\n"; $a_show_cols = $CONFIG['addressbook_show_cols']; foreach ($a_show_cols as $col) { if (substr($col,0,5)=='email' && $CONTACT_RECORD[$col]) $value = sprintf('<a href="#compose" onclick="%s.command(\'compose\', \'%d_%s\')" title="%s">%s</a>', $JS_OBJECT_NAME, $CONTACT_RECORD['contact_id'], $col, rcube_label('composeto'), $CONTACT_RECORD[$col]); elseif ($col=="picture" && $CONTACT_RECORD[$col]) $value = sprintf('<img height="%s" width="%s" src="%s" />', $CONFIG['addressbook_image_height'], $CONFIG['addressbook_image_width'], $CONTACT_RECORD[$col]); else $value = rep_specialchars_output($CONTACT_RECORD[$col]); $title = rcube_label($col); $out .= sprintf("<tr><td class=\"title\">%s</td><td>%s</td></tr>\n", $title, $value); } $out .= "\n</table>"; return $out; } E/ Edit contact update Update the rcmail_contact_editform function in the file: program/steps/addressbook/edit.inc function rcmail_contact_editform($attrib) { global $CONFIG, $CONTACT_RECORD, $JS_OBJECT_NAME; if (!$CONTACT_RECORD && $GLOBALS['_action']!='add') return rcube_label('contactnotfound'); // add some labels to client rcube_add_label('noemailwarning'); rcube_add_label('nonamewarning'); list($form_start, $form_end) = get_form_tags($attrib); unset($attrib['form']); // a specific part is requested if ($attrib['part']) { $out = $form_start; $out .= rcmail_get_edit_field($attrib['part'], $CONTACT_RECORD[$attrib['part']], $attrib); return $out; } // return the complete address edit form as table $out = "$form_start<table>\n\n"; #$a_show_cols = array('name', 'firstname', 'surname', 'email'); $a_show_cols = $CONFIG['addressbook_show_cols']; foreach ($a_show_cols as $col) { $attrib['id'] = 'rcmfd_'.$col; $title = rcube_label($col); if (($col=='homeaddress' || $col=='workaddress' || $col=='comments') && $CONTACT_RECORD[$col]) $value = rcmail_get_edit_field($col, $CONTACT_RECORD[$col], $attrib, 'textarea'); else $value = rcmail_get_edit_field($col, $CONTACT_RECORD[$col], $attrib); $out .= sprintf("<tr><td class=\"title\"><label for=\"%s\">%s</label></td><td>%s</td></tr>\n", $attrib['id'], $title, $value); } $out .= "\n</table>$form_end"; return $out; } F/ Save contact update Replace the line $a_save_cols = array('name', 'firstname', 'surname', 'email'); by $a_save_cols = $CONFIG['addressbook_show_cols']; in the file: program/steps/addressbook/save.inc G/ Compose mail update (to to chose not only the first email, but also one of the others depending on which link was clicked in the contact profile) Update the "case 'to'" in the compose action, in the file: program/steps/mail/compose.inc case 'to': $fname = '_to'; $header = 'to'; // we have contact id's as get parameters if (!empty($_GET['_to']) && preg_match('/^[0-9]+(,[0-9]+)*$/', $_GET['_to'])) { $a_recipients = array(); $sql_result = $DB->query("SELECT name, email FROM ".get_table_name('contacts')." WHERE user_id=? AND del<>1 AND contact_id IN (".$_GET['_to'].")", $_SESSION['user_id']); while ($sql_arr = $DB->fetch_assoc($sql_result)) $a_recipients[] = format_email_recipient($sql_arr['email'], $sql_arr['name']); if (sizeof($a_recipients)) $fvalue = join(', ', $a_recipients); } else if (!empty($_GET['_to']) && preg_match('/^[0-9]+_email[0-9]*$/', $_GET['_to'])) { $a_recipients = array(); preg_match('/^([0-9])+_(email[0-9]*)$/', $_GET['_to'], $matches); $sql_result = $DB->query("SELECT name, ".$matches[2]." FROM ".get_table_name('contacts')." WHERE user_id=? AND del<>1 AND contact_id IN (".$matches[1].")", $_SESSION['user_id']); while ($sql_arr = $DB->fetch_assoc($sql_result)) $a_recipients[] = format_email_recipient($sql_arr[$matches[2]], $sql_arr['name']); if (sizeof($a_recipients)) $fvalue = join(', ', $a_recipients); } else if (!empty($_GET['_to'])) $fvalue = $_GET['_to'];

1 0

Default encoding proposal
by NetOne - Doichin Dokov 28 Sep '06

28 Sep '06

Hi, I've uploaded a patch to make default encoding depend on current language file (I think that's better than blindly reverting to latin1/ISO-8859-1). Here it is : http://trac.roundcube.net/trac.cgi/ticket/1483839 Regards, Doichin

1 0

Better username-Handling
by Martin Eitzenberger 28 Sep '06

28 Sep '06

Hi! I somehow "improved" the way how roundcubes handles virtual users... This is, because my server panel (ispconfig) somehow creates an ugly virtual user table, therefore i want strictly the real mail username as common-name for accounts, so I moved the email2user BEFORE the first mysql-query // PART OF main.inc / rcmail_login(...) // $imap_port = $CONFIG['default_port']; // try to resolve email address from virtuser table if (!empty($CONFIG['virtuser_file']) && strstr($user, '@')) $user = rcmail_email2user($user); // query if user already registered $sql_result = $DB->query("SELECT user_id, username, language, preferences FROM ".get_table_name('users')." WHERE mail_host=? AND (username=? OR alias=?)", // END OF PART // This way, the database is forced to be on a real-username basis and doesn't create different addressbooks and settings by logging in with the different aliases of the same mailbox (wich makes no sense at all...) Another thing is, that I created faster mail2user and user2mail functions, use them if you like, GPL Code as usual ;-), mention me in some author/history/changelog if you like, I'm not one of these Super-EGO people who need to be mentioned anywhere, but I'm not against it either ;-) The functions are currently named "rcmail_getvlist", "rcmail_email2user" and "rcmail_user2email": // SNIPPET for main.inc // function rcmail_getvlist() { global $CONFIG,$x_listcache; if(!is_array($x_listcache)) { if(!is_file($CONFIG['virtuser_file']))return(array()); $f=file($CONFIG['virtuser_file']); while(list(,$t)=each($f))if(($t=trim($t))&&$t[0]!="#") { $t=str_replace("\t"," ",$t); while(strstr($t," "))$t=str_replace(" "," ",$t); list($x,$y)=explode(" ",$t); $e[$x]=$y; $u[$y]=$x; } $x_listcache=array($e,$u); } return($x_listcache); } function rcmail_email2user($email) { $l=rcmail_getvlist(); $x=$l[0][$email] return((($x)?$x:$email)); } function rcmail_user2email($user) { $l=rcmail_getvlist(); $x=$l[1][$user] return((($x)?$x:$user)); } // END OF SNIPPED // Basically, the getvlist returns (cached run, for future usage in sessions and/or multiple usage) a multi-dimensional array, value 0 contains an assoc-list with mail2user and 1 a list of user2mail. so you easily get the user: $user=$l[0][$email] ... the vlist basically works stable on all sendmail-style mailtab files, space or tab seperated (postfix, sendmail, exim, etc.) with single user to alias associations. Yeah, one other thing: I strongly recommend that you don't rely on any user2email functions, because often there are many aliases for the same user, and there is no rule to tell wich is the prefered one... Okay, hope I could help you, thanx for the only free webmailer I >want< to use ;-) And if anyone of you speaks german, please visit my RPG: http://pb.exw.at/ Have Fun! Martin alias PSIplus

1 0

BG localization - SVN r357
by NetOne - Doichin Dokov 27 Sep '06

27 Sep '06

Hi guys, I've published an svn-r357 BG localization at http://mirror.net1.cc/projects/roundcubemail%20-%20bg%20language/ Also, the wiki translation page doesn't say about some new strings: $messages['converting'] = 'Removing formatting from message...'; $labels['htmltoggle'] = 'HTML'; $labels['plaintoggle'] = 'Plain text'; $labels['htmleditor'] = 'Compose HTML messages'; $labels['htmlsignature'] = 'HTML signature'; $labels['autosavedraft'] = 'Automatically save draft'; $labels['everynminutes'] = 'every $n minutes'; $labels['never'] = 'never'; $labels['renamefolder'] = 'Rename folder'; Regards, Doichin

2 1

Bulgarian translation
by NetOne - Doichin Dokov 27 Sep '06

27 Sep '06

This is another Bulgarian translation, done by myself. I now see there's already a Bulgarian translation in svn, so maybe someone should decide which one is better. This is what I feel it should be, and is complete as of 0.1-beta2. I will soon publish current svn version compatible localization. Files are at http://mirror.net1.cc/projects/roundcubemail%20-%20bg%20language/ Regards, Doichin

1 0

DIMP
by till 24 Sep '06

24 Sep '06

Hi list, I just found "DIMP" (an Ajax interface to the wellknown IMP). Demo and screenshots are here: http://wiki.horde.org/DimpModule It looks pretty interesting in terms of what it can do and of course development development, so I thought I share the links. By the way, talking about horde/IMP. I remember that when we used it, they recommended running a proxy for imap. Is anyone running a similar setup to speed up RoundCube? Cheers, -- Till Klampaeckel e: mailto:klimpong@gmail.com p: +491704018676 l: http://beta.plazes.com/whereis/till

2 1

Traditional Chinese Language Pack
by SmallSea 24 Sep '06

24 Sep '06

Dear all, I have translated language file form english to traditional Chinese. Please download it from following link. http://www.mmlab.cse.yzu.edu.tw/~frei/dl/roundcube_zhtw-0.1-beta2.tar.gz Please tried it and see if it it okay. Thanks. :) SmallSea

2 1

Some weeks off
by Thomas Bruederli 24 Sep '06

24 Sep '06

Hi everybody I just wanted to let you know, that I'll be traveling for the next five weeks and will be offline most of the time. Don't expect any mail responses, comments, decisions or releases in that time. Of course, this does not mean, that nobody else is allowed work on the project. :-) Also, I just committed (rev. 354) some major changes in the client scripts. There's a new class available that controls all list behavior (for messages, contacts, identities) on the client side. I decided to do that in order to have the code separated and to give all new message list functionality like selection and keyboard events to all lists of the application. It also fixes the selection bug for the address book. Unfortunately I did not have the time to test it well, so expect some stuff to be broken. I removed the LDAP search temporarily because it also uses list functionality but is subject to be changed: it is planned to allow multiple sources for address data like the local address book and one or more LDAP directories. This will require a re-write of the LDAP access as well as the client scripts and I didn't want to change the LDAP list code now and then replace it with something else soon. Please forgive me that I broke some functions in the Trunk but I ran out of time to finish everything. Anyway, I decided to commit the changes before leaving for vacation and give you the possibility to review and improve the new list widget. And last but not least: we're looking for volunteers that will moderate the mailing list. If you're interested iin helping out for a while, please send a mail to bob [at] db [dot] org. Moderation means to approve posts to the mailing list that are nut junk but sent by people who are not subscribed to the list. Best regards, Thomas

1 0

Sender form field as text instead of select
by Matt Kaatman 24 Sep '06

24 Sep '06

Hey Guys, I'm new to the list and have been using roundcube for a couple of months. A few days ago I managed to break my installation and I'm not sure how I did it. I've logged the bug: http://trac.roundcube.net/trac.cgi/ticket/1484038 And steps to reproduce the bug: http://roundcubeforum.net/forum/index.php?topic=633.0 I've looked through the code a bit but I can't quite figuring out why I'm getting a text field instead of the select box. Thanks! Matt

1 1

I'm implementing tags!
by Joe Auricchio 24 Sep '06

24 Sep '06

Hi! I'm fed up with the fact that there are, to my knowledge, no webmail systems that support tags/labels (with the notable exception of GMail). So I'm going to do something about it. I'm going to add tags to Roundcube! =] I intend to read tags from, and store them as, IMAP Flags. The result should be somewhat interoperable with Thunderbird and Pine. (I've never used Pine, so I won't be able to test interop; I'm not a Thunderbird user but I have installed it and played with its tagging.) Now to the nitty-gritty. The plan, so far, is: - clean up the way flags are handled in rcube_imap.inc and lib/ imap.inc. They're up-cased, and "SEEN", "DELETED", etc are magical. I believe a better way to do this is to preserve flag case all the way through, and use "\Seen", "\Deleted", etc as IMAP does, including the backslash. Dealing with the backslash can mean some icky-looking code, but it shouldn't be a big problem. - add API for working with arbitrary tags. I think I'll start with steps/mail/mark.inc. I need to investigate exactly what this file is and when it gets called, though. - UI for tags. Not sure whether to clone GMail or what. Input would be especially appreciated here, I have a little UI-fu but I'm not a designer. I'll report my progress in this forum thread -> http:// roundcubeforum.net/forum/index.php?topic=340.0 I welcome all questions, comments, suggestions, corrections, and flames! -joe

5 6

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev