Dev

dev@lists.roundcube.net

1 participants
4293 discussions

Developer required?
by Hans-Christian Otto 14 Oct '06

14 Oct '06

Hi, do you still 'need' help by a developer who wants to contribute to an opensource project? ;-) I'm using roundcube by myself, and I really like it. Due to this and to the fact that I'm coding php for a few years now, I decided to ask whether the roundcube projects wants my the help. :) I'm waiting for your reply, greetings, Christian -- Hans-Christian Otto www: http://muh-die-kuh.de mail: c.otto(a)lab9.de jabber: muh-die-kuh(a)jabber.ccc.de icq: 127751895 gpg: 0xE5004DA3

2 1

Adressbook done , almost - heres a patch
by shane＠gnative.com 14 Oct '06

14 Oct '06

Someone pointed out that the link on the dev list isn't working for the patch/diff So i have put up a link on my site of anyone wants to grab it.. www.gnative.com/dev/ also i have send an email of the initial one containing the attachment and the list of TODO the the demo site as well use the same link above. I also realized that not all the contacts would load the first time (if you have more than 40) as i forgot to remove the "page limit" in func.inc on the limitquery for the DB. yes there are still bugs to be swatted.. wish i had a couple more days then i could have all these done for you. Glad to get the response that i have gotten so far. Thank you ---------------------------------------------------------------------- Variety is the spice of life .. except in Thailand where the spice makes your life slip out your arsehole. ----------------------------------------------------------------------

1 0

Adressbook done , almost - heres a patch
by shane＠gnative.com 13 Oct '06

13 Oct '06

Address-book development is almost done if someone wants to have a play at finishing it Unfortunately i have to head up to China and beyond tomorrow and will be off the beaten track for a few months till i get back to Europe sometime in the snow covered months. I hope someone is willing to pick up where i have left off Added support to Addressbook is : 1. vCard upload/importing to v3.0 standard 2. Contact grouping 3. Contact searching.. Yes it works and its bloody fantastic. You can even search for a birth-date or phone number. 4. Multiple emails and clicking on these links will take you to compose (thanks Phil) You can demo at : www.gnative.com/dev/rcdev/ I've attached a diff here of what i have done. Below is where i was up to Hope you can all find a use for this Happy Xmas and a Merry Halloween Shane shane(a)gnative.com TODO: ===================================================================================== 1. Enable other forms of import/export -cvs -xsl -output to PDF / HTML - print 2. Include image support thumbnailing if GD or Imagemagic present, i like this idea but some might not.. worth a discussion or as a plugin ?? 3. It was mentioned to add support for selecting folder that could become global As in all users of the app could have access to it.. I have left support in the contactsgrouping SQL tables for this as i thought this was a good idea. Just needs to be set in preferences 4. Something seems to be up with trying to move large amounts of contacts to a group folder. It seems to be clearing the group. 5. The buttons for group folder display funny in IE they float over the groupbox listing area instead of staying below 6. Language support so far i have only done EN_GB and EN_US. 7. Add a warning message of "duplicate upload" on vcard loaded frame Small bugs to fix. ------------------------------------------------------------------------------------- 1. Hitting enter on the add group when in the input field returns the page to mail 2. Need to sort out the page numbering.. i have been removing this and had the thought of making this click through the contacts in the row column that is currently listed 3. Check to see how LDAP support is working as i don't have a LDAP account so haven't been able to do this 4. Change how the folders get reloaded at the moment its just document write instead of off the DOM (lazy ha). I figured I'd get this fixed once i have a look at the other main changes i want to look (see below). This looked like it would go with what was happening in the functions for settings and its folders. It could become a generic object for all folder directories blah blah blah. 5. Do the database thing for initial and upgrade. I have only worked off the mysql.initial at the mo. Note: altered "contacts" table and added "contactgroup" table (unavoidable). Main fixes to be done (Mainly just tiding up). ------------------------------------------------------------------------------------- 1. Many of the functions that i use have been regurgitated from the mail's set of functions for listing mail. These can be made reusable across the entire board I.E made into common functions. - Prime example is the simply the row functions in app.js 2. Javascript needs revisiting and done the same to as above. I was think of how to make this more object orientated as in a mail object and address-book object - this would make things better for a plug-in styled API as the plugins could extend on those objects. For now the functions just need to be made so that they can be used by both mail and address-book side to decrease file size and make scripting easier. Don't fancy working with large files like this 3. Check for better error catchment.

2 1

[LDAP jpegPhoto support]
by Pierre Mauduit 12 Oct '06

12 Oct '06

Hi folks, First of all, thanks very much for the efforts on roundcube, i love this webmail and use it everyday :-) Since I'm a LDAP user, I was interested in having the JpegPhoto support, so I coded it on my svn copy of roundcube. I give you my patch, hoping that it will be useful. (PS : I generated the patch using "svn diff" command, but it did not attach the file "./program/steps/addressbook/ldapjpegphoto.inc", so I joined it to this mail too, and sorry for my bad english, i'm french). See you -- Pierre Mauduit

1 1

Groups in Addressbook
by Fredrik Håkansson 09 Oct '06

09 Oct '06

Hi! I'm new to this project. I have a question about the addressbook and yes I searched the archived, but couldn't find anything about groups of contacts - is there plans on support this? (To be very clear: I mean a address-card can contain multiple e-mail addresses?) /Fredrik

2 1

Message with only one non-text part
by Robin Elfrink 09 Oct '06

09 Oct '06

Hello, I have a message here, generated by some random Exchange server, with only one mime-part, which is not of type text/* but application/* (excel in this case). RoundCube fails to display it, because it assumes that messages with only one part should have that part as type text/*. Of course I agree with RoundCube, and I wouldn't be surprised if some RFC does as well, but my customers don't so I try to have RoundCube show that part as an attachment. I have modified the following in program/steps/mail/func.inc: @@ -981,6 +982,17 @@ } } } + else + { + if (($fname = $structure->d_parameters['filename']) || + ($fname = $structure->ctype_parameters['name']) || + ($fname = $structure->headers['content-description'])) + { + $structure->filename = rcube_imap::decode_mime_string($fname); + $structure->mimetype = $message_ctype_primary . '/' . $message_ctype_secondary; + $a_attachments[] = $structure; + } + } return array($a_return_parts, $a_attachments); } The single non-text part is now shown as attachment, and can be retrieved by the client, but the content-decoding still needs to be done. Two questions: 1. Is this the right thing, the right place and the right solution? 2. How do I get RoundCube to use the proper decoding for the part? Robin

1 0

Message with only one non-text part
by Robin Elfrink 09 Oct '06

09 Oct '06

1 0

Re: Addressbook improvements, first shot
by shane＠gnative.com 09 Oct '06

09 Oct '06

Hi again.. I'll give you a demo link so that you can see what i mean ni regard to group management of contacts. www.gnative.com/dev/rc/ Warning that this is still under development and i have a few things to sort out before it is fully functional. I'm also using my server as a testing environment as i am currently traveling through Thailand then to china and have only access to Internet cafes so you may find at times it's not fully functional due to testing. No extra tables needed as I'm just adding onto the end of the contact row. Though i think this might conflict with your global contacts idea. I'll have to have a look at what you have done. As for uploading an image. I think the Keep It Simple Stupid approach might be the upload image one . We need to be able to cater for persons not to savvy on link to external images etc and just want to be able to click upload. Not to hard to introduce a thumb nailing script that runs if there is an image module on the php server. I do agree with the "KISS" rule wholeheartedly. Don't know of anyone working on the birthday idea or if there is a need for it. I have just started working on this as well and haven't tried for developer access to svn yet Be good to get some thoughts back Shane > On 10/4/06, shane(a)gnative.com <shane(a)gnative.com> wrote: > > > Paul and dev's. > > Funny i should get this email now, i have just spent the day starting > redeveloping of address book for my personal use (and hopefully others) by > adding the function of grouping contacts. This is using drag and drop, the > same > as mail section and is using the same functions thou i need to sit back > and > address the javascript to make some of the functions universal as i can > see > them being used elsewhere ( actually the javascript is a completely > different > topic and one i would like to bring up once i have the architecture in my > head > more). The functionality will be almost idential to that of apples > addressbook > app. > > > Hello, > I don't know the apples addressbook (I am a linux user) so could you > describe > shortly what this grouping functionality is? Does it allow to share > contacts > (with other users) or is it only a way to display/sort/order your contacts > within the contact list? > > What kind of new db attributes or tables do you need? > > > I'll post a link when i get it near complete just a few things to > finish > off (almost there). > > I'm also implementing vCard support for import and export ( in a > variety of > formats ) i have the scripts handy just need to plug them in.. > > > Great, so I won't develop it on my side (it was my proposal number 3). > > > > Would also like to add the support of upcoming birthday alerts that > can be > turned off in "options". > > > Yes! I had the same idea when I included the birthdate attribute in the > contact profile. Is someone else already working on it? > > > As for the contact image if this is going to be added the we would > need to > look at GD/imagemagik for resizing of uploaded images to be added to the > database when creating a contacts. > > > This depends on how we want to manage images: > - the KISS solution (keep it simple stupid) is to use a link to an image > already hosted on the internet. > Pros: no need for a graphic library, really simple (actually already > supported by the patch I proposed), my contacts can update their image > without > resending me the image > Cons: cross-linking, stability not guaranted (if the image vanishes or > is > renamed, it doesn't work anymore) > - the full solution is to load the image in the db, resize/convert it > Pros: stable > Cons: lots of dev, copyright issues (are you allowed to store these > images?), if you want to update your image you have to send it to your > contacts > and have it reloaded in the db > > I prefer the first solution : simple and more manageable > > > Any other thoughts would be great as I'm fully enjoying getting into > the > redesign of this. > > Shane > > On Wed, 4 Oct 2006 10:29:09 +0200, "Paul Carrasco" > <paul.carrasco(a)gmail.com >> wrote: > > Hello everybody, > > > > I use roundcube for my emails but I think the adressbook is lacking > a lot > > of > > interesting features. > > 1) Ability to store multiple email adresses, phones numbers, > pictures > and > > other info about my contacts > > 2) Ability to share contacts (eg : my contacts could be seen by my > wife, > > since we have some friends in common ;) > > 3) Ability to import/export from csv files or other adequate format > > 4) Ability to display pictures of my contacts when I receive mail > from > > them > > (can anyone remember of the "picons" idea? see > > http://www.cs.indiana.edu/picons/ftp/faq.html#what) > > > > > > So I propose the following: > > 1) see the code below to implement an extended version of the > contacts. > > At the moment it can : > > - eidt, save and display multiple info about your contacts > > - mailto links working with the various emails of the contact > > - I chose not to store the image in the db itself but only a link to > it, > > since it was simpler; but it means cross-linking between your > roudcube > web > > site and the site hosting the image > > Todo : > > - when auto-completing recipient address only the first email of the > > contacts can be matched > > - when adding a new contact, only the first email address is checked > for > > redundancy > > > > 2) Not implemented yet > > To share contacts, I have included a "global" attribute in the > contact > > profile. When set to True this will make the contact visible to > everybody, > > but editable only by the user who created it. > > There will be a config attribute to disable this behaviour. > > > > 3) Not implemented yet, but should'nt be hard > > > > 4) I really like this idea (try gmail to see how it could work). I > think > I > > will add : > > - mouse-over info box that displays the contact profile when the > mouse is > > over a mail > > - when displaying a message, show at the top the picture and some > info > > from > > the addressbook > > > > > > > > Please tell me if you think this can be included in roundcube > 'official' > > version, and in that case I will send you the future updates. > > > > If you find bugs, please send them to me. It seems to work ok for > me. If > > you > > prefer to work with cvs, I can do so, but on the web site it is said > to > > propose code by mail. > > > > Bye > > Paul > > > > > > > > Code to implement feature 1) > > > > A/ DB modification (I use mysql, so this is the code to update the > db > > scheme). > > > > ALTER TABLE `contacts` ADD `email2` VARCHAR( 128 ) NOT NULL , > > ADD `email3` VARCHAR( 128 ) NOT NULL , > > ADD `email4` VARCHAR( 128 ) NOT NULL , > > ADD `im` VARCHAR( 128 ) NOT NULL , > > ADD `homephone` VARCHAR( 128 ) NOT NULL , > > ADD `mobilephone` VARCHAR( 128 ) NOT NULL , > > ADD `workphone` VARCHAR( 128 ) NOT NULL , > > ADD `sip` VARCHAR( 128 ) NOT NULL , > > ADD `webpage` VARCHAR( 256 ) NOT NULL , > > ADD `birthdate` DATE NOT NULL , > > ADD `pgppublickey` TEXT NOT NULL , > > ADD `homeaddress` TEXT NOT NULL , > > ADD `workaddress` TEXT NOT NULL , > > ADD `company` VARCHAR( 128 ) NOT NULL , > > ADD `comments` TEXT NOT NULL , > > ADD `picture` VARCHAR( 256 ) NOT NULL , > > ADD `globalcontact` BOOL NOT NULL ; > > > > > > > > > > B/ Localization files updates (done only for US and fr files) > > US file: program/localization/en_US/labels.inc.php > > // address boook > > $labels['name'] = 'Display name'; > > $labels['firstname'] = 'First name'; > > $labels['surname'] = 'Last name'; > > $labels['email'] = 'E-Mail'; > > //new labels > > $labels[email2] = 'E-Mail 2'; > > $labels[email3] = 'E-Mail 3'; > > $labels[email4] = 'E-Mail 4'; > > $labels[im] = 'Instant messaging'; > > $labels[homephone] = 'Home phone'; > > $labels[mobilephone] = 'Mobile phone'; > > $labels[workphone] = 'Work phone'; > > $labels[sip] = 'SIP'; > > $labels[webpage] = 'Web page'; > > $labels[birthdate] = 'Birth date'; > > $labels[pgppublickey]= 'PGP public key'; > > $labels[homeaddress] = 'Home address'; > > $labels[workaddress] = 'Work address'; > > $labels[company] = 'Company'; > > $labels[comments] = 'Comments'; > > $labels[picture] = 'Picture'; > > $labels[globalcontact]= 'Global contact'; > > > > > > > > fr file: program/localization/fr/labels.inc.php > > // address boook > > $labels['name'] = 'Nom à afficher'; > > $labels['firstname'] = 'Prénom'; > > $labels['surname'] = 'Nom'; > > $labels['email'] = 'e-Mail'; > > //new labels > > $labels[email2] = 'e-Mail 2'; > > $labels[email3] = 'e-Mail 3'; > > $labels[email4] = 'e-Mail 4'; > > $labels[im] = 'Messagerie instantanée'; > > $labels[homephone] = 'Téléphone domicile'; > > $labels[mobilephone] = 'Téléphone mobile'; > > $labels[workphone] = 'Téléphone professionnel'; > > $labels[sip] = 'SIP'; > > $labels[webpage] = 'Page web'; > > $labels[birthdate] = 'Date de naissance'; > > $labels[pgppublickey]= 'Clé publique PGP'; > > $labels[homeaddress] = 'Adresse domicile'; > > $labels[workaddress] = 'Adresse professionnelle'; > > $labels[company] = 'Société'; > > $labels[comments] = 'Commentaires'; > > $labels[picture] = 'Image'; > > $labels[globalcontact]= 'Contact global'; > > > > > > > > > > C/ New config options > > To be appended at the end of the file: config/main.inc.php > > // addressbook configuration > > // chose which columns in the addressbook to enable, the columns are > > displayed in the specified order > > $rcmail_config['addressbook_show_cols'] = array('picture', 'name', > > 'firstname', 'surname', 'email', 'email2', 'email3', 'email4', 'im', > > 'homephone', 'mobilephone', 'workphone', 'sip', 'webpage', > 'birthdate', > > 'pgppublickey', 'homeaddress', 'workaddress', 'company', 'comments', > > 'globalcontact'); > > > > // image size in address book > > $rcmail_config['addressbook_image_width'] = '100'; > > $rcmail_config['addressbook_image_height'] = '100'; > > > > // enable global contacts > > $rcmail_config['adressbook_enable_global_contacts'] = 'true'; > > > > > > > > > > > > D/ Show contact update > > Update the rcmail_contact_details function in the file: > > program/steps/addressbook/show.inc > > function rcmail_contact_details($attrib) > > { > > global $CONFIG, $CONTACT_RECORD, $JS_OBJECT_NAME; > > > > if (!$CONTACT_RECORD) > > return show_message('contactnotfound'); > > > > // a specific part is requested > > if ($attrib['part']) > > return > rep_specialchars_output($CONTACT_RECORD[$attrib['part']]); > > > > > > // return the complete address record as table > > $out = "<table>\n\n"; > > > > $a_show_cols = $CONFIG['addressbook_show_cols']; > > foreach ($a_show_cols as $col) > > { > > if (substr($col,0,5)=='email' && $CONTACT_RECORD[$col]) > > $value = sprintf('<a href="#compose" > > __removed="%s.command(\'compose\', > > \'%d_%s\')" title="%s">%s</a>', > > $JS_OBJECT_NAME, > > $CONTACT_RECORD['contact_id'], > > $col, > > rcube_label('composeto'), > > $CONTACT_RECORD[$col]); > > elseif ($col=="picture" && $CONTACT_RECORD[$col]) > > $value = sprintf('<img height="%s" width="%s" src="%s" />', > > $CONFIG['addressbook_image_height'], > > $CONFIG['addressbook_image_width'], > > $CONTACT_RECORD[$col]); > > else > > $value = rep_specialchars_output($CONTACT_RECORD[$col]); > > > > $title = rcube_label($col); > > $out .= sprintf("<tr><td > class=\"title\">%s</td><td>%s</td></tr>\n", > > $title, $value); > > } > > > > > > $out .= "\n</table>"; > > > > return $out; > > } > > > > > > > > > > E/ Edit contact update > > Update the rcmail_contact_editform function in the file: > > program/steps/addressbook/edit.inc > > function rcmail_contact_editform($attrib) > > { > > global $CONFIG, $CONTACT_RECORD, $JS_OBJECT_NAME; > > > > if (!$CONTACT_RECORD && $GLOBALS['_action']!='add') > > return rcube_label('contactnotfound'); > > > > // add some labels to client > > rcube_add_label('noemailwarning'); > > rcube_add_label('nonamewarning'); > > > > list($form_start, $form_end) = get_form_tags($attrib); > > unset($attrib['form']); > > > > > > // a specific part is requested > > if ($attrib['part']) > > { > > $out = $form_start; > > $out .= rcmail_get_edit_field($attrib['part'], > > $CONTACT_RECORD[$attrib['part']], $attrib); > > return $out; > > } > > > > > > // return the complete address edit form as table > > $out = "$form_start<table>\n\n"; > > > > #$a_show_cols = array('name', 'firstname', 'surname', 'email'); > > $a_show_cols = $CONFIG['addressbook_show_cols']; > > foreach ($a_show_cols as $col) > > { > > $attrib['id'] = 'rcmfd_'.$col; > > $title = rcube_label($col); > > if (($col=='homeaddress' || $col=='workaddress' || > $col=='comments') > > && > > $CONTACT_RECORD[$col]) > > $value = rcmail_get_edit_field($col, $CONTACT_RECORD[$col], > $attrib, > > 'textarea'); > > else > > $value = rcmail_get_edit_field($col, $CONTACT_RECORD[$col], > > $attrib); > > > > $out .= sprintf("<tr><td class=\"title\"><label > > for=\"%s\">%s</label></td><td>%s</td></tr>\n", > > $attrib['id'], > > $title, > > $value); > > } > > > > $out .= "\n</table>$form_end"; > > > > return $out; > > } > > > > > > > > F/ Save contact update > > Replace the line > > $a_save_cols = array('name', 'firstname', 'surname', 'email'); > > by > > $a_save_cols = $CONFIG['addressbook_show_cols']; > > in the file: program/steps/addressbook/save.inc > > > > > > > > > > G/ Compose mail update (to to chose not only the first email, but > also > one > > of the others depending on which link was clicked in the contact > profile) > > Update the "case 'to'" in the compose action, in the file: > > program/steps/mail/compose.inc > > case 'to': > > $fname = '_to'; > > $header = 'to'; > > > > // we have contact id's as get parameters > > if (!empty($_GET['_to']) && preg_match('/^[0-9]+(,[0-9]+)*$/', > > $_GET['_to'])) > > { > > $a_recipients = array(); > > $sql_result = $DB->query("SELECT name, email > > FROM > ".get_table_name('contacts')." > > WHERE user_id=? > > AND del<>1 > > AND contact_id IN > > (".$_GET['_to'].")", > > $_SESSION['user_id']); > > > > while ($sql_arr = $DB->fetch_assoc($sql_result)) > > $a_recipients[] = > format_email_recipient($sql_arr['email'], > > $sql_arr['name']); > > > > if (sizeof($a_recipients)) > > $fvalue = join(', ', $a_recipients); > > } > > else if (!empty($_GET['_to']) && > > preg_match('/^[0-9]+_email[0-9]*$/', > > $_GET['_to'])) > > { > > $a_recipients = array(); > > preg_match('/^([0-9])+_(email[0-9]*)$/', $_GET['_to'], > $matches); > > $sql_result = $DB->query("SELECT name, ".$matches[2]." > > FROM > ".get_table_name('contacts')." > > WHERE user_id=? > > AND del<>1 > > AND contact_id IN > (".$matches[1].")", > > $_SESSION['user_id']); > > > > while ($sql_arr = $DB->fetch_assoc($sql_result)) > > $a_recipients[] = > format_email_recipient($sql_arr[$matches[2]], > > $sql_arr['name']); > > > > if (sizeof($a_recipients)) > > $fvalue = join(', ', $a_recipients); > > } > > > > else if (!empty($_GET['_to'])) > > $fvalue = $_GET['_to']; > > > > > > > > ---------------------------------------------------------------------------------------------------- > Variety is the spice of life .. except in Thailand where the > spice > makes > your life slip out your arsehole. > > ---------------------------------------------------------------------- ---------------------------------------------------------------------------------------------------- Variety is the spice of life .. except in Thailand where the spice makes your life slip out your arsehole. ----------------------------------------------------------------------------------------------------

2 1

Encoding question & BG lang update
by NetOne - Doichin Dokov 06 Oct '06

06 Oct '06

Hi all, There's a minor change in BG localization files, fixing a problem which prevented the Empty link from showing up. The latest files are published at http://mirror.net1.cc/projects/roundcubemail%20-%20bg%20language/ I would also like to drive your attention to bug #1483839 <http://trac.roundcube.net/trac.cgi/ticket/1483839> , I see a lot of other bugs posted to the tracker, related to this one - encoding problems. Bugs related - 1424900, 1473561, may be some others too. I think something should be decided about default encoding, it's a general issue for non-english users / testers. Regards, Doichin

1 0

Access keys
by Chris Hembrow 06 Oct '06

06 Oct '06

Hi I've created a patch for SVN to add accesskeys to some of the main functions. This means that you can compose, reply, delete, select etc... from the keyboard. I wasn't sure about the best way to do this, and this is the first time I've contributed to an oss project, so I've attached a gzip with a diff file for each of the affected files. If I've c0cked anything up, I apologise in advance :p Chris

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev