Dev

dev@lists.roundcube.net

2 participants
4301 discussions

[PATCH] Fix PHP Warning in imap.php
by Mark Bucciarelli 01 May '06

01 May '06

With debug_level = 4, I was getting the following warning output when I clicked on a folder: Warning: mktime() expects parameter 5 to be long, string given in /usr/local/src/roundcube-cvs/roundcubemail/program/lib/imap.inc on line 625 The message index would not display sometimes; for example, 1. click on trash 2. drag message (unread) to inbox 3. click on inbox (yup, msg there) 4. click on trash (no message index displayed) Very strange, as when I viewed the source the table that display the message index was there. When I fixed the warning by casting to an int, the behavior was fixed. # diff -u program/lib/imap.inc.orig program/lib/imap.inc --- program/lib/imap.inc.orig Wed Apr 26 17:01:40 2006 +++ program/lib/imap.inc Wed Apr 26 17:03:01 2006 @@ -611,7 +611,7 @@ //$month_a=array("Jan"=>1,"Feb"=>2,"Mar"=>3,"Apr"=>4,"May"=>5,"Jun"=>6,"Jul"=>7,"Aug"=>8,"Sep"=>9,"Oct"=>10,"Nov"=>11,"Dec"=>12); $month_str=$a[1]; $month=$IMAP_MONTHS[$month_str]; - $day=$a[0]; + $day=(int)$a[0]; $year=$a[2]; $time=$a[3]; $tz_str = $a[4]; # I'll stick this (and my README patch) in sf.net as a patch so it doesn't get lost in the mailing list. -- Mark Bucciarelli GAIA Host Collective, LLC web: http://www.gaiahost.coop ----------------------------------- ~~~~~~~~~~~~~~~~ "Reliable internet solutions from an environmentally and socially concerned worker collective" ~~~~~~~~~~~~~~~~

3 3

Integrating Googiespell in Roundcube
by phil 01 May '06

01 May '06

I have tried the spellcheck option already out there, but want to see about integrating Googiespell [http://amix.dk/projects/?page_id=3] into Roundcube. From the demo you see that it's as slick as it is in Gmail, so I've started another HOWTO to cover this, but can't figure out how to integrate it into the existing 'compose' textarea. Can someone take a look? The documentation on the site makes it look very simple [http://amix.dk/projects/?page_id=3#How_to_use_the_script_] Here's where I am so far with my HOWTO: ----- cd /usr/local/www/data-dist/ cp -Rp roundcube roundcube-dev cd roundcube-dev wget http://amix.dk/projects/uploads/googiespell_v3.zip unzip googiespell_v3.zip cp googiespell_v3/googiespell/AmiJS.js googiespell_v3/googiespell/googiespell.js program/js/ cp googiespell_v3/googiespell/googiespell.css skins/default/ ----- After this is done, it says to add "...the code you will need to decorate a textarea with GoogieSpell: <form> <textarea id="ta1" class="textarea">Ths is a tst</textarea> </form> <script type="text/javascript"> var googie1 = new GoogieSpell("googiespell/", "http://www.google.com/tbproxy/spell?lang="); googie1.decorateTextarea("ta1"); </script> But I can't figure out where this goes. So far I've created a program/include/rcube_googiespell.inc file with the above, but don't know how it needs to hook into compose.inc. Anyone with a bit more include knowledge out there want to fix it? We only need 1-2 more steps to get this working While it does rely on Google, it is GPL and it 'could' be included in RC, or it could just be another plugin for users to choose from. Either way this is the nicest looking option I've seen, and the most RC like to boot. Thanks P -- http://fak3r.com - you dont have to kick it

3 2

Large mailboxes
by Mark Edwards 01 May '06

01 May '06

Roundcube seems to have some difficulty dealing with large mailboxes (large meaning thousands of messages). It can manage indexing one of these, but if I try to actually show a message in a large mailbox, it basically hangs. When this happens, the browser just sits there waiting for a reply, and I can do a 'top' on the server and watch the apache process just eat up memory until it finally dies. It seems that Roundcube is digging through the mail and not releasing memory in some way, which becomes a problem as the mailbox size gets large. At least that's my theory. Does anyone else observe this? This is with Apache 1.3.34, PHP 5.1.2, MySQL 4.1.18 and Cyrus 2.2.12, running on FreeBSD 4.11p14. Thanks! -- Mark Edwards

16 42

[PATCH] tinyMCE HTML editor
by Salvatore Ansani 01 May '06

01 May '06

Hi guys, attach is patch to use tinyMCE HTML editor on roundcube. I didin't found any error on sendig TEXT or HTML mails. Hope you too ;) Download tinyMCE and extract it on same folder of roundcube (so we have in root roundcube folder this tree: tinymce/jscripts/tiny_mce/) Play and FIND bugs :) -- Bau, Salvatore -----BEGIN GEEK CODE BLOCK----- Version: 3.12 GIT d- s:+++ a- C++++ UL++ P++ L++++ E--- W+++ N+++ o+ K+++++ w+ O+ M+ V-- PS--- PE+ Y+++ PGP t--- 5 X R++ tv++ b++++ DI+ D++ G+ e++ h+ r++ y++ ------END GEEK CODE BLOCK------

2 1

Some changes on priority treatment..
by Krishna Oliveira de Hollanda Padilha 30 Apr '06

30 Apr '06

Hi All, I've made some changes on the way that priority emails are treated, if the chosen priority is High or Highest I've managed to add Disposition-Notification and Return-Recept to message. The code snippet is (it must be changed on sendmail.inc on lines 131-141): if (!empty($_POST['_priority'])) { $priority = (int)$_POST['_priority']; $a_priorities = array(5=>'lowest', 4=>'low', 2=>'high', 1=>'highest'); if ($str_priority = $a_priorities[$priority]) $headers['X-Priority'] = sprintf("%d (%s)", $priority, ucfirst($str_priority)); if ($a_priorities[$priority] < 3) { $headers['Return-Receipt-To'] = $identity_arr['string']; $headers['Disposition-Notification-To'] = $identity_arr['string']; } } Regards, Krishna Padilha

2 2

Composing HTML mails
by Salvatore Ansani 30 Apr '06

30 Apr '06

Hi guys, I've done some patchs to use HTML TinyMCE editor to compose (and send of course ;) ...) HTML emails. If anyone want to test and use this HTML editor, I can upload patchs to my website or send to M/L -- Regards, Salvatore -----BEGIN GEEK CODE BLOCK----- Version: 3.12 GIT d- s:+++ a- C++++ UL++ P++ L++++ E--- W+++ N+++ o+ K+++++ w+ O+ M+ V-- PS--- PE+ Y+++ PGP t--- 5 X R++ tv++ b++++ DI+ D++ G+ e++ h+ r++ y++ ------END GEEK CODE BLOCK------

3 2

Re: major change to deletion process
by Charles McNulty 28 Apr '06

28 Apr '06

Derek Hinchliffe wrote: > On 4/28/06, Charles McNulty <charles(a)charlesmcnulty.com> wrote: > .... >> 2) If you don't have a trash folder defined messages are flagged as >> deleted and the deleted style is applied to them. >> By default the deleted style will be "display: none" meaning they >> will disappear and things will appear to have not changed > > Just a quick comment... > > If CSS 'display:none' is used to hide the deleted messages will things > like the display of how many messages are shown (eg. "Messages 1 to 30 > of 300") be misleading? Also, could it interfere with list > manipulation routines like "Select All" - possibly resulting in > messages being selected that you weren't expecting to be? > > Cheers > Derek > Possibly. I'll look into that. In the current system they are also set to display: none, but in a more direct way. In the new system the row has a new class appended to the className. In the old system the style was assigned display: none directly. In the old system to detect if a message was hidden was trivial, just look at the style. In the new system you have to look at the class to see what display is set to. I know that that was never done elsewhere in the code, so it's possible that totals could be messed up. -Charles

1 0

IMAP Inbox folder cache
by Colin Alston 27 Apr '06

27 Apr '06

Hi I have this weird issue with my installation of RoundCube. It may very well have already been fixed, so just LART me if its a known issue. What happens is with Courier-IMAP when one someone logs into RoundCube, it takes them to their Inbox but they do not see any new mail. If you open any other folder, and then return to your inbox then all is well, but this is leading other people to a bit of confusion. -- Colin Alston <karnaugh(a)karnaugh.za.net> http://www.karnaugh.za.net/ "There have been hacker forums where, out of some misguided sense of hyper-courtesy, participants are banned from posting any fault-finding with another's posts, and told ''Don't say anything if you're unwilling to help the user.'' The resulting departure of clueful participants to elsewhere causes them to descend into meaningless babble and become useless as technical forums." - Eric Steven Raymond

2 1

arabic lang. supportin your project
by IYad ELkfarna 26 Apr '06

26 Apr '06

Dear sir i see your projct of the webmail really fantastic and very nice but it is will be good if it support arabic langouge , i can help in arabic support , and really need that , and it is good if you make them to your mail , thanks in advance _________________________________________________________________ Dont just search. Find. Check out the new MSN Search! http://search.msn.click-url.com/go/onm00200636ave/direct/01/

1 0

hanging double quote in header
by Charles McNulty 26 Apr '06

26 Apr '06

I recieved the following message which RC choked on: .. To: dell(a)popquizhotshot.com Subject: Savings like this never looked so good! From: Dell Member Program <Dell_Member_Programs(a)dell.com>" Date: Fri, 21 Apr 2006 13:17:17 -0600 Reply-To: "Dell Subscription Services" <subscription_services(a)dell.com> Content-Type: multipart/alternative; boundary="______BoundaryOfDocument______" .. Notice the double quote just hanging out there in the From address. This fubars the HTML which then messes up the JS call. It would seem that we need to escape headers. -Charles

3 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev