Dev

dev@lists.roundcube.net

1 participants
4293 discussions

Scrolling problem on Safari
by Jacob Brunson 19 Feb '06

19 Feb '06

I recently found this problem with Safari (versions 1.3.2, but also with newer tiger versions). The problem is that clicking on the message list scroll bar to scroll up and down through the list doesn't work. The scroll bar doesn't go anywhere. However, if you press the ctrl key down while clicking on the scroll bar, it works fine. There is a similar problem with the Apple key. After selecting anything on the message list, using the apple modifier key doesn't work. This is a problem because Apple-N opens new windows, Apple-W closes the current window. Now macs only usually have one mouse button. Ctrl-click serves as a right click. However, I connected a two button mouse and right clicking on the scroll bar doesn't cause it to move, just a ctrl-click. I've tracked the problem down to a particular change. It is in program/js/app.js between cvs revisions 1.28 and 1.29 (for that file). http://cvs.sourceforge.net/viewcvs.py/roundcubemail/roundcubemail/program/j… I applied the differences between these two revisions one by one, and I found the difference that caused scrolling to break. The diff that causes it to break is the one that begins on line Line 246/249. (Lines 255 through 307 in current cvs head) It is a large chunk of code, and I'm not sure exactly what is causing the problem, I thought I would ask here and see if anyone had any ideas. I would be glad to work with to get this resolved. I know few people have macs, so I would be glad to apply patches and report results. --Jacob Brunson

2 4

postgres on recent cvs tarball
by Andy Burns 19 Feb '06

19 Feb '06

Hi, managed to get roundcube working with postgres from the first cvs snapshot last year (took some minor tweaks), noticed a new snapshot so thought I'd check it out again. I cleaned out all tables/sequences from my old database. There is one typo in the postgres_initial.sql file on the messages table the session_id should refer to foreign key "sess_id" in the sessions table, not to "session_id" which doesn't exist. With that done, and changes made to config/db.inc.php and config/main.inc.php I can log in to roundcube ok, but when rcube_imap.inc is populating the messages table I get lots of errors like DB Error: unknown error Query: INSERT INTO messages (user_id, del, cache_key, created, idx, uid, subject, "from", "to", cc, date, size, headers) VALUES ('1', 0, 'INBOX.msg', now(), '787', '33125', '[LinuxFailSafe] Re: LinuxFailSafe Digest, Vol 3, Issue 1', 'David Brower ', 'linuxfailsafe(a)lists.community.tummy.com', FALSE, '2006-02-10 19:48:40', 5381, 'O:14:"iilbasicheader":25:{s:2:"id";s:3:"787";s:3:"uid";s:5:"33125";s:7:"subject";s:56:"[LinuxFailSafe] Re: LinuxFailSafe Digest, Vol 3, Issue 1";s:4:"from";s:38:"Da I've looked at where this query is built up, is it possible that the substr($this->decode_header((string)$headers->cc, TRUE), 0, 128) is returning "FALSE" instead of an empty string when cc: from header is blank? see the FALSE between the "tummy.com" and the date? I also tried usign MDB2 instead of DB2 but got errors about prepare() function not existing, I tried to revert it to just use execute() instead of prepare+execute but didn't help. I know this is still pre-beta, but I thought postgres support was supposed to actually work now?

3 3

mail.force_extra_parameters patch
by Tadashi Jokagi 18 Feb '06

18 Feb '06

Hi, I made patch for sendmail.inc http://elf.no-ip.org/~elf/contribute/roundcubewebmail/2006-02-18/mail-force… In safe_mode, mail() cannot use the 5th argument. The 5th argument can be set up by ini_set() with PHP 5. This patch adds that feature. Thanks, -- ----+----1----+----2----+----3----+----4----+----5----+----6----+----7 Tadashi Jokagi mailto:elf2000@users.sourceforge.net http://elf.no-ip.org/ http://blog.poyo.jp/ http://wiki.poyo.jp/ Open Source Calendar -- http://oss.poyo.jp/calendar/ Serendipity Japanese -- http://oss.poyo.jp/s9y-ja/ Fedora Planet Japanese -- http://oss.poyo.jp/fedora/planet/

1 0

stripslashes
by Dean Jones 17 Feb '06

17 Feb '06

Look like someone forgot to use stripslashes on the subject and body of the messages... :) Is there a standard for checking in patches if you have access to CVS? I've fixed this, but I wanted to check and see what the procedure was for checking in small fixes like this. Dean

5 16

Re: 2 ideas ..
by Jon Daley 17 Feb '06

17 Feb '06

Please reply on-list, since as you can see, I don't really know what I am talking about... (: I hadn't thought about the case where your web server is not the imap server as well, so you would actually want it to connect to the other server. I guess what you want in the default_host array is a flag to say whether to just append the server name to the login, and connect to the localhost, or actually connect to the remote host. On Fri, 17 Feb 2006, Mykeul wrote: > Hum.. Here I see I wasnt clear enough. > I try again. > > Lets say I use $rcmail_config['default_host'] = array("slashdot.org"," > microsoft.com"); in my config file. > I login as : > login : myname > pass : mypass > server : slashdot.org > >> From what I see, RC connects to the host "slashdot.org" on port 143, asking > for LOGIN myname(a)slashdot.org mypass . > I hope you are OK with that, otherwise I misunderstood something. > > Now lets say the host "slashdot.org" is the dedicated web server, and the > imap server is "imap.slashdot.org". Now we have a problem because RC will > try to connect to the web server instead of the imap server. And if you > enter "imap.slashdot.org" in the $rcmail_config['default_host'] array, OK it > will connect to imap.slashdot.org, but asking for LOGIN > myname(a)imap.slashdot.org mypass. > Is it OK ? If it is, then re-read my last mail please. If not, explain me > what i am wrong > > I dont understand what you mean by "instead of handling the login itself". > Do you mean that it does NOT add @slashdot.org to the login when connecting > to the imap server ? > > Thanks for your help anyway, > > Mykeul > > > On 2/17/06, Jon Daley <roundcube(a)jon.limedaley.com> wrote: >> >> Hrm, that sounds like strange behavior to me. Does roundcube >> really redirect your request to slashdot, instead of handling the login >> itself? >> >> On Fri, 17 Feb 2006, Mykeul wrote: >>> Yes but this is a "server" field, so with your example, you get a >> pulldown >>> menu with "slashdot.org" and "microsoft.com" and if I enter "myname" as >> a >>> login, RC will try to authenticate myname(a)slashdot.org by connecting to >> host >>> "slashdot.org". >>> >>> OK in many situations that is fine. However, in my architecture, the >> server >>> resolved as "mydomain.com" is not the imap server and cannot be it. >>> I suggest an array, or a mysql table, with 3 (or 4) fields >> "display_name", >>> "domain", "host" (and maybe "port"). So in the login you can show the >>> "display_name" (for example showing "DELL France" instead of " >> fr.dell.com") >>> then add the "domain" field to the RC login field to get the entire >> email, >>> and finally connect to the "host" field (i.e. mail458.dijon.fr.dell.com, >> and >>> maybe on "port" port) to make the request. >>> I hope i was clear enough because I'm not very good at explaining >> things. >>> >>> Thanks, >>> >>> Mykeul >>> >>> On 2/17/06, Jon Daley <roundcube(a)jon.limedaley.com> wrote: >>>> >>>> On Fri, 17 Feb 2006, Mykeul wrote: >>>>> - Add a "domain" field in the login form, which may be populated form >> a >>>> file >>>>> or a mysql table, so that the users dont have to write >> username@domainil >>>>> the login field. It is useful for multi domains hosts. (I saw >> something >>>>> talking about a relation host/domain in the config file but I didnt >>>>> understand) >>>> >>>> You know that you can do this, right? >>>> >>>> $rcmail_config['default_host'] = >>>> array("slashdot.org","microsoft.com"); >>>> >>>> >>>> >>>> >>>> >>> >> >> ************************************** >> Jon Daley >> http://jon.limedaley.com/ >> >> The problem with the gene pool is that there is no lifeguard. >> >> >> > ************************************** Jon Daley http://jon.limedaley.com/ Any tool, when dropped, will roll into the least accessible corner. -- Anthony's Law of the Workshop

2 1

[Bug] txt attachments
by Mykeul 17 Feb '06

17 Feb '06

Hi there, I think I found a bug, when I attach a text file. Let's say I have a myfile.txt file containing "blablabla". I compose a new mail, I attach this txt file, I write "this is the body of the message" in the body, and I send it to myself. With the CVS version, when I click on the attachment in the received mail, I get "<pre>this is the body of the message</pre>" instead of "blablabla". If I open the same mail with the non-CVS version or another webmail, it shows "blablabla". If I rename myfile.txt to myfile.doc without changing what is inside, and send it to myself. The CVS version shows "blablabla", just as it should. Am I alone with this problem ? Thanks, Mykeul

3 3

Re: 2 ideas ..
by Jon Daley 17 Feb '06

17 Feb '06

Hrm, that sounds like strange behavior to me. Does roundcube really redirect your request to slashdot, instead of handling the login itself? On Fri, 17 Feb 2006, Mykeul wrote: > Yes but this is a "server" field, so with your example, you get a pulldown > menu with "slashdot.org" and "microsoft.com" and if I enter "myname" as a > login, RC will try to authenticate myname(a)slashdot.org by connecting to host > "slashdot.org". > > OK in many situations that is fine. However, in my architecture, the server > resolved as "mydomain.com" is not the imap server and cannot be it. > I suggest an array, or a mysql table, with 3 (or 4) fields "display_name", > "domain", "host" (and maybe "port"). So in the login you can show the > "display_name" (for example showing "DELL France" instead of "fr.dell.com") > then add the "domain" field to the RC login field to get the entire email, > and finally connect to the "host" field (i.e. mail458.dijon.fr.dell.com, and > maybe on "port" port) to make the request. > I hope i was clear enough because I'm not very good at explaining things. > > Thanks, > > Mykeul > > On 2/17/06, Jon Daley <roundcube(a)jon.limedaley.com> wrote: >> >> On Fri, 17 Feb 2006, Mykeul wrote: >>> - Add a "domain" field in the login form, which may be populated form a >> file >>> or a mysql table, so that the users dont have to write username@domainil >>> the login field. It is useful for multi domains hosts. (I saw something >>> talking about a relation host/domain in the config file but I didnt >>> understand) >> >> You know that you can do this, right? >> >> $rcmail_config['default_host'] = >> array("slashdot.org","microsoft.com"); >> >> >> >> >> > ************************************** Jon Daley http://jon.limedaley.com/ The problem with the gene pool is that there is no lifeguard.

1 0

2 ideas ..
by Mykeul 17 Feb '06

17 Feb '06

Hi there, I thought about 2 features, possibly simple to implement, I hope you will find them useful : - Add a "domain" field in the login form, which may be populated form a file or a mysql table, so that the users dont have to write username@domain il the login field. It is useful for multi domains hosts. (I saw something talking about a relation host/domain in the config file but I didnt understand) - We often edit message before putting them into a subdirectory, mainly to change the subject for future searches, or to add phone numbers. So an "edit message" feature would be nice. I took a look at where to modify the login form but only find the function call in the template and the function in another file, and I don't see where the field are declared. Thanks, Mykeul

2 1

[PATCH] Message list \'Delete\' key
by dave＠roweware.com 17 Feb '06

17 Feb '06

Hello, Attached is a patch enabling the Delete key in the message listing to allow quick navigation and disposal of unwanted mail. Given you can already traverse the list using the directional keypad, this adds to that. Someone want to add a handler for the Enter keypress to enable viewing of the message? Im not familiar enough with the code yet to know what event that is... Any comments? -- Dave dave(a)roweware.com

1 0

Re: [PATCH] Add / Edit Contact (Address Book)
by dave＠roweware.com 17 Feb '06

17 Feb '06

Looks like I accidently picked up the patch file in the patch itself (first line) :/ Attached is a new patch... Thanks, Dave On Thu, 16 Feb 2006 18:26:49 -0700, dave(a)roweware.com wrote: > > Attached is a small patch that enables the \'Enter\' key to submit the > form when adding or editing contacts within the Address Book.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev