Dev

dev@lists.roundcube.net

4291 discussions

Format of GitHub messages in SVN list
by Michael Heydekamp 12 Dec '12

12 Dec '12

I sent this message to the SVN list already, but it appears that it doesn't arrive there (but I did also not receive a rejection through a moderator message). Since the move from SVN to GitHub, the format of the messages in the SVN list looks a bit strange to me: 1) Roundcube is displaying the attachment icon for each message, although there is no attachment at all in any of the messages. 2) All messages are declared as "multitype/mixed" for no real reason (the second part just containing the signature, this could perfectly be appended to the first part without creating a second part). 3) The Content-Type of the first part (i.e. the real content of the message) is "text/plain; charset=UTF-8", the Content-Transfer-Encoding "7bit". If CTE is 7bit, shouldn't the charset be "US-ASCII" then? The UTF-8 declaration will probably (and unnecessarily) invoke a decoding routine in most MUAs, although there is nothing to decode. 2) and 3) are minor issues, but 1) (the attachment icon) appears to be a wrong indication. Not sure if the declaration of the messages is misleading in some way, or if Roundcube's interpretation is wrong? If the latter, this could also affect any other messages. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

4 9

Re: [RCD] git-pull am 11.11. nicht geklappt? (was: [Svn] [roundcube/roundcubemail] d9f109: Allow forwarding of multiple emails (#1486854))
by Michael Heydekamp 12 Dec '12

12 Dec '12

Sorry, this mail shouldn' have gone to the list. Grrr... -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 12.12.2012 20:16, schrieb Michael Heydekamp: > Hallo Martin, > > siehe unten. Kannst Du da was feststellen? > > Gruß, > -- > Michael Heydekamp > xxxxxxxxxxxxx > xxxxxxxxxxxxxxxxxx > Tel.: xxxxxxxxxxxxxxxxxx (privat) > Tel.: xxxxxxxxxxxxxxxxxxxx (Büro) > Fax: xxxxxxxxxxxxxxxxx (Büro) > Mobil: xxxxxxxxxxxxxxxxxx > eMail: xxxxxxxxxxxxxxxxxxxx > WWW: xxxxxxxxxxxxxxxxxxxxxxx > > > Am 12.12.2012 20:10, schrieb Michael Heydekamp: >> Am 12.12.2012 19:10, schrieb A.L.E.C: >>> On 12/12/2012 06:50 PM, Michael Heydekamp wrote: >> >>>> How does this feature work? >>>> >>>> If I mark more than one message, the forward button is being disabled. >>> >>> Works for me. Forward button is enabled, only "forward inline" is disabled. >> >> Sorry, I wasn't careful enough. Due to some still unknown reason, our >> git-pull seems to have failed last night, as I'm still running "GIT >> 20121210.2232". Therefore it's more than logical that your commit of Dec >> 11th can't work here. Sorry... >> -- >> Michael Heydekamp >> Co-Admin freexp.de >> Düsseldorf/Germany >> _______________________________________________ >> Roundcube Development discussion mailing list >> dev(a)lists.roundcube.net >> http://lists.roundcube.net/mailman/listinfo/dev

1 0

Re: [RCD] [Svn] [roundcube/roundcubemail] d9f109: Allow forwarding of multiple emails (#1486854)
by Michael Heydekamp 12 Dec '12

12 Dec '12

How does this feature work? If I mark more than one message, the forward button is being disabled. -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 11.12.2012 08:33, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: d9f109b56af2015eae7aadc5e87c06365854eda0 > > https://github.com/roundcube/roundcubemail/commit/d9f109b56af2015eae7aadc5e… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2012-12-10 (Mon, 10 Dec 2012) > > Changed paths: > M CHANGELOG > M program/js/app.js > M program/steps/mail/compose.inc > M program/steps/mail/sendmail.inc > M skins/classic/includes/messagetoolbar.html > M skins/larry/includes/mailtoolbar.html > > Log Message: > ----------- > Allow forwarding of multiple emails (#1486854) > > > Commit: 25bf00ecbc2cab20ce66845513980b83b03f7c49 > > https://github.com/roundcube/roundcubemail/commit/25bf00ecbc2cab20ce6684551… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2012-12-10 (Mon, 10 Dec 2012) > > Changed paths: > M program/lib/Roundcube/rcube_message.php > M program/lib/Roundcube/rcube_message_header.php > M program/steps/mail/func.inc > M program/steps/mail/get.inc > M skins/classic/mail.css > M skins/larry/mail.css > M skins/larry/templates/message.html > M skins/larry/templates/messagepreview.html > > Log Message: > ----------- > Merge branch 'master' of github.com:roundcube/roundcubemail > > > Compare: > https://github.com/roundcube/roundcubemail/compare/31521613e40b...25bf00ecb… > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

2 2

New attachment mime-type validation
by Thomas Bruederli 11 Dec '12

11 Dec '12

Hello folks Today we introduced a new validation mechanism for message attachments which are supposed to be displayed inside the browser. Mainly inspired by a recently reported XSS vulnerability [1], the mime-types and filenames extensions stated in the message part headers are now checked against the real mime-type of the effective part bodies. This also requires the filename extension (e.g. ".png") to match the real mime-type of the according attachment. In order to reliably detect mime-types and the matching filename extensions, Roundcube and PHP need to be configured properly: On PHP >= 5.3, we recommend to set $rcmail_config['mime_magic'] = null; which lets the fileinfo module of PHP use its default location for the magic numbers mapping file. The other config option which is important for these new checks is $rcmail_config['mime_types'] = '<path-to-apache-config>/mime.types'; This value should refer to the mime.types file used by the Apache web server to send the right mime-types for static files. If left empty, Roundcube will search for it in some default locations such as /etc/httpd/mime.types but for performance reasons, it's better to set this option right away. In case you can't find such a file on your server, especially when not running apache, you can download it from [2]. Now, with the new attachment validation in place, your users might see some yellow warnings (see attached image) because sometimes email messages are just incorrectly formatted even if all the contents are safe. Clicking the button will let the user see the attachment anyhow but since this is all new, we're seriously interested in your feedback and common problems resulting from this new check. I hope we can then fine-tune it a bit and catch some common and harmless cases. Cheers, Thomas [1] http://trac.roundcube.net/ticket/1488828 [2] http://svn.apache.org/repos/asf/httpd/httpd/trunk/docs/conf/mime.types

5 9

Re: [RCD] [Svn] [roundcube/roundcubemail] 30cc01: Use Delivered-To header as a last resort for identity selection (#1488840)
by Michael Heydekamp 08 Dec '12

08 Dec '12

Ironically, the change quoted below doesn't help in all Roundcube mailing lists, as the Delivered-To header of Roundcube list does look like this: > Delivered-To: dev-at-lists-dot-roundcube-dot-net(a)lists.roundcube.net So the identity still needs to be changed manually. Wouldn't it be worth thinking of adding an option to the addressbook? I mean, this issue does not apply to mailing lists only (and there even to replies only!), but also to private and business related messages. So assigning an identity to a specific addressbook entry could really be helpful, as it would then also apply to new messages. Of course, there would still be an issue when adding more recipients to the To:/Cc:/Bcc: fields which may have different identities assigned, but then the identity assigned to the first address in the To: field shall be the one and only to win, IMO. Greets, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 28.11.2012 20:41, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: 30cc01f89daea932d15a1a505d25b543913664ac > > https://github.com/roundcube/roundcubemail/commit/30cc01f89daea932d15a1a505… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2012-11-28 (Wed, 28 Nov 2012) > > Changed paths: > M CHANGELOG > M program/lib/Roundcube/rcube_imap_generic.php > M program/lib/Roundcube/rcube_storage.php > M program/steps/mail/compose.inc > > Log Message: > ----------- > Use Delivered-To header as a last resort for identity selection (#1488840) > > > Commit: 0247b89c38c7f7ef1a2111239c6a1c8c13394d93 > > https://github.com/roundcube/roundcubemail/commit/0247b89c38c7f7ef1a2111239… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2012-11-28 (Wed, 28 Nov 2012) > > Changed paths: > M program/lib/Roundcube/rcube_user.php > M program/steps/mail/compose.inc > > Log Message: > ----------- > Move code for identity selection to function, move identities > formatting to rcube_user::list_identities() > > > Compare: > https://github.com/roundcube/roundcubemail/compare/511e1668e6f4...0247b89c3… > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

7 19

Regression with replies to own messages: Mail being addressed to myself
by Michael Heydekamp 07 Dec '12

07 Dec '12

In 0.8.4 (and since a few days ago also in 0.9-git-master) there is a pretty cool and intelligent logic when replying to own messages: They are addressed exactly in the same way as the message the user did send previously. So if an own message had those headers... ----------------------------- From: my.local.part(a)my.domain To: local.part1(a)do.main Cc: local.part2(a)do.main ----------------------------- ...then any self-created reply (to all) to this own message had also exactly the same headers. This logic got lost in 0.9-git-master a few days ago. :-( I just can't tell exactly when. Probably in connection with the identity issue (support of Delivered-To)...? Now the reply (to all) has these headers (if I don't edit them manually): ---------------------------------------------- From: my.local.part(a)my.domain To: my.local.part(a)my.domain Cc: local.part1(a)do.main, local.part2(a)do.main ---------------------------------------------- The same issue does apply in a similar way to messages with have been sent to a single recipient. Then a "normal" reply (i.e. not "to all") has these headers: ----------------------------- From: my.local.part(a)my.domain To: my.local.part(a)my.domain ----------------------------- This change of the previous behaviour isn't hopefully deliberate, is it? If it isn't: Shall I open a ticket? I loved the previous logic, as Roundcube is the only MUA that I'm aware of which does/did provide it. So please bring it back! ;) Regards, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 2

topline plugin
by Sébastien BLAISOT 06 Dec '12

06 Dec '12

Hi all, Thanks alec for the commit below which add containers to the topline. This let me introduce to you roundcube advanced users and developpers the topline plugin I'm working on which let you add some information to the topline for larry skin. It is exclusively designed for larry skin at the moment, I didn't even tried it with classic skin (maybe I will soon). You can find it here : https://github.com/sblaisot/roundcube-topline This plugin is now working out of the box with git versions of roundcube. With 0.8 releases, you'll have to apply this patch in order for the plugin to work : https://github.com/sblaisot/roundcube-topline/blob/master/roundcube-patch/r… Currently, you can add the wollowing information left (just after about and support links), center or right (just before logout button) to the topline : * - 'username' -> Show roundcube username * - 'mail_host' -> mail host against which authentication was done * - 'email' -> email of default's identity * - 'full_name' -> full name of default's identity * - 'lastlogin' -> date/time of previous login * - 'any text' -> the text you entered You can also remove username usually shown top right. Next step is to add more information available in the topline. Feel free to test it, send bug report or feature requests. regards, S. Blaisot -------- Message original -------- Sujet: Re: [Roundcube Webmail] #1488846: topline content Date : Thu, 06 Dec 2012 08:53:09 -0000 De : Roundcube Webmail <trac(a)roundcube.net> Répondre à : trac(a)roundcube.net Pour : undisclosed-recipients:; #1488846: topline content ------------------------------+----------------------- Reporter: sblaisot | Owner: Type: Feature Requests | Status: closed Priority: 5 | Milestone: 0.9-beta Component: User Interface | Version: 0.8.0 Severity: normal | Resolution: fixed Keywords: | ------------------------------+----------------------- Changes (by alec): * status: new => closed * resolution: => fixed Comment: Done in 04acc75f774f8bc6292f574375b6a2f23b3ac0d4 -- Ticket URL: <http://trac.roundcube.net/ticket/1488846#comment:3> Roundcube Webmail <http://www.roundcube.net/> Roundcube Webmail is a browser-based multilingual IMAP client with an application-like user interface. It provides full functionality you expect from an e-mail client, including MIME support, address book, spell checking, folder manipulation and plugins. Roundcube Webmail is written in PHP and requires a MySQL, Postgres, MSSql or SQlite database. The user interface is fully skinnable using XHTML and CSS 2.

1 0

password charset
by Cor Bosman 06 Dec '12

06 Dec '12

Hey all, is there a pressing reason that the password charset is not set to UTF-8 by default? For a password field I think UTF-8 should be safe to use? The worst that can happen is that passwords that didn't work, now work :) Cor

2 1

Re: [RCD] [Svn] [roundcube/roundcubemail] c7ff6e: Add workaround for IE<=8 bug where Content-Disposition:inline was ignored (#1488844)
by Michael Heydekamp 06 Dec '12

06 Dec '12

Thanks, A.L.E.C! I will see this night it it helps (but most likely it will). Really weird, this IE bug... BTW: Those GitHub messages in the SVN list are declared as CTE 7bit and charset UTF-8. Hmmm... ;-) -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 05.12.2012 09:46, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: c7ff6ec2cb985061438e5b68cfc5691b5a86422c > > https://github.com/roundcube/roundcubemail/commit/c7ff6ec2cb985061438e5b68c… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2012-12-05 (Wed, 05 Dec 2012) > > Changed paths: > M CHANGELOG > M program/steps/mail/get.inc > > Log Message: > ----------- > Add workaround for IE<=8 bug where Content-Disposition:inline was ignored (#1488844) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

1 1

Ensure target folder exists before move
by Daniel Kahn Gillmor 06 Dec '12

06 Dec '12

Hi roundcube folks-- http://trac.roundcube.net/ticket/1486802 was about roundcube failures to move drafts, sent messages, and deleted messages into their proper folders. It looks to me like it was fixed for drafts and sent messages, but it was *not* fixed for deleted messages. I can't seem to convince http://trac.roundcube.net/ to let me have an account, but i think that ticket should be re-opened. I think the attached patch fixes the situation for the trash (as well as fixing any other attempt to move into a folder that doesn't exist). Arguably, you might also want to subscribe to the newly-created folder, and not just create it; but as a baseline, i think this is a reasonable patch against v0.8.4. Please let me know if there's anything i should do to help get this adopted, or if there's some reason that this patch itself is a bad idea. Thanks for roundcube, --dkg

4 8

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev