Dev

dev@lists.roundcube.net

1 participants
4289 discussions

[PATCH]
by manu＠netbsd.org 25 Dec '12

25 Dec '12

Hello Please consider this patch, which allow plugins to add SASL mechanisms --- ./program/include/rcube_smtp.php.orig 2012-12-24 10:06:32.000000000 +0100 +++ ./program/include/rcube_smtp.php 2012-12-24 10:07:34.000000000 +0100 @@ -113,4 +113,19 @@ $this->conn->setDebug(true, array($this, 'debug_handler')); + + // plugin hook to add SASL mechanisms + $result = $RCMAIL->plugins->exec_hook('smtp_add_auth', array( + 'conn' => $this->conn, + )); + if (PEAR::isError($result)) + { + $this->response[] = "Authentication setup failed: ".$result->getMessage(); + $this->error = array('label' => 'smtpconnerror', 'vars' => array('code' => $this->conn->_code)); + $this->conn = null; + return false; + } + + + // register authentication methods if (!empty($CONFIG['smtp_auth_callbacks']) && method_exists($this->conn, 'setAuthMethod')) { -- Emmanuel Dreyfus http://hcpnet.free.fr/pubz manu(a)netbsd.org

2 1

Re: [RCD] [Svn] [roundcube/roundcubemail] 090c49: Treat image/pjpeg as image/jpeg
by Michael Heydekamp 23 Dec '12

23 Dec '12

The commit below didn't fix the issue here (IE8). -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 22.12.2012 16:42, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail [...] > Commit: 5f0bd1fcb40eae92e747e0e855b77639fd17fc4a > > https://github.com/roundcube/roundcubemail/commit/5f0bd1fcb40eae92e747e0e85… > Author: Thomas Bruederli <thomas(a)roundcube.net> > Date: 2012-12-22 (Sat, 22 Dec 2012) > > Changed paths: > M program/steps/mail/get.inc > > Log Message: > ----------- > Make html button-links work in IE

1 0

Updated patch for login on MX domain
by Vitex 21 Dec '12

21 Dec '12

Hallo Roundcube developers. We are runnig ISPConfig hosting with dedicated mailserver. Here is small patch to login if web's A and MX is different. Sorry for previous mistake. Please include it in new release. Thanks Vitex diff -Naur /roundcubemail-0.8.4/config/main.inc.php.dist ./config/main.inc.php.dist --- /roundcubemail-0.8.4/config/main.inc.php.dist 2012-11-14 21:30:27.000000000 +0100 +++ ./config/main.inc.php.dist 2012-12-20 19:35:21.000000000 +0100 @@ -71,6 +71,7 @@ // %n - http hostname ($_SERVER['SERVER_NAME']) // %d - domain (http hostname without the first part) // %s - domain name after the '@' from e-mail address provided at login screen +// %x - MX for domain name after the '@' from e-mail address provided at login screen // For example %n = mail.domain.tld, %d = domain.tld $rcmail_config['default_host'] = ''; diff -Naur /roundcubemail-0.8.4/program/include/main.inc ./program/include/main.inc --- /roundcubemail-0.8.4/program/include/main.inc 2012-11-14 21:30:28.000000000 +0100 +++ ./program/include/main.inc 2012-12-20 19:27:50.000000000 +0100 @@ -1684,7 +1684,14 @@ return false; } - $name = str_replace(array('%n', '%d', '%h', '%z', '%s'), array($n, $d, $h, $z, $s[2]), $name); + if ( strpos($name, '%x') !== false ){ + $user_email = rcube_idn_convert(get_input_value('_user', RCUBE_INPUT_POST), true); + if ( preg_match('/(.*)@([a-z0-9\.\-\[\]\:]+)/i', $user_email, $s) < 1 || filter_var($s[1]."@".$s[2], FILTER_VALIDATE_EMAIL) === false ) + return false; + getmxrr ( $s[2] , $mx ); + } + + $name = str_replace(array('%n', '%d', '%h', '%z', '%s','%x'), array($n, $d, $h, $z, $s[2],$mx[0]), $name); return $name; }

4 4

Patch for login on MX domain
by Vitex 20 Dec '12

20 Dec '12

Hallo Roundcube developers. We are runnig ISPConfig hosting with dedicated mailserver. Here is small patch to login if web's A and MX is different. Please include it in new release. Thanks Vitex diff -Naur /roundcubemail-0.8.4/config/main.inc.php.dist ./config/main.inc.php.dist --- /roundcubemail-0.8.4/config/main.inc.php.dist 2012-11-14 21:30:27.000000000 +0100 +++ ./config/main.inc.php.dist 2012-12-20 19:35:21.000000000 +0100 @@ -71,6 +71,7 @@ // %n - http hostname ($_SERVER['SERVER_NAME']) // %d - domain (http hostname without the first part) // %s - domain name after the '@' from e-mail address provided at login screen +// %x - MX for domain name after the '@' from e-mail address provided at login screen // For example %n = mail.domain.tld, %d = domain.tld $rcmail_config['default_host'] = ''; diff -Naur /roundcubemail-0.8.4/program/include/main.inc ./program/include/main.inc --- /roundcubemail-0.8.4/program/include/main.inc 2012-11-14 21:30:28.000000000 +0100 +++ ./program/include/main.inc 2012-12-20 19:27:50.000000000 +0100 @@ -1684,7 +1684,14 @@ return false; } - $name = str_replace(array('%n', '%d', '%h', '%z', '%s'), array($n, $d, $h, $z, $s[2]), $name); + if ( strpos($name, '%x') !== false ){ + $user_email = rcube_idn_convert(get_input_value('_user', RCUBE_INPUT_POST), true); + if ( preg_match('/(.*)@([a-z0-9\.\-\[\]\:]+)/i', $user_email, $s) < 1 || filter_var($s[1]."@".$s[2], FILTER_VALIDATE_EMAIL) === false ) + return false; + getmxrr ( $s[2] , $mx ); + } + + $name = str_replace(array('%n', '%d', '%h', '%z', '%s','%x'), array($n, $d, $h, $z, $s[2],$mx), $name); return $name; }

1 0

Re: [RCD] possible bug in roundcube ?
by Alessandro Vesely 14 Dec '12

14 Dec '12

On Thu Dec 13 23:28:23 CET 2012 Michael Heydekamp wrote: > Am 13.12.2012 17:13, schrieb Benny Pedersen: > >> http://tools.ietf.org/html/rfc5322#section-3.4 can be angle-addr >> only when there is a non-empty display-name. > > The "only" in this sentence is not correct. Right. I should have had more coffee yesterday :-/ > RFC-wise, both are correct. > > But being a purist in this respect, I would also prefer if Roundcube would > eliminate the angle brackets if no display name is given. The problem is that some software eliminates those angle-brackets, thereby breaking any DKIM signature added meanwhile. I'll make a patch to optionally avoid such behavior in Courier-MTA. (Belt and brackets.) Of course, it may be irritating for users not to be able to set an address exactly the way they want to. It takes a bit of wisdom to handle this issue adequately... Should I file a feature request for this? Ciao Ale

2 2

possible bug in roundcube ?
by Benny Pedersen 13 Dec '12

13 Dec '12

http://tools.ietf.org/html/rfc5322#section-3.4 can be angle-addr only when there is a non-empty display-name. in To: header with roundcube From: Benny Pedersen <me(a)junc.org> To: <opendkim-users(a)lists.opendkim.org> Subject: Re: adsp fail there must imho not be < > around To: header here example from mozilla From: Alessandro Vesely <vesely(a)tana.it> User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/17.0 Thunderbird/17.0 To: opendkim-users(a)lists.opendkim.org Subject: Re: adsp fail is more correct ?

3 2

is roundcube supposed to see calendar attachments?
by Cor Bosman 13 Dec '12

13 Dec '12

Hey all, i am getting some reports that people aren't seeing calendar attachments. Not even as a downloadable attachment. Is this supposed to work at all? I just verified and indeed am totally unable to see text/calendar attachments in roundcube in any shape or form. I suppose this is because it's a multipart/alternative and RC just shows the first one. But this works fine in OSX and other clients. And this is being sent by outlook and an android client so we're not talking some fringe clients. I tried changing this to a mixed multipart, but that doesn't help either. Some local config problem? Cor Content-Type: multipart/alternative; boundary="_002_E16AD7C7A3955F4E81058F413D1224A2016EE105ABEXBE4officexs_" --_002_E16AD7C7A3955F4E81058F413D1224A2016EE105ABEXBE4officexs_ Content-Type: text/plain; charset="iso-8859-1" Content-ID: <4C602A7FDD6F814780DA61DA58ED84FB(a)xs4all.net> Content-Transfer-Encoding: quoted-printable Organizer: "rj" <xxxxxxxx(a)xs4all.net> Start time: 2012-12-13 18:30 Central European Time End time: 2012-12-13 19:30 Central European Time *~*~*~*~*~*~*~*~*~* --_002_E16AD7C7A3955F4E81058F413D1224A2016EE105ABEXBE4officexs_ Content-Type: text/calendar; charset="utf-8"; method=REQUEST Content-Transfer-Encoding: base64 Q………. <the actual calendar invite>…. --_002_E16AD7C7A3955F4E81058F413D1224A2016EE105ABEXBE4officexs_--

3 4

Re: [RCD] [Svn] [roundcube/roundcubemail] bb5d72: Use also Envelope-To for identity selection (#1488553)
by Michael Heydekamp 13 Dec '12

13 Dec '12

Thanks! Is it planned to support the (last) Received: header as well (see messages from Sebastian J. Bronner and Harald Reindl in this list)? Regards, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 12.12.2012 08:55, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: bb5d7282855dd83ccdd211cb77d0776dce71468e > > https://github.com/roundcube/roundcubemail/commit/bb5d7282855dd83ccdd211cb7… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2012-12-11 (Tue, 11 Dec 2012) > > Changed paths: > M CHANGELOG > M program/lib/Roundcube/rcube_storage.php > M program/steps/mail/compose.inc > > Log Message: > ----------- > Use also Envelope-To for identity selection (#1488553) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

3 4

Format of GitHub messages in SVN list
by Michael Heydekamp 12 Dec '12

12 Dec '12

I sent this message to the SVN list already, but it appears that it doesn't arrive there (but I did also not receive a rejection through a moderator message). Since the move from SVN to GitHub, the format of the messages in the SVN list looks a bit strange to me: 1) Roundcube is displaying the attachment icon for each message, although there is no attachment at all in any of the messages. 2) All messages are declared as "multitype/mixed" for no real reason (the second part just containing the signature, this could perfectly be appended to the first part without creating a second part). 3) The Content-Type of the first part (i.e. the real content of the message) is "text/plain; charset=UTF-8", the Content-Transfer-Encoding "7bit". If CTE is 7bit, shouldn't the charset be "US-ASCII" then? The UTF-8 declaration will probably (and unnecessarily) invoke a decoding routine in most MUAs, although there is nothing to decode. 2) and 3) are minor issues, but 1) (the attachment icon) appears to be a wrong indication. Not sure if the declaration of the messages is misleading in some way, or if Roundcube's interpretation is wrong? If the latter, this could also affect any other messages. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

4 9

Re: [RCD] git-pull am 11.11. nicht geklappt? (was: [Svn] [roundcube/roundcubemail] d9f109: Allow forwarding of multiple emails (#1486854))
by Michael Heydekamp 12 Dec '12

12 Dec '12

Sorry, this mail shouldn' have gone to the list. Grrr... -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 12.12.2012 20:16, schrieb Michael Heydekamp: > Hallo Martin, > > siehe unten. Kannst Du da was feststellen? > > Gruß, > -- > Michael Heydekamp > xxxxxxxxxxxxx > xxxxxxxxxxxxxxxxxx > Tel.: xxxxxxxxxxxxxxxxxx (privat) > Tel.: xxxxxxxxxxxxxxxxxxxx (Büro) > Fax: xxxxxxxxxxxxxxxxx (Büro) > Mobil: xxxxxxxxxxxxxxxxxx > eMail: xxxxxxxxxxxxxxxxxxxx > WWW: xxxxxxxxxxxxxxxxxxxxxxx > > > Am 12.12.2012 20:10, schrieb Michael Heydekamp: >> Am 12.12.2012 19:10, schrieb A.L.E.C: >>> On 12/12/2012 06:50 PM, Michael Heydekamp wrote: >> >>>> How does this feature work? >>>> >>>> If I mark more than one message, the forward button is being disabled. >>> >>> Works for me. Forward button is enabled, only "forward inline" is disabled. >> >> Sorry, I wasn't careful enough. Due to some still unknown reason, our >> git-pull seems to have failed last night, as I'm still running "GIT >> 20121210.2232". Therefore it's more than logical that your commit of Dec >> 11th can't work here. Sorry... >> -- >> Michael Heydekamp >> Co-Admin freexp.de >> Düsseldorf/Germany >> _______________________________________________ >> Roundcube Development discussion mailing list >> dev(a)lists.roundcube.net >> http://lists.roundcube.net/mailman/listinfo/dev

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev