Hey Maximilien,

On 9/14/07, Maximilien Cuony maxi.the.glu@gmail.com wrote:

Here is my first patch for my filter's system.

I separate my filter system (named mc_filters) from the filter's interface.

In lib/Filters are the different classes for filter's system (for the moment only mc_filters and the base class).Filter's system used are stored in the main.inc.php.

So.. I'm open to all your remarks, like horribles English's mistakes ;).

The code is a bit ugly for the moment (I try to not edit your base files and the CSS so I re-use for ex. the classes for another pages for settings) ^^, but I will correct this later.

All is based on the revision 740 of the trunk.

What do you think about it ? What I have to change ?

Well, basically here is some feedback:

1. Use your own classes, don't add your code to "core" files.
2. Better create this against devel-vnext to make use of autoloading etc..

I couldn't try it yet and won't be able to do so soon - got a working demo or screens?

Till _______________________________________________ List info: http://lists.roundcube.net/dev/

Wow, I'm really impressed! Nevertheless I think the usability won't work out - for the average user it's too complicated. Here is what I would suggest:

-) Two panel layout - left panel shows the list, right panel allows to edit, after a filter is selected in the left panel. -) I'm missing reordering of filter rules (move up / down) -) Filter name & active checkbox is fine, but the "Block in OR mode" is not easy to get. -) put each block into one line and the and/or between all blocks.

As sample I attached the filter interface from Squirrelmail, which is not using any interaction, it's slow and sucks, but at least it's easy to understand. Basically I would love to see the same with some AJAX so reordering works without resubmitting and I can change stuff without resubmitting (notice the save icon next to each (!) block.

Thanks a lot for your hard work!

Mike

Maximilien Cuony wrote:

Here are some screens :

Filter's list : http://pix.nofrag.com/4/4/9/4d23379e4e40222777c9bd5b7db89.html Editing a filter : http://pix.nofrag.com/3/4/9/759cd88e87f8d2fbb3aae55749fa4.html

Maximilien Cuony wrote:

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

Hi,

...

Two panel layout - left panel shows the list, right panel allows to edit, after a filter is selected in the left panel.

Ok, Ajaxed ?

Sure, reloading the whole page is not really stylish nor usable.

...

I'm missing reordering of filter rules (move up / down)

Is it relay useful ?

Not only useful, but required. For example I want to have the Spam rule as first rule - everything that is spam is moved away. Or I want to filter one recipient away, independent of any subject filters. So yeah, mail filters always have to have a specified order.

...

Block in OR mode

Yes, my filters need a doc. I make blocks of filters, who can be validated independent that others, so we can make complicated filters. So in OR mode, if a block is validated, the filter is executed... (Of course, it's easy to disable this for an another filter's system).

The "or" can easily be achieved by two filter rules that are ordered. And that's much easier to understand and maintain then complex and/or/and/and/or rules....

...

put each block into one line and the and/or between all blocks.

No, for conds. I suppose ? Or the twos ?

I didn't use Ajax because it's my first time I use your APIs, so it's wasn't easy to find how it's works :). But now, I suppose it's will be ok for the devel-vnext ! (I hope you did't change all ^^)

Regards,

Regards, Mike

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: http://firegpg.tuxfamily.org

iD8DBQFG+2agjKKs5/FTCjURAkmDAKDQUlWiNj5D37DijmAK/XFi40YN7ACgzzF7 5KN4REtTP1SwJUpAV1uHhn4= =TSZm -----END PGP SIGNATURE-----

On 9/27/07, *Michael Baierl* <mail@mbaierl.com mailto:mail@mbaierl.com> wrote:

Wow,
I'm really impressed!
Nevertheless I think the usability won't work out - for the average
user
it's too complicated. Here is what I would suggest:

-) Two panel layout - left panel shows the list, right panel allows to
edit, after a filter is selected in the left panel.
-) I'm missing reordering of filter rules (move up / down)
-) Filter name & active checkbox is fine, but the "Block in OR mode" is
not easy to get.
-) put each block into one line and the and/or between all blocks.

As sample I attached the filter interface from Squirrelmail, which is
not using any interaction, it's slow and sucks, but at least it's easy
to understand.
Basically I would love to see the same with some AJAX so reordering
works without resubmitting and I can change stuff without resubmitting
(notice the save icon next to each (!) block.

Thanks a lot for your hard work!

Mike

Maximilien Cuony wrote:
 > Here are some screens :
 >
 > Filter's list :
 > http://pix.nofrag.com/4/4/9/4d23379e4e40222777c9bd5b7db89.html
 > Editing a filter :
 > http://pix.nofrag.com/3/4/9/759cd88e87f8d2fbb3aae55749fa4.html
<http://pix.nofrag.com/3/4/9/759cd88e87f8d2fbb3aae55749fa4.html>
 >

--
Michael Baierl
mbaierl.com <http://mbaierl.com>   http://mbaierl.com/
- - - - - - - - - - - - - - - - -
PHP 5 is progression. PHP 4 is stagnation.  (All Knight Access about
PHP4 vs PHP5)



--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for
viewing.
   http://detached.gigo.com/rc/s4/JY9r0afb/filters.png
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---


_______________________________________________
List info: http://lists.roundcube.net/dev/

-- ( o _ Maximilien Cuony [The glu] / / \ http://theglu.tuxfamily.org V_ /_ www.archlinux.org http://www.archlinux.org www.getfirefox.com http://www.getfirefox.com Ce mail est signé numériquement avec FireGPG. Clé publique : http://theglu.tuxfamily.org/public/cle.pgp