Dev

dev@lists.roundcube.net

2 participants
4318 discussions

Fwd: Patch for new features
by Marcelo Salhab Brogliato 30 Oct '07

30 Oct '07

---------- Forwarded message ---------- From: Marcelo Salhab Brogliato <msbrogli(a)gmail.com> Date: Oct 27, 2007 1:32 PM Subject: Re: [RCD] Patch for new features To: till <klimpong(a)gmail.com> Hello till, I don't have svn installed in the shell that I'm working on.. but I already sent an email asking for instalation! Soon I'll send my first patch :)) About the last feature that I sad: Let's get a situation: you are on the compose page writing some email.. so you wan't to see the address book to add more recipients. When you click Address Book, you "lost" your email (you can save in the draft)... Does you guys have a patch to solve this? Thanks for your help Salhab On 10/27/07, till <klimpong(a)gmail.com > wrote: > > Hi Salhab, > > no problem, but please CC the list, so others learn from this. :) > > Basically the best way is the following: > > 1) Get latest code from SVN (trunk) > 2) Migrate all your changes in there, test > 3) Create patches using "svn diff > feature.patch" > > Till > > On 10/27/07, Marcelo Salhab Brogliato <msbrogli(a)gmail.com> wrote: > > Hi Till, > > > > that's my first contribution to open source projects... I'm completelly > a > > newbie! :)) > > How can I create a patch? I have no idea... > > I think it isn't just attaching the files that I changed.. > > Maybe a CHANGELIST? Or a little tutorial with the codes and where they > > should be inserted? > > > > What do you mean by "configurable"? The name of the folders are fixed by > > now.. but a little > > change in the source make it user-defined :) > > > > Thanks for your answer. > > Salhab > > > > > > > > On 10/27/07, till <klimpong(a)gmail.com> wrote: > > > Hi Salhab, > > > > > > On 10/27/07, Marcelo Salhab Brogliato < msbrogli(a)gmail.com> wrote: > > > > Hi to everyone, > > > > I'm new to the list and working on RoundCube.. but I changed him a > > little to > > > > satisfy my needs. > > > > I implemented 3 features that you can check at: > > > > http://www.vialink.com.br/webmail4/ > > > > email: msbrogli2(a)vialink.com.br > > > > password: 123456 > > > > > > > > Essentially, it is: > > > > * a checkbox at the left... to make the life of the ones who aren't > > > > familiarized with AJAX (in my case, my customers) easier... > > > > so, they can easily select more than a message.. > > > > > > I thought there were discussions already and I don't think this will > > > make its way into the source. The reason is - we aim to provide a > > > desktop-like look and feel.I don't see checkboxes in Outlook, Eudora, > > > Thunderbird or kMail. > > > > > > > * a droplist to move selected messages between the folders > > > > * 2 buttons called SPAM and NO-SPAM.. they move the message to the > > folders > > > > Spam and No-Spam... but why? > > > > because I developed a script to periodically check that folders > and > > train > > > > spamassassin to work better... > > > > > > Not a bad idea. Are the folders configurable? (I obviously haven't > > > check your patch yet, because there was none attached. ;-)). > > > > > > > now I'm working on a preview window in the list page... like > Outlook.. > > just > > > > click the message and see the content.. > > > > a double click maximize the message... > > > > > > I think a preview pane is already included. > > > > > > > and my last modification (for now) will be a way to throw the > compose > > page > > > > add emails from contact list.. > > > > > > Not sure I understand. > > > > > > In general, if you want to provide a patch, make sure to open tickets > > > on our trac (0) and make sure to provide one patch per issue/feature - > > > > not a giant patch. > > > > > > > > > > sorry about my english... if i'm not clear, please ask! > > > > > > > > > > Thanks for your work! Looking forward to your thoughts! > > > > > > Till > _______________________________________________ List info: http://lists.roundcube.net/dev/

5 9

Re: [RCD] Right-to-Left Layout
by Ossama Khayat 30 Oct '07

30 Oct '07

As I pointed earlier the best solution would be to use a separate .css file the RTL language(s), which includes Arabic, Hebrew, Persian, Urdu and maybe others. - Ossama ----- Original Message ---- From: Robin Elfrink <elfrink(a)introweb.nl> To: RoundCube Development Mailing List <dev(a)lists.roundcube.net> Sent: Tuesday, October 30, 2007 2:43:04 PM Subject: Re: [RCD] Right-to-Left Layout Hi all, Attached is my first idea of how to implement right-to-left layouts. My native language is left-to-right, so I cannot help develop this further. Work is needed on image stuff as well. I haven't investigated, but probably most image-problems with rtl languages come from background images that should be moved to the other side. Maybe an include of a 'rtl.css' that overrides background settings will do? Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Ur/SjPNsK7C/rtl.20071030-1235.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Right-to-Left Layout
by Mohammad Ebrahim Mohammadi Panah 30 Oct '07

30 Oct '07

I think it is a design decision and shouldn't be done by me, but the RoundCube designers. Anyway I searched about implementing support of RTL languages in web applications, especially PHP. Here are a few useful links: RTL support in WordPress 2.1: http://boren.nu/archives/2007/01/07/rtl-support-in-wordpress-21/ RTL in HTML, XHTML, CSS2, CSS3: http://www.i18nguy.com/markup/right-to-left.html Language information and text direction (part of HTML 4.01 specification): http://www.w3.org/TR/html401/struct/dirlang.html I think this is the simplest idea: Set a global variable in a locale-dependent file which shows this locale is RTL. Then use it wherever a 'dir="RTL"' attribute is needed. Anyway it is up to designers to decide upon this. On 10/8/07, Thomas Bruederli <roundcube(a)gmail.com> wrote: > > Mohammad Ebrahim Mohammadi Panah wrote: > > Hello, > > I got the latest code from Subversion and tested it to see how it looks > > in Persian. RoundCube seems to have no support for right-to-left > > languages such as Persian and Arabic. It didn't change the layout to > > right-to-left when I chose Persian or Arabic. Please correct me if I'm > > wrong. > > Is there any plan to implement it? > > > Somebody once announced to implement this but I've never heard again from > that person. This has to be done by somebody who is familiar with > right-to-left websites and the Persian or Arabic language. All of your > developers are either American or European and have no idea about RTL > websites. > > You are very welcome to contribute the changes that are necessary for > this. > > Regards, > ~Thomas > -- Mohammad Ebrahim Mohammadi Panah _______________________________________________ List info: http://lists.roundcube.net/dev/

3 2

Re: [RCD] Right-to-Left Layout
by Ossama Khayat 27 Oct '07

27 Oct '07

If you want to quickly test using RTL and changing the page direction, you can right-click the RC window (in FireFox) and choose "Switch Page Direction" to see how it looks. The perfect solution IMHO would be: 1. Use a common.css file that defined the main stuff common to all languages or maybe including the whole thing. 2. Use a special .css file for RTL languages which would overwrite what is needed, like (align, float, padding-left, margin-left... etc) and change them as appropriate. With little change we can also allow the user to choose display the folders left, right or left, when the page's direction is switched as maybe just like an additional feature. Just my 2c - Ossama ----- Original Message ---- From: till <klimpong(a)gmail.com> To: Mohammad Ebrahim Mohammadi Panah <mebrahim(a)gmail.com> Cc: RoundCube Development Mailing List <dev(a)lists.roundcube.net> Sent: Saturday, October 27, 2007 5:09:44 PM Subject: Re: [RCD] Right-to-Left Layout On 10/27/07, Mohammad Ebrahim Mohammadi Panah <mebrahim(a)gmail.com> wrote: > I think it is a design decision and shouldn't be done by me, but the > RoundCube designers. What Thomas was suggesting is - neither of us uses a RTL language. So demand and interest are next to 0 right now. So unless you come forward with a patch or find someone who is interested in contributing this, it WILL NOT get done. :) > Anyway I searched about implementing support of RTL languages in web > applications, especially PHP. Here are a few useful links: > > RTL support in WordPress 2.1: > http://boren.nu/archives/2007/01/07/rtl-support-in-wordpress-21/ > RTL in HTML, XHTML, CSS2, CSS3: > http://www.i18nguy.com/markup/right-to-left.html > Language information and text direction (part of HTML 4.01 specification): > http://www.w3.org/TR/html401/struct/dirlang.html > > I think this is the simplest idea: > Set a global variable in a locale-dependent file which shows this locale is > RTL. Then use it wherever a 'dir="RTL"' attribute is needed. > Anyway it is up to designers to decide upon this. Can you summarize this? Do we just need to adjust the CSS for this to work,or what's the catch? (I read the wordpress-related post but it didn't say.) If you need to contribute language files, you could go ahead as well. Requires next to zero programming skills. http://translator.roundcube.net/ Till _______________________________________________ List info: http://lists.roundcube.net/dev/ __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Fwd: Right-to-Left Layout
by till 27 Oct '07

27 Oct '07

Let me just forward this to the list so maybe someone else can pick up. This could be done pretty fast then. I don't think we have many images with text anyway. I am thinking that instead of folders for LTR, this could be either a seperate default skin. Less complex this way, etc.. Feedback? Ideas? On 10/27/07, NetOne - Doichin Dokov <root(a)net1.cc> wrote: > till ??????: > > Can you summarize this? Do we just need to adjust the CSS for this to > > work,or what's the catch? (I read the wordpress-related post but it > > didn't say.) > > > Besides CSS, some images also will need to be mirrored horizontally, so > basically there will be LTR and RTL folders for images, if this should > get done. I was recently looking into a clients side using Joomla, and > was wondering what those two LTR and RTL folders are. > > _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Re: [RCD] Patch for new features
by till 27 Oct '07

27 Oct '07

Hi Salhab, no problem, but please CC the list, so others learn from this. :) Basically the best way is the following: 1) Get latest code from SVN (trunk) 2) Migrate all your changes in there, test 3) Create patches using "svn diff > feature.patch" Till On 10/27/07, Marcelo Salhab Brogliato <msbrogli(a)gmail.com> wrote: > Hi Till, > > that's my first contribution to open source projects... I'm completelly a > newbie! :)) > How can I create a patch? I have no idea... > I think it isn't just attaching the files that I changed.. > Maybe a CHANGELIST? Or a little tutorial with the codes and where they > should be inserted? > > What do you mean by "configurable"? The name of the folders are fixed by > now.. but a little > change in the source make it user-defined :) > > Thanks for your answer. > Salhab > > > > On 10/27/07, till <klimpong(a)gmail.com> wrote: > > Hi Salhab, > > > > On 10/27/07, Marcelo Salhab Brogliato <msbrogli(a)gmail.com> wrote: > > > Hi to everyone, > > > I'm new to the list and working on RoundCube.. but I changed him a > little to > > > satisfy my needs. > > > I implemented 3 features that you can check at: > > > http://www.vialink.com.br/webmail4/ > > > email: msbrogli2(a)vialink.com.br > > > password: 123456 > > > > > > Essentially, it is: > > > * a checkbox at the left... to make the life of the ones who aren't > > > familiarized with AJAX (in my case, my customers) easier... > > > so, they can easily select more than a message.. > > > > I thought there were discussions already and I don't think this will > > make its way into the source. The reason is - we aim to provide a > > desktop-like look and feel.I don't see checkboxes in Outlook, Eudora, > > Thunderbird or kMail. > > > > > * a droplist to move selected messages between the folders > > > * 2 buttons called SPAM and NO-SPAM.. they move the message to the > folders > > > Spam and No-Spam... but why? > > > because I developed a script to periodically check that folders and > train > > > spamassassin to work better... > > > > Not a bad idea. Are the folders configurable? (I obviously haven't > > check your patch yet, because there was none attached. ;-)). > > > > > now I'm working on a preview window in the list page... like Outlook.. > just > > > click the message and see the content.. > > > a double click maximize the message... > > > > I think a preview pane is already included. > > > > > and my last modification (for now) will be a way to throw the compose > page > > > add emails from contact list.. > > > > Not sure I understand. > > > > In general, if you want to provide a patch, make sure to open tickets > > on our trac (0) and make sure to provide one patch per issue/feature - > > not a giant patch. > > > > > > > sorry about my english... if i'm not clear, please ask! > > > > > > > Thanks for your work! Looking forward to your thoughts! > > > > Till _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Patch for new features
by Marcelo Salhab Brogliato 27 Oct '07

27 Oct '07

Hi to everyone, I'm new to the list and working on RoundCube.. but I changed him a little to satisfy my needs. I implemented 3 features that you can check at: http://www.vialink.com.br/webmail4/ email: msbrogli2(a)vialink.com.br password: 123456 Essentially, it is: * a checkbox at the left... to make the life of the ones who aren't familiarized with AJAX (in my case, my customers) easier... so, they can easily select more than a message.. * a droplist to move selected messages between the folders * 2 buttons called SPAM and NO-SPAM.. they move the message to the folders Spam and No-Spam... but why? because I developed a script to periodically check that folders and train spamassassin to work better... now I'm working on a preview window in the list page... like Outlook.. just click the message and see the content.. a double click maximize the message... and my last modification (for now) will be a way to throw the compose page add emails from contact list.. sorry about my english... if i'm not clear, please ask! Salhab _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Russian Localization
by Artur Smolkin 26 Oct '07

26 Oct '07

Hello everybody! I have updated russian localization for RoundCube Webmail. Changes: added translation for $labels['movemessagetotrash'] It can be downloaded here: http://dev.roundcube.ru/download/localization/russian/26102007.zip -- Regards, Artur Smolkin, RoundCube.Ru _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Firefox login bug [Ticket #1484639] [SOLVED]
by Andris Markevich 25 Oct '07

25 Oct '07

Hello. Yesterday I've made clean install of the latest RC2 and found interesting issue - I was unable to login via Firefox. Entering correct login/pass roundcube were redirecting me back to the login page. IE/Opera were working perfectly. After some research I've discovered that it was the bug with the cookie handling mechanism in the Roundcube. Some browsers understand multiple cookie setting in one session but it's breaking the idea of cookies. IE/Opera does handle but Firefox is one of them which do not handle such situations. If you'll check Firefox cache after login try you'll see 2 cookies with the same name and this is the main problem - Firefox can't decide which one to use :) and doesn't use anyone. In the sess_regenerate_id() you are setting new session id via cookie but previous definition already cached in the output buffer which was set by session_start() function. It's not recommended to do this because cookies do not overwrite previous instances but appends headers with new value. First of all you should delete previous cookie and than set new one. Here is patch. --- roundcubemail-0.1-rc2/program/include/session.inc +++ roundcube_my/program/include/session.inc @@ -173,6 +173,7 @@ session_id($random); $cookie = session_get_cookie_params(); + setcookie(session_name(), "", time() -3600); setcookie(session_name(), $random, $cookie['lifetime'], $cookie['path']); return true; P.S. In then near future I'm planning to revise russian, latvian localization. I saw that Artur Smolkin made some updates but just in case we'll check if something is missing or incorrect. P.S.S. Also it is possible to translate documentation to russian and latvian if you need. Regards, Andris _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Arabic Translation
by Ossama Khayat 24 Oct '07

24 Oct '07

Hi, Attached is the updated Arabic translation for 0.1RC2 regards, Ossama Khayat __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/ad/3Y7pOLhF/arabic.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev