Dev

dev@lists.roundcube.net

4290 discussions

Re: [RCD] "Always display images" option
by Ben 09 Oct '07

09 Oct '07

Thanks for your assistance, Harold and Fahrzin. I've developed the patch and have attached it to this message (let me know if there's someplace else I should send it instead). A few concerns: 1) The search() method in rcube_contacts.inc; I think while testing this patch, I think I found a glitch in it. If you have a contact in your address book and you delete it by mistake, then try to add the same contact again, it will see it as a duplicate and won't let you add it. This is because the search() method searches all contacts, even those with the `del` flag set. Should I try to fix this, or just file a bug report? Does anybody more familiar with the source know if it will break anything if I make it only search records not deleted? Or maybe when instructed to add a duplicate contact, Roundcube should simply turn off the 'del' flag if it's set? 2) I didn't know the best way to get the raw email address from the $MESSAGE headers, so I wrote a simple method that uses preg_match to extract it. If there's a better way, please let me know and I'll update my patch. 3) Caching causes a bit of a glitch in my patch. If you click a message with remote objects, click Always display, it will add the sender to the address book and display the images. If you go right back to the message however it will show the cached version so you have to Shift-Reload or it will appear it was unsuccessful. I'd be grateful if anybody knows a way around this. 4) As I'm monolinguistic, I've only added the message for it ($messages['alwaysshow']) to the en_US locale, so it won't display properly if your locale is different. Sorry. Let me know what you think. Thanks, Ben On Mon, 8 Oct 2007 23:12:20 +0200, Harold Aling <h.aling(a)home.nl> wrote: > > On Mon, 8 Oct 2007 15:57:12 -0400, Ben <ben(a)forlent.com> wrote: >> to start by writing a patch that allows you to "always display" images > in >> messages from specific senders, so you don't have to click "display >> images" >> each time you open their message. >> >> Being kind of new to this, my questions are as follows: >> >> 1) is anybody already working on this feature? > > Check the bug reports/feature requests on trac... > >> 2) If I do develop it, would it likely be added to the project? > > If it's well written, modulair and easy to implement: sure... > >> 3) How would I go about implementing it? Just download the SVN and patch >> it? Then do I send this list the patched files or just the snippets I >> modified or something else? > > I believe that's the best way to do it. It'll probably won't make it into > 1.0, so I'd guess writing it against SVN would give you the best base... > >> 4) From a technical standpoint, what would be the best way to store the >> whitelist of email senders? Flatfile, new database table, or in the >> address >> book? > > I'd go for the addressbook option. Email addresses which are stored in the > addressbook are in my case always trusted... > >> >> Thanks, >> Ben > > Good luck! > > > -H- --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/mW/maW5sP0T/display_images.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

"Always display images" option
by Ben 09 Oct '07

09 Oct '07

Hey everybody, I've been using Roundcube for a couple weeks now and am absolutely thrilled to have a real replacement for GMail. There are a couple features I'd like to see plus I've been meaning to get involved in FOSS development. I'd like to start by writing a patch that allows you to "always display" images in messages from specific senders, so you don't have to click "display images" each time you open their message. Being kind of new to this, my questions are as follows: 1) is anybody already working on this feature? 2) If I do develop it, would it likely be added to the project? 3) How would I go about implementing it? Just download the SVN and patch it? Then do I send this list the patched files or just the snippets I modified or something else? 4) From a technical standpoint, what would be the best way to store the whitelist of email senders? Flatfile, new database table, or in the address book? Thanks, Ben _______________________________________________ List info: http://lists.roundcube.net/dev/

3 2

Right-to-Left Layout
by Mohammad Ebrahim Mohammadi Panah 08 Oct '07

08 Oct '07

Hello, I got the latest code from Subversion and tested it to see how it looks in Persian. RoundCube seems to have no support for right-to-left languages such as Persian and Arabic. It didn't change the layout to right-to-left when I chose Persian or Arabic. Please correct me if I'm wrong. Is there any plan to implement it? -- Mohammad Ebrahim Mohammadi Panah _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Identities
by Brett Patterson 07 Oct '07

07 Oct '07

Got this in a private message on the forums. Thought I'd pass it along: You and the rest of the team are doing a great job. This might not be the right way to send this information but I have posted about this before with no results, so here it is for You and the rest of the team to do whatever You want with. My improvements to the identity section. The easy one is about the sort order in the indentity list. Code: /program/steps/settings/func.inc function rcmail_indentities_list..... // get contacts from DB ORDER BY standard DESC, name ASC, email ASC // this one is new.... The second one is a bit more. It improves the identity section in two ways. 1. You can NOT add an identity 'outside' your own domain. That is if You are logged in as 'mail(a)gunfro.com' You could only add identities to that domain. 2. You can NOT add an identity if it already exists in the domain. The domain You are logged into. I made this in one chunk so it easier to add. It might be better to put the code more where it belongs, hope You get my point. Code: /program/steps/settings/save_identities.php // check input if (empty($_POST['_name']) || empty($_POST['_email'])) { $OUTPUT->show_message('formincomplete', 'warning'); rcmail_overwrite_action('edit-identitiy'); return; } //********************************************************************* // MOD GUNFRO START $newa = explode("@", $_POST['_email']); $curr = explode("@", $_SESSION['username']); // Check valid domain. if ($newa[1] != $curr[1]) { $OUTPUT->show_message('domainnotvalid', 'warning'); rcmail_overwrite_action($_framed ? 'edit-identity' : 'identities'); return; } // Check if changing email and it exits. if ($_POST['_iid']) { $DB->query("SELECT * FROM ".get_table_name('identities')." WHERE identity_id=? AND del<>1", $_POST['_iid']); $curri = $DB->fetch_assoc(); if ($curri['email'] <> $_POST['_email']) { $DB->query("SELECT * FROM ".get_table_name('identities')." WHERE email=? AND del<>1", $_POST['_email']); if ($DB->fetch_assoc() != NULL) { $OUTPUT->show_message('emailexists', 'warning'); rcmail_overwrite_action($_framed ? 'edit-identity' : 'identities'); return; } } } else { // Just new a identity $DB->query("SELECT * FROM ".get_table_name('identities')." WHERE email=? AND del<>1", $_POST['_email']); if ($DB->fetch_assoc() != NULL) { $OUTPUT->show_message('emailexists', 'warning'); rcmail_overwrite_action($_framed ? 'edit-identity' : 'identities'); return; } } // MOD GUNFRO END //********************************************************************* // update an existing contact if ($_POST['_iid']) That was my contribution for now. Best regards Gunnar Frödin / GunFro -- ~ Brett Patterson _______________________________________________ List info: http://lists.roundcube.net/dev/

4 5

Esperanto translation of RoundCube 0.1rc1
by andreas 05 Oct '07

05 Oct '07

Hi, I translated RoundCube to Esperanto; see attachment. Andreas --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/YJ/Ad9KsuC0/eo.tar.gz Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Updated French translation
by Jonathan Ernst 04 Oct '07

04 Oct '07

Please find attached an up-to-date version of the French localisation. Best regards. Jonathan Ernst --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/sH/75tKS+7D/fr.tar.gz Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Updated French translation
by Jonathan Ernst 04 Oct '07

04 Oct '07

Please find attached an up-to-date version of the French localisation. Best regards. Jonathan Ernst --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/17/yqTgpWGw/fr.tar.gz http://detached.gigo.com/rc/17/yqTgpWGw/signature.asc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Lithuanian translation
by Martynas Bendorius 03 Oct '07

03 Oct '07

Lithuanian translation for the latest release of RoundCube webmail. -- Su pagarba, Martynas Bendorius --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/cA/jWWfaBQU/messages.inc http://detached.gigo.com/rc/cA/jWWfaBQU/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Fwd: Re: Folder management drag/drop
by Harold Aling 03 Oct '07

03 Oct '07

On Wed, 26 Sep 2007 17:34:03 +0200, "Thomas Bruederli" <roundcube(a)gmail.com> wrote: > 2007/9/26, Robin Elfrink <elfrink(a)introweb.nl>: >> Thomas Bruederli wrote: >> >> > My folders are all top-level and $IMAP->delimiter is empty. The >> > resulting expression is /.*/ which removes all characters from the >> > folder name. I'd suggest to split the folder name by the delimiter and >> > then use the last array index (which would be 0 in my case). >> >> An empty delimiter. Never thought of that. Okay, fixed. > > I tested it on my Mac (IMAP daemon from Postfix Enabler which is > derived from UW-IMAP) and added a default delimiter (r824). The server > did not define any and exploding a string by NULL results in an empty > array. > I might be wrong about this, but about the time this 'fix' got in, my folder list doesn't nest folders anymore. Folder Folder.Subfolder -instead of- Folder Subfolder How can I set the delimiter(.) again? I'm on r851/Dovecot-imapd btw. -H- > Sorry for bitching again but there are still some issues (see > http://trac.roundcube.net/trac.cgi/ticket/1457344#comment:12) which > should be solved before we can consider this feature as completed. > > ~Thomas > _______________________________________________ > List info: http://lists.roundcube.net/dev/ _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Updated Persian Translation
by Anoosh 02 Oct '07

02 Oct '07

Hi Updated Persian translation is attached. P.S. I read about people having to confirm the translations, if it's done like this, tell me how exactly they should confirm. (because I do know some friends and others who use RoundCube with Persian language) Regards Ardnoosh --------------------------------- Pinpoint customers who are looking for what you sell. --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/cf/GP4UXk7N/labels.inc http://detached.gigo.com/rc/cf/GP4UXk7N/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev